chore: update gradlew command in developer guide#2695
chore: update gradlew command in developer guide#2695brutalsachin wants to merge 1 commit intohiero-ledger:mainfrom
Conversation
Signed-off-by: Sachin Yadav <sachinyadav578478@gmail.com>
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull request overview
This PR updates the SDK developer guide to correct the Gradle command used for regenerating protobuf sources and adds guidance about selecting the protobuf reference used by the update script.
Changes:
- Replaced the proto update command from
./gradlew updateSnapshotsto./gradlew updateProto. - Added a note about updating the
checkout_refused byupdate_protobufs.pybefore running the proto update task.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ```sh | ||
| ./gradlew updateSnapshots | ||
| ./gradlew updateProto | ||
| Note: checkout_ref variable in update_protobufs.py should be updated with the version with needed protobufs before running the command | ||
| ``` |
There was a problem hiding this comment.
The "Note:" line is inside the fenced sh code block, so copying/pasting the snippet will try to execute it as a shell command and fail. Move the note outside the code fence (e.g., as a Markdown blockquote) and consider referencing the actual path scripts/update_protobufs.py plus clearer wording about what checkout_ref should be set to.
|
Hi, I have addressed the review feedback. Please let me know if anything else is needed. Thank you! |
mustafauzunn
changed the title
mustafauzunn
left a comment
mustafauzunn
left a comment
There was a problem hiding this comment.
@brutalsachin Thanks for the contribution! 🎉
Please move the Note outside of the sh block and also sign commits with gpg
This PR fixes the incorrect gradlew command in developer-guide.md.
Changes:
./gradlew updateSnapshotswith./gradlew updateProtocheckout_refvariable in update_protobufs.pyFixes #2694