feat: implement automatic chunking for FileCreate and FileUpdate#2806
Open
Didzapp-Dave wants to merge 10 commits into
Open
feat: implement automatic chunking for FileCreate and FileUpdate#2806Didzapp-Dave wants to merge 10 commits into
Didzapp-Dave wants to merge 10 commits into
Conversation
transactions (hiero-ledger#1983) Signed-off-by: David Campbell <davidcampbell0025@gmail.com>
transactions (hiero-ledger#1983) Signed-off-by: David Campbell <davidcampbell0025@gmail.com>
Signed-off-by: David Campbell <davidcampbell0025@gmail.com>
Signed-off-by: David Campbell <davidcampbell0025@gmail.com>
…://github.com/Didzapp-Dave/hiero-sdk-java.git into Refactor_FileCreate_FileUpdate_and_FileAppend
Signed-off-by: David Campbell <davidcampbell0025@gmail.com>
…://github.com/Didzapp-Dave/hiero-sdk-java.git into Refactor_FileCreate_FileUpdate_and_FileAppend
Signed-off-by: David Campbell <davidcampbell0025@gmail.com>
Signed-off-by: David Campbell <davidcampbell0025@gmail.com>
Contributor
Author
|
Apologies for the amount of commits, delete and restores ect ... I'm still working out the UI and how git works, i was trying to reset the branch so it looked like the work was done in one commit. I'm not sure if that creates less work for the reviewer or not , but i was unable to. Any advice you can spare on uploading PR's would be appreciated. thanks for your patience and understanding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements automatic chunking for FileCreateTransaction and FileUpdateTransaction, bringing them into parity with FileAppendTransaction.
Currently, FileCreate and FileUpdate are limited to a single transaction size. By refactoring these to extend ChunkedTransaction, they can now handle large content by automatically splitting data into chunks.
Related issue(s):
Fixes #1983
Notes for reviewer:
Changes
Checklist