refactor: centralize Good First Issue labels and remove migration script

Signed-off-by: DeathGun44 <krishnamewara841@gmail.com>

Author: DeathGun44

.github/scripts/bot-gfi-assign-on-comment.js

@@ -6,9 +6,9 @@
 
 const fs = require('fs'); // For spam list
 
-const GOOD_FIRST_ISSUE_LABEL = 'Good First Issue';
+const { GOOD_FIRST_ISSUE_LABEL } = require('./shared/labels.js');
 const UNASSIGNED_GFI_SEARCH_URL =
-    'https://github.com/hiero-ledger/hiero-sdk-python/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22Good%20First%20Issue%22%20no%3Aassignee';
+    `https://github.com/hiero-ledger/hiero-sdk-python/issues?q=${encodeURIComponent(`is:issue state:open label:"${GOOD_FIRST_ISSUE_LABEL}" no:assignee`)}`;
 
 const SPAM_LIST_PATH = '.github/spam-list.txt';
 

.github/scripts/bot-gfi-candidate-notification.js

@@ -1,5 +1,6 @@
 // Script to notify the team when a Good First Issue Candidate is created.
 
+const { GOOD_FIRST_ISSUE_CANDIDATE_LABEL } = require('./shared/labels.js');
 const marker = '<!-- GFI Candidate Notification -->';
 const TEAM_ALIAS = '@hiero-ledger/hiero-sdk-good-first-issue-support';
 
@@ -53,7 +54,7 @@ module.exports = async ({ github, context }) => {
     }
 
     //  Only handle Good First Issue Candidate
-    if (label.name.toLowerCase() !== 'good first issue candidate') {
+    if (label.name.toLowerCase() !== GOOD_FIRST_ISSUE_CANDIDATE_LABEL.toLowerCase()) {
       return;
     }
 

.github/scripts/bot-next-issue-recommendation.js

@@ -1,4 +1,16 @@
-const { BEGINNER_LABEL, INTERMEDIATE_LABEL, ADVANCED_LABEL } = require('./shared/labels.js');
+const {
+  GOOD_FIRST_ISSUE_LABEL,
+  BEGINNER_LABEL,
+  INTERMEDIATE_LABEL,
+  ADVANCED_LABEL,
+  isSafeLabel,
+} = require('./shared/labels.js');
+
+for (const label of [GOOD_FIRST_ISSUE_LABEL, BEGINNER_LABEL, INTERMEDIATE_LABEL, ADVANCED_LABEL]) {
+  if (!isSafeLabel(label)) {
+    throw new Error(`Invalid configured label: ${label}`);
+  }
+}
 
 const SUPPORTED_GFI_REPOS = [
   'hiero-sdk-cpp',
@@ -61,7 +73,7 @@ module.exports = async ({ github, context, core }) => {
     // Determine issue difficulty level
     const difficultyLevels = {
       beginner: labelSet.has(BEGINNER_LABEL.toLowerCase()),
-      goodFirstIssue: labelSet.has('good first issue'),
+      goodFirstIssue: labelSet.has(GOOD_FIRST_ISSUE_LABEL.toLowerCase()),
       intermediate: labelSet.has(INTERMEDIATE_LABEL.toLowerCase()),
       advanced: labelSet.has(ADVANCED_LABEL.toLowerCase()),
     };
@@ -83,21 +95,21 @@ module.exports = async ({ github, context, core }) => {
     let isFallback = false;
 
     recommendedIssues = await searchIssues(github, core, repoOwner, repoName, BEGINNER_LABEL);
-    recommendedLabel = 'Beginner';
+    recommendedLabel = BEGINNER_LABEL;
 
     if (recommendedIssues.length === 0) {
       isFallback = true;
-      recommendedIssues = await searchIssues(github, core, repoOwner, repoName, 'good first issue');
-      recommendedLabel = 'Good First Issue';
+      recommendedIssues = await searchIssues(github, core, repoOwner, repoName, GOOD_FIRST_ISSUE_LABEL);
+      recommendedLabel = GOOD_FIRST_ISSUE_LABEL;
     }
 
 
     // Remove the issue they just solved
     recommendedIssues = recommendedIssues.filter(i => i.number !== issueNumber);
 
     // Generate and post comment
-    const completedLabel = difficultyLevels.goodFirstIssue ? 'Good First Issue' : 'Beginner';
-    const completedLabelText = completedLabel === 'Beginner' ? 'Beginner issue' : completedLabel;
+    const completedLabel = difficultyLevels.goodFirstIssue ? GOOD_FIRST_ISSUE_LABEL : BEGINNER_LABEL;
+    const completedLabelText = completedLabel === BEGINNER_LABEL ? `${BEGINNER_LABEL} issue` : completedLabel;
     const recommendationMeta = {
       completedLabelText,
       recommendedLabel,
@@ -172,7 +184,7 @@ async function generateAndPostComment(github, context, core, prNumber, recommend
       `org:${context.repo.owner}`,
       'archived:false',
       'no:assignee',
-      '(label:"good first issue" OR label:"skill: good first issue")',
+      `label:"${GOOD_FIRST_ISSUE_LABEL}"`,
       `(${repoQuery})`,
     ].join(' ');
 

.github/scripts/coderabbit_plan_trigger.js

@@ -1,7 +1,7 @@
 // Script to trigger CodeRabbit plan for intermediate and advanced issues
 
 const CODERABBIT_MARKER = '<!-- CodeRabbit Plan Trigger -->';
-const { DIFFICULTY_LABELS } = require('./shared/labels.js');
+const { DIFFICULTY_LABELS, GOOD_FIRST_ISSUE_LABEL } = require('./shared/labels.js');
 
 async function triggerCodeRabbitPlan(github, owner, repo, issue, marker = CODERABBIT_MARKER, isDryRun = false) {
   const comment = `${marker} @coderabbitai plan`;
@@ -33,8 +33,12 @@ async function triggerCodeRabbitPlan(github, owner, repo, issue, marker = CODERA
 }
 
 function hasBeginnerOrHigherLabel(issue, label) {
-  // Check if issue has a difficulty label (case-insensitive)
-  const allowed = new Set(DIFFICULTY_LABELS.map(d => d.toLowerCase()));
+  // Only beginner+ labels qualify here; GFI gets its own CodeRabbit plan
+  // trigger via the assignment bot chain (bot-gfi-assign-on-comment.js).
+  const beginnerPlus = DIFFICULTY_LABELS
+    .filter(d => d !== GOOD_FIRST_ISSUE_LABEL)
+    .map(d => d.toLowerCase());
+  const allowed = new Set(beginnerPlus);
 
   const hasAllowedLabel = issue.labels?.some(l => allowed.has(l?.name?.toLowerCase()));
 

.github/scripts/cron-admin-update-spam-list.js

@@ -8,6 +8,11 @@
  */
 
 const fs = require('fs').promises;
+const { GOOD_FIRST_ISSUE_LABEL, isSafeLabel } = require('./shared/labels.js');
+
+if (!isSafeLabel(GOOD_FIRST_ISSUE_LABEL)) {
+  throw new Error(`Invalid GOOD_FIRST_ISSUE_LABEL: ${GOOD_FIRST_ISSUE_LABEL}`);
+}
 
 const SPAM_LIST_PATH = '.github/spam-list.txt';
 const dryRun = (process.env.DRY_RUN || 'false').toString().toLowerCase() === 'true';
@@ -137,7 +142,7 @@ module.exports = async ({github, context, core}) => {
       },
       {
         name:  'rehabilitated PRs',
-        query: `repo:${owner}/${repo} is:pr is:merged label:"Good First Issue"`,
+        query: `repo:${owner}/${repo} is:pr is:merged label:"${GOOD_FIRST_ISSUE_LABEL}"`,
         process: async (pr) => {
          if (!pr.user?.login) {
             console.log(`Skipping PR #${pr.number}: user account unavailable`);

.github/scripts/migrate-skill-labels.sh

@@ -8,18 +8,28 @@
  * corresponding workflow YAML `if:` conditions (which cannot import JS).
  *
  * Environment variable overrides are supported for per-workflow customization:
+ *   GOOD_FIRST_ISSUE_LABEL, GOOD_FIRST_ISSUE_CANDIDATE_LABEL,
  *   BEGINNER_LABEL, INTERMEDIATE_LABEL, ADVANCED_LABEL
  */
 
-const BEGINNER_LABEL     = process.env.BEGINNER_LABEL?.trim()     || 'skill: beginner';
-const INTERMEDIATE_LABEL = process.env.INTERMEDIATE_LABEL?.trim() || 'skill: intermediate';
-const ADVANCED_LABEL     = process.env.ADVANCED_LABEL?.trim()     || 'skill: advanced';
+const GOOD_FIRST_ISSUE_LABEL           = process.env.GOOD_FIRST_ISSUE_LABEL?.trim()           || 'Good First Issue';
+const GOOD_FIRST_ISSUE_CANDIDATE_LABEL = process.env.GOOD_FIRST_ISSUE_CANDIDATE_LABEL?.trim() || 'Good First Issue Candidate';
+const BEGINNER_LABEL                   = process.env.BEGINNER_LABEL?.trim()                   || 'skill: beginner';
+const INTERMEDIATE_LABEL               = process.env.INTERMEDIATE_LABEL?.trim()               || 'skill: intermediate';
+const ADVANCED_LABEL                   = process.env.ADVANCED_LABEL?.trim()                   || 'skill: advanced';
 
 /**
- * All difficulty labels as an array, for scripts that need to check
- * whether an issue has *any* difficulty label (e.g. coderabbit_plan_trigger).
+ * All difficulty labels as an array, ordered by ascending difficulty.
+ *
+ * Scripts that need to check whether an issue has *any* difficulty label
+ * (e.g. coderabbit_plan_trigger) should test against this array.
  */
-const DIFFICULTY_LABELS = [BEGINNER_LABEL, INTERMEDIATE_LABEL, ADVANCED_LABEL];
+const DIFFICULTY_LABELS = [
+  GOOD_FIRST_ISSUE_LABEL,
+  BEGINNER_LABEL,
+  INTERMEDIATE_LABEL,
+  ADVANCED_LABEL,
+];
 
 /**
  * Validates a label string for safe use in API queries.
@@ -35,10 +45,12 @@ const DIFFICULTY_LABELS = [BEGINNER_LABEL, INTERMEDIATE_LABEL, ADVANCED_LABEL];
  * @returns {boolean} True if the value is safe for use in queries.
  */
 function isSafeLabel(value) {
-  return typeof value === 'string' && value.length > 0 && /^[a-zA-Z0-9._/: \-]+$/.test(value);
+  return typeof value === 'string' && value.trim().length > 0 && /^[a-zA-Z0-9._/: \-]+$/.test(value);
 }
 
 module.exports = {
+  GOOD_FIRST_ISSUE_LABEL,
+  GOOD_FIRST_ISSUE_CANDIDATE_LABEL,
   BEGINNER_LABEL,
   INTERMEDIATE_LABEL,
   ADVANCED_LABEL,