reverted the test codes, and some minor fixes

Author: darshit2308

.github/scripts/review-sync/helpers/labels.js

@@ -80,13 +80,19 @@ async function hasCIFailures(github, owner, repo, sha) {
 /**
  * Determine the correct queue label for a PR based on approval counts.
  *
- * Phase 1 logic (4-stage pipeline):
- *   maintainerApprovals >= 1 AND coreApprovals >= 2  → status: ready-to-merge      (CODEOWNERS + min core reviews)
- *   coreApprovals >= 1                               → queue:maintainers   (senior review present, needs more)
- *   anyApproval >= 1                                 → queue:committers    (has any approval, needs committer)
+ * Phase 1 logic (5-stage pipeline):
+ *   ciFailing                                        → queue:junior-committer (CI broken, block promotion)
+ *   maintainerApprovals >= 1 AND coreApprovals >= 2  → status: ready-to-merge (CODEOWNERS + min core reviews)
+ *   maintainerApprovals >= 1 (but coreApprovals < 2) → queue:committers      (maintainer already in, need committer next)
+ *   coreApprovals >= 1 (no maintainer yet)            → queue:maintainers     (committer reviewed, needs maintainer)
+ *   anyApproval >= 1                                 → queue:committers      (has soft approval, needs committer)
  *   else                                             → queue:junior-committer (no approvals yet)
  *
- * Note: status: ready-to-merge requires BOTH a maintainer approval AND at least 2
+ * Note: When a maintainer "jumps in early" before triage/committers, the PR should
+ * route to queue:committers (not queue:maintainers) to attract a committer review
+ * rather than a second maintainer. This prevents wasting maintainer bandwidth.
+ *
+ * status: ready-to-merge requires BOTH a maintainer approval AND at least 2
  * total core reviews (maintainer or committer). This prevents a single maintainer approval
  * + a soft approval from marking a PR as ready when branch protection requires 2+ core reviews.
  *

.github/scripts/review-sync/tests/test-labels.js

@@ -39,7 +39,7 @@ const unitTests = [
     },
   },
   {
-    name: 'determineLabel: 1 maintainer alone → queue:committers (maintainer reviewed, needs 1 core)',
+    name: 'determineLabel: 1 maintainer alone → queue:committers (maintainer reviewed, needs committer next)',
     test: () => {
       // Sophie's edge case: maintainer approves first, only 1 total review
       // Note: maintainer counts as both maintainer and core
@@ -56,7 +56,7 @@ const unitTests = [
     },
   },
   {
-    name: 'determineLabel: 1 maintainer + 1 soft → queue:committers (soft does not count as core, needs 1 core)',
+    name: 'determineLabel: 1 maintainer + 1 soft → queue:committers (soft does not count as core, needs committer)',
     test: () => {
       const r = determineLabel({ maintainerApprovals: 1, coreApprovals: 1, softApprovals: 1, anyApproval: 2 });
       return r.name === 'queue:committers';

.github/workflows/review-sync.yml

@@ -34,7 +34,7 @@ concurrency:
 
 jobs:
   sync:
-    runs-on: ubuntu-latest
+    runs-on: hl-sdk-py-lin-md
     env:
       DRY_RUN: ${{ inputs.dry_run || 'false' }}
 

.github/workflows/test-review-sync.yml

@@ -12,7 +12,7 @@ on:
 
 jobs:
   test:
-    runs-on: ubuntu-latest
+    runs-on: hl-sdk-py-lin-md
     permissions:
       contents: read
     steps: