Merge branch 'main' into clean-priority-critical-fix

tannaya7 · web-flow · commit 413018a9f76a · 2026-04-16T22:50:20.000+05:30
diff --git a/.github/scripts/bot-inactivity-unassign.sh b/.github/scripts/bot-inactivity-unassign.sh
@@ -24,7 +24,7 @@ if [[ -z "$REPO" ]]; then
 fi
 
 echo "------------------------------------------------------------"
-echo " Unified Inactivity Bot"
+echo " Cron Reminder: Inactivity Unassign"
 echo " Repo:     $REPO"
 echo " Threshold $DAYS days"
 echo " DRY_RUN:  $DRY_RUN"
@@ -170,7 +170,7 @@ for ISSUE in $ISSUES; do
 
         if (( DRY_RUN == 0 )); then
           MESSAGE=$(cat <<EOF
-Hi @$USER, this is InactivityBot 👋
+Hi @$USER, this is CronInactivityBot 👋
 
 You were assigned to this issue **${ASSIGNED_AGE_DAYS} days** ago, and there is currently no open pull request linked to it.
 To keep the backlog available for active contributors, I'm unassigning you for now.
@@ -238,7 +238,7 @@ EOF
 
         if (( DRY_RUN == 0 )); then
           MESSAGE=$(cat <<EOF
-Hi @$USER, this is InactivityBot 👋
+Hi @$USER, this is CronInactivityBot 👋
 
 This pull request has had no new commits for **${PR_AGE_DAYS} days**, so I'm closing it and unassigning you from the linked issue to keep the backlog healthy.
 
@@ -270,6 +270,6 @@ EOF
 done
 
 echo "------------------------------------------------------------"
-echo " Unified Inactivity Bot Complete"
+echo " Cron Reminder: Inactivity Unassign Complete"
 echo " DRY_RUN: $DRY_RUN"
 echo "------------------------------------------------------------"
diff --git a/.github/scripts/cron-admin-update-spam-list.js b/.github/scripts/cron-admin-update-spam-list.js
diff --git a/.github/scripts/cron-calls-community.sh b/.github/scripts/cron-calls-community.sh
diff --git a/.github/scripts/cron-calls-office-hours.sh b/.github/scripts/cron-calls-office-hours.sh
diff --git a/.github/scripts/cron-enforcer-pr-linked-issue.js b/.github/scripts/cron-enforcer-pr-linked-issue.js
diff --git a/.github/scripts/cron-reminder-issue-no-pr.sh b/.github/scripts/cron-reminder-issue-no-pr.sh
diff --git a/.github/scripts/cron-reminder-pr-inactive.js b/.github/scripts/cron-reminder-pr-inactive.js
diff --git a/.github/workflows/cron-admin-update-spam-list.yml b/.github/workflows/cron-admin-update-spam-list.yml
@@ -36,5 +36,5 @@ jobs:
 
         with:
           script: |
-            const updateSpamList = require('./.github/scripts/update-spam-list.js');
+            const updateSpamList = require('./.github/scripts/cron-admin-update-spam-list.js');
             await updateSpamList({ github, context, core });
diff --git a/.github/workflows/cron-calls-community.yml b/.github/workflows/cron-calls-community.yml
@@ -39,4 +39,4 @@ jobs:
                   GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
                   DRY_RUN: ${{ github.event_name == 'workflow_dispatch' && inputs.dry_run || 'false' }}
               run: |
-                  bash .github/scripts/cron-community-calls.sh
+                  bash .github/scripts/cron-calls-community.sh
diff --git a/.github/workflows/cron-calls-office-hours.yml b/.github/workflows/cron-calls-office-hours.yml
@@ -38,4 +38,4 @@ jobs:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           DRY_RUN: ${{ github.event_name == 'workflow_dispatch' && inputs.dry_run || 'false' }}
         run: |
-          bash .github/scripts/cron-office-hours.sh
+          bash .github/scripts/cron-calls-office-hours.sh
diff --git a/.github/workflows/cron-enforcer-pr-linked-issue.yml b/.github/workflows/cron-enforcer-pr-linked-issue.yml
@@ -38,5 +38,5 @@ jobs:
         uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 #v9.0.0
         with:
           script: |
-            const script = require('./.github/scripts/linked_issue_enforce.js');
+            const script = require('./.github/scripts/cron-enforcer-pr-linked-issue.js');
             await script({ github, context});
diff --git a/.github/workflows/cron-pr-check-broken-links.yml b/.github/workflows/cron-pr-check-broken-links.yml
diff --git a/.github/workflows/cron-reminder-issue-no-pr.yml b/.github/workflows/cron-reminder-issue-no-pr.yml
@@ -35,4 +35,4 @@ jobs:
           REPO: ${{ github.repository }}
           DAYS: 7
           DRY_RUN: ${{ inputs.dry_run || 'false' }}
-        run: bash .github/scripts/bot-issue-reminder-no-pr.sh
+        run: bash .github/scripts/cron-reminder-issue-no-pr.sh
diff --git a/.github/workflows/cron-reminder-pr-inactive.yml b/.github/workflows/cron-reminder-pr-inactive.yml
@@ -37,5 +37,5 @@ jobs:
         uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3
         with:
           script: |
-            const script = require('./.github/scripts/pr_inactivity_reminder.js')
+            const script = require('./.github/scripts/cron-reminder-pr-inactive.js')
             await script({ github, context });
diff --git a/.github/workflows/pr-check-primary-codeql.yml b/.github/workflows/pr-check-primary-codeql.yml
@@ -42,7 +42,7 @@ jobs:
                   egress-policy: audit
 
             - name: Initialize CodeQL
-              uses: github/codeql-action/init@c10b8064de6f491fea524254123dbe5e09572f13 # v4.3.5
+              uses: github/codeql-action/init@95e58e9a2cdfd71adc6e0353d5c52f41a045d225 # v4.3.5
               with:
                   languages: ${{ matrix.language }}
                   build-mode: ${{ matrix.build-mode }}
@@ -66,6 +66,6 @@ jobs:
               run: uv sync --all-extras --dev
 
             - name: Perform CodeQL Analysis
-              uses: github/codeql-action/analyze@c10b8064de6f491fea524254123dbe5e09572f13 # v4.3.5
+              uses: github/codeql-action/analyze@95e58e9a2cdfd71adc6e0353d5c52f41a045d225 # v4.3.5
               with:
                   category: "/language:${{matrix.language}}"
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -9,13 +9,10 @@ permissions:
   contents: read
 
 jobs:
-  build-and-publish:
+  build:
+    name: Build distributions
     runs-on: hl-sdk-py-lin-md
-    environment:
-      name: pypi
-      url: https://pypi.org/p/hiero-sdk-python
-    permissions:
-      id-token: write
+
     steps:
       - name: Harden the runner (Audit all outbound calls)
         uses: step-security/harden-runner@6c3c2f2c1c457b00c10c4848d6f5491db3b629df # v2.18.0
@@ -42,5 +39,64 @@ jobs:
       - name: Build wheel and sdist
         run: python -m build
 
+      - name: Upload distributions
+        uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
+        with:
+          name: dist
+          path: dist/*
+          if-no-files-found: error
+
+  publish-and-sign:
+    name: Publish and sign release artifacts
+    needs: build
+    concurrency:
+      group: ${{ github.workflow }}-${{ github.ref }}
+      cancel-in-progress: false
+    runs-on: hl-sdk-py-lin-md
+    environment:
+      name: pypi
+      url: https://pypi.org/p/hiero-sdk-python
+    permissions:
+      contents: write
+      id-token: write
+
+    steps:
+      - name: Harden the runner (Audit all outbound calls)
+        uses: step-security/harden-runner@f808768d1510423e83855289c910610ca9b43176 # v2.17.0
+        with:
+          egress-policy: audit
+
+      - name: Download distributions
+        uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
+        with:
+          name: dist
+          path: dist
+
+      - name: Sign release distributions with Sigstore
+        uses: sigstore/gh-action-sigstore-python@04cffa1d795717b140764e8b640de88853c92acc # v3.3.0
+        with:
+          inputs: |
+            dist/*.whl
+            dist/*.tar.gz
+          verify: true
+          verify-cert-identity: https://github.com/${{ github.repository }}/.github/workflows/publish.yml@refs/tags/${{ github.ref_name }}
+          verify-oidc-issuer: https://token.actions.githubusercontent.com
+
       - name: Publish to PyPI
         uses: pypa/gh-action-pypi-publish@cef221092ed1bacb1cc03d23a2d87d1d172e277b # release/v1
+        with:
+          skip-existing: true
+
+      - name: Upload signed assets to GitHub Release
+        uses: softprops/action-gh-release@153bb8e04406b158c6c84fc1615b65b24149a1fe # v2.6.1
+        with:
+          body: |
+            ## Important notes
+            - See https://github.com/hiero-ledger/hiero-sdk-python/milestones for the pull requests included in this milestone.
+            - This release includes auto-generated release notes.
+          files: |
+            dist/*.whl
+            dist/*.tar.gz
+            dist/*.sigstore.json
+          fail_on_unmatched_files: true
+          generate_release_notes: true
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -106,7 +106,7 @@ We welcome blog posts! Whether you're sharing a tutorial, case study, or your ex
 | [Rebasing](https://github.com/hiero-ledger/sdk-collaboration-hub/blob/main/guides/issue-progression/for-developers/rebasing.md) | Keeping branch updated |
 | [Merge Conflicts](https://github.com/hiero-ledger/sdk-collaboration-hub/blob/main/guides/issue-progression/for-developers/merge_conflicts.md) | Resolving conflicts |
 | [Types](docs/sdk_developers/types.md) | Python type hints |
-| [Linting](docs/sdk_developers/linting.md) | Code quality tools |
+| [Linting](docs/sdk_developers/ruff.md) | Code quality tools |
 
 ---
 
diff --git a/README.md b/README.md
@@ -72,7 +72,7 @@ print(f"Balance: {balance.hbars} HBAR")
 - **[Rebasing Guide](https://github.com/hiero-ledger/sdk-collaboration-hub/blob/main/guides/issue-progression/for-developers/rebasing.md)** - Keep your branch up-to-date
 - **[Merge Conflicts Guide](https://github.com/hiero-ledger/sdk-collaboration-hub/blob/main/guides/issue-progression/for-developers/merge_conflicts.md)** - Resolve conflicts
 - **[Typing Guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/types.md)** - Python type hints
-- **[Linting Guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/linting.md)** - Code quality tools
+- **[Linting Guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/ruff.md)** - Code quality tools
 
 ### Hedera Network Resources
 
diff --git a/RELEASE.md b/RELEASE.md
@@ -19,22 +19,23 @@ MAJOR.MINOR.PATCH
 1. **Update the Version**
    Decide whether the changes are major, minor, or patch increments.
 
-2. **Update the Changelog**
-   Move your entries from the **[Unreleased]** section in `CHANGELOG.md` to a new version heading with today’s date (e.g., `## [0.2.0] - 2025-02-20`).
-
-3. **Create a Release Branch**
-   - `release-v0.2.0` or similar (e.g., `release-v0.2.0-beta.1` for beta versions).
-
-4. **Run Tests**
+2. **Run Tests**
    - Ensure all tests pass locally (run `pytest`).
    - Confirm CI passes (integration tests, etc.).
 
-5. **Merge into `main`**
-   - Create a Pull Request from `release-vX.X.X` into `main`.
-   - Wait for code review, ensure everything is green.
+3. **Tag the Release**
+   Once the release changes are merged, create and push a git tag that matches the publish workflow trigger (`v*.*.*`):
 
-6. **Tag the Release**
-   Once merged, create a git tag with the new version:
    ```bash
    git tag -a v0.2.0 -m "Release 0.2.0"
    git push origin v0.2.0
+   ```
+
+4. **Monitor the Publish Workflow**
+   - The `.github/workflows/publish.yml` workflow runs automatically when the tag is pushed.
+   - The workflow builds the source distribution and wheel, generates protobufs before packaging, signs the release artifacts with Sigstore, publishes the package to PyPI, and creates or updates the GitHub release.
+
+5. **Verify Published Artifacts**
+   - Confirm the new version is available on PyPI.
+   - Confirm the GitHub release contains the wheel, source distribution, and matching `.sigstore.json` bundles.
+   - If release provenance needs to be audited, use the Sigstore verification materials attached to the GitHub release.
diff --git a/docs/sdk_developers/ruff.md b/docs/sdk_developers/ruff.md
@@ -100,6 +100,33 @@ uv run ruff check . && uv run ruff format --check .
 }
 ```
 
+
+## 🛠️ Handling Linting Issues
+
+### Manual vs. Automatic Fixes
+
+Ruff is smart, but it won't change your code if it might break logic.
+
+- **Auto-Fixed:** Unused imports, unsorted imports (Isort-style), and basic whitespace.
+
+- **Manual Action Required:** Complex issues like unused function arguments (`ARG001`), overly complex logic (`C901`), or missing docstrings. You must refactor these yourself based on the terminal output.
+
+
+### Ignoring Rules (Suppressing Warnings)
+
+Sometimes, a linter rule conflicts with a specific technical requirement. You can tell Ruff to ignore a line using the `# noqa` comment followed by the error code.
+
+```python
+# Ignore a specific error on a line
+import unused_module  # noqa: F401
+
+# Ignore multiple errors on a line
+x = 1 # noqa: E701, F841
+```
+Each error has a code. You can look up the full details of any code in the [Ruff Documentation](https://docs.astral.sh/ruff/rules/).
+
+> **Global Ignore:** To disable linting for an entire file (e.g., an auto-generated file), add `# ruff: noqa` to the very top
+
 ## 📝 Example Output
 **When issues are found:**
 
diff --git a/docs/sdk_developers/setup.md b/docs/sdk_developers/setup.md
@@ -8,7 +8,9 @@ This guide walks you through setting up your development environment for contrib
 - [Installation](#installation)
   - [Installing from PyPI](#installing-from-pypi)
   - [Installing from Source](#installing-from-source)
-  - [Local Editable Installation](#local-editable-installation)
+- [Install Dependencies](#install-dependencies)
+- [Installing Optional Dependencies](#installing-optional-dependencies)
+- [Pre-Commit Tool Setup](#pre-commit-tool-setup)
 - [Generate Protocol Buffers](#generate-protocol-buffers)
 - [Environment Setup](#environment-setup)
 - [Setup Checklist](#examples)
@@ -178,6 +180,9 @@ uv sync --dev --all-extras
 
 To maintain high code quality and security, this repository uses `re-commit` hooks. These hooks automatically run checks (like `Ruff` for linting and `Gitleaks` for security) every time you attempt to commit code.
 
+### Installation
+---
+
 **Option 1: Using `uv` (Recommended)**
 
 `uv` is recommended because it manages pre-commit within your project’s locked environment, ensuring your local linting matches the CI exactly.
@@ -210,6 +215,20 @@ Once installed, `git commit` will automatically trigger the checks.
 - If they **pass**: Your commit is created normally.
 - If they **fail**: The hooks will often fix the files for you (e.g., `Ruff` reformatting). Simply `git add` the changed files and commit again.
 
+
+### Manual Execution
+---
+To run the hooks manually at any time:
+
+```
+# Run against only changed files
+uv run pre-commit run
+
+# Run against every file in the repository
+uv run pre-commit run --all-files
+```
+
+
 ## Generate Protocol Buffers
 
 The SDK uses protocol buffers to communicate with the Hedera network. Generate the Python code from the protobuf definitions:
diff --git a/docs/sdk_developers/training/network_and_client.md b/docs/sdk_developers/training/network_and_client.md
@@ -373,12 +373,10 @@ The Network and Client are separate but interdependent:
 2. **Client provides WHO and HOW**: The Client specifies who you are (operator credentials) and manages the actual communication
 3. **Together they enable communication**: The combination allows your application to securely interact with the Hedera blockchain
 
-## -### Example: Complete Setup
-
--```python
-+### Example: Complete Setup
+### Example: Complete Setup
 
 ```python
+
 from hiero_sdk_python.client.network import Network
 from hiero_sdk_python.client.client import Client
 from hiero_sdk_python.account.account_id import AccountId
diff --git a/pyproject.toml b/pyproject.toml
@@ -147,3 +147,16 @@ skip-magic-trailing-comma = false
 
 [tool.ruff.lint.pydocstyle]
 convention = "google"
+
+[tool.lychee]
+exclude = [
+    "github.com/owner/repo",
+    "github.com/YOUR_",
+    "testnet.mirrornode.hedera.com/api/v1/transactions/0.0.123",
+    "localhost",
+    "github.com/user-attachments/assets/",
+]
+
+timeout = 20
+retry_wait_time = 2
+max_retries = 3
