fix: address reviewer feedback on concurrency, dead code, and bot skip

- Remove MAX_ASSIGNEES from constants.js and reviewers-assignee-index.js;
  it was dead code since nothing reads it after the cap was removed
- Unify the concurrency group to reviewer-assignee-{PR} for all event
  types so an add and remove for the same PR cannot race
- Skip the job entirely when the actor is a bot (contains '[bot]') to
  avoid triggering on dependabot or other automated review requests

Signed-off-by: Mounil Kanakhara <mounilkankhara@gmail.com>

Author: Mounil2005

.github/scripts/shared/helpers/constants.js

@@ -7,6 +7,5 @@
  */
 
 module.exports = {
-  MAX_ASSIGNEES: 2,
   BOT_NAME_ASSIGNEES: 'reviewers-assignee',
 };

.github/scripts/shared/helpers/reviewers-assignee-index.js

@@ -10,6 +10,5 @@ const constants = require('./constants.js');
 
 module.exports = {
   createLogger,
-  MAX_ASSIGNEES: constants.MAX_ASSIGNEES,
   BOT_NAME_ASSIGNEES: constants.BOT_NAME_ASSIGNEES,
 };

.github/workflows/on-review.yml

@@ -23,14 +23,10 @@ jobs:
   add-reviewers-as-assignees:
     name: Add Reviewers as Assignees
     runs-on: hl-sdk-py-lin-md
+    if: "!contains(github.actor, '[bot]')"
 
     concurrency:
-      group: >-
-        ${{
-          github.event_name == 'pull_request_review'
-          && format('reviewer-removal-{0}-{1}', github.event.pull_request.number, github.event.review.user.login)
-          || format('reviewer-assignee-{0}', github.event.pull_request.number || inputs.pr_number || github.run_id)
-        }}
+      group: reviewer-assignee-${{ github.event.pull_request.number || inputs.pr_number || github.run_id }}
       cancel-in-progress: false
 
     steps: