fixed magicMock

Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>

Author: tech0priyanshu

src/hiero_sdk_python/client/client.py

@@ -59,7 +59,7 @@ def __init__(self, network: Network = None) -> None:
 
         self.max_attempts: int = 10
         self.default_max_query_payment: Hbar = DEFAULT_MAX_QUERY_PAYMENT
-        self.default_max_transaction_fee: Hbar = None
+        self.default_max_transaction_fee: Hbar | None = None
 
         self._min_backoff: float = DEFAULT_MIN_BACKOFF
         self._max_backoff: float = DEFAULT_MAX_BACKOFF
@@ -293,7 +293,20 @@ def set_max_transaction_fee(
         self,
         max_transaction_fee: int | float | Decimal | Hbar,
     ) -> Client:
+        """
+        Sets the default maximum Hbar fee allowed for any transaction executed by this client.
+
+        This value is used as the transaction fee during freeze_with() if the transaction
+        itself does not have an explicit fee set. Individual transactions may override this
+        default by calling Transaction.set_max_transaction_fee().
+
+        Args:
+            max_transaction_fee (int | float | Decimal | Hbar):
+                The maximum fee that any single transaction is allowed to cost.
 
+        Returns:
+            Client: The current client instance for method chaining.
+        """
         if isinstance(max_transaction_fee, bool) or not isinstance(
             max_transaction_fee,
             (int, float, Decimal, Hbar),

src/hiero_sdk_python/transaction/transaction.py

@@ -304,6 +304,17 @@ def freeze_with(self, client: Client):
         # For each node, set the node_account_id and build the transaction body
         # This allows the transaction to be submitted to any node in the network
 
+        # Use all nodes from client network
+        # Resolve fee priority before building bodies:
+        # 1. Explicit transaction fee (self.transaction_fee)
+        # 2. Client default_max_transaction_fee
+        # 3. Transaction class default (_default_transaction_fee)
+        if self.transaction_fee is None:
+            if client is not None and getattr(client, "default_max_transaction_fee", None) is not None:
+                self.transaction_fee = client.default_max_transaction_fee
+            else:
+                self.transaction_fee = self._default_transaction_fee
+
         if self.batch_key:
             # For Inner Transaction of batch transaction node_account_id=0.0.0
             self.node_account_id = AccountId(0, 0, 0)
@@ -323,17 +334,6 @@ def freeze_with(self, client: Client):
                 self._transaction_body_bytes[node_account_id] = self.build_transaction_body().SerializeToString()
 
         else:
-            # Use all nodes from client network
-            # Resolve fee priority before building bodies:
-            # 1. Explicit transaction fee (self.transaction_fee)
-            # 2. Client default_max_transaction_fee
-            # 3. Transaction class default (_default_transaction_fee)
-            if self.transaction_fee is None:
-                if client is not None and getattr(client, "default_max_transaction_fee", None) is not None:
-                    self.transaction_fee = client.default_max_transaction_fee
-                else:
-                    self.transaction_fee = self._default_transaction_fee
-
             for node in client.network.nodes:
                 self.node_account_id = node._account_id
                 self._transaction_body_bytes[node._account_id] = self.build_transaction_body().SerializeToString()
@@ -796,6 +796,7 @@ def from_bytes(transaction_bytes: bytes):
 
     def set_max_transaction_fee(self, max_transaction_fee):
         # Accept int, float, Decimal, or Hbar (but not bool)
+        self._require_not_frozen()
 
         if isinstance(max_transaction_fee, bool) or not isinstance(max_transaction_fee, (int, float, Decimal, Hbar)):
             raise TypeError(

tests/unit/fee_estimate_query_test.py

@@ -32,6 +32,7 @@ def mock_client():
     client.mirror_network = "https://testnet.mirrornode.hedera.com"
     client.max_retries = 3
 
+    client.default_max_transaction_fee = Hbar(2)
     client.generate_transaction_id.return_value = TransactionId.generate(AccountId(0, 0, 1001))
     client.operator_account_id._to_proto.return_value = AccountId(0, 0, 1)._to_proto()
 

tests/unit/file_append_transaction_test.py

@@ -95,6 +95,7 @@ def test_freeze_with_generates_transaction_ids():
 
     # Mock client and transaction_id
     mock_client = MagicMock()
+    mock_client.default_max_transaction_fee = Hbar(1)
     mock_transaction_id = TransactionId(account_id=MagicMock(), valid_start=Timestamp(0, 1))
     file_tx.transaction_id = mock_transaction_id
 
@@ -135,6 +136,7 @@ def test_multi_chunk_execution():
 
     # Mock client and responses
     mock_client = MagicMock()
+    mock_client.default_max_transaction_fee = Hbar(1)
     mock_receipt = MagicMock(spec=TransactionReceipt)
     mock_receipt.status = ResponseCode.SUCCESS
 

tests/unit/transaction_freeze_and_bytes_test.py

@@ -66,11 +66,11 @@ def test_freeze_with_valid_parameters():
 @pytest.mark.parametrize(
     "valid_amount,expected",
     [
-        (1, Hbar(1)),
-        (0.1, Hbar(0.1)),
-        (Decimal("0.1"), Hbar(Decimal("0.1"))),
-        (Hbar(1), Hbar(1)),
-        (Hbar(0), Hbar(0)),
+        (1, 1_00_000_000),
+        (0.1, 10_000_000),
+        (Decimal("0.1"), 10_000_000),
+        (Hbar(1), 1_00_000_000),
+        (Hbar(0), 0.00000000),
     ],
 )
 def test_set_max_transaction_fee_valid_param(valid_amount, expected):
@@ -735,7 +735,7 @@ def test_fee_resolution_transaction_precedence(mock_client):
 
     tx.freeze_with(mock_client)
 
-    assert tx.transaction_fee == Hbar(10)
+    assert tx.transaction_fee == 10_00_000_000
 
 
 def test_fee_resolution_client_default_used_when_transaction_missing(mock_client):
@@ -747,7 +747,7 @@ def test_fee_resolution_client_default_used_when_transaction_missing(mock_client
 
     tx.freeze_with(mock_client)
 
-    assert tx.transaction_fee == Hbar(7)
+    assert tx.transaction_fee == 7_00_000_000
 
 
 def test_fee_resolution_falls_back_to_transaction_default(mock_client):