feat: implement createTopic functionality and related parameters in TCK handlers

MonaaEid · MonaaEid · commit 86e567cae783 · 2026-05-01T17:19:44.000+03:00
Signed-off-by: MonaaEid &lt;monaa_eid@hotmail.com&gt;
diff --git a/tck/handlers/__init__.py b/tck/handlers/__init__.py
@@ -1,17 +1,19 @@
 """TCK handlers - auto-import all handler modules."""
 
 # Import registry functions first to make them available
+# Import all handler modules to trigger @rpc_method decorators
+from . import (
+    account,
+    key,
+    sdk,  # setup, reset
+    topic,
+)
 from .registry import (
-    get_handler,
     get_all_handlers,
+    get_handler,
     safe_dispatch,
 )
 
-# Import all handler modules to trigger @rpc_method decorators
-from . import sdk  # setup, reset
-from . import key
-from . import account
-from . import topic
 
 __all__ = [
     "get_handler",
diff --git a/tck/handlers/key.py b/tck/handlers/key.py
@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 from hiero_sdk_python.crypto.key_list import KeyList
 from hiero_sdk_python.crypto.private_key import PrivateKey
 from hiero_sdk_python.crypto.public_key import PublicKey
@@ -28,9 +30,7 @@ def generate_key(params: KeyGenerationParams) -> KeyGenerationResponse:
         )
 
     if params.threshold is not None and params.type != KeyType.THRESHOLD_KEY:
-        raise JsonRpcError.invalid_params_error(
-            "invalid parameters: threshold is only allowed for thresholdKey types."
-        )
+        raise JsonRpcError.invalid_params_error("invalid parameters: threshold is only allowed for thresholdKey types.")
 
     if params.type == KeyType.THRESHOLD_KEY and params.threshold is None:
         raise JsonRpcError.invalid_params_error(
@@ -67,9 +67,7 @@ def _handle_private_key(params: KeyGenerationParams, response: KeyGenerationResp
     return private_key_string
 
 
-def _handle_public_key(
-    params: KeyGenerationParams, response: KeyGenerationResponse, is_list: bool
-) -> str:
+def _handle_public_key(params: KeyGenerationParams, response: KeyGenerationResponse, is_list: bool) -> str:
     if params.fromKey:
         return _format_generated_public_key(PrivateKey.from_string(params.fromKey).public_key())
 
diff --git a/tck/handlers/topic.py b/tck/handlers/topic.py
@@ -25,9 +25,7 @@ def _build_custom_fee(custom_fee_params: CreateTopicCustomFeeParams) -> CustomFi
         raise ValueError("feeCollectorAccountId cannot be empty")
 
     if custom_fee_params.feeCollectorAccountId is not None:
-        custom_fee.set_fee_collector_account_id(
-            AccountId.from_string(custom_fee_params.feeCollectorAccountId)
-        )
+        custom_fee.set_fee_collector_account_id(AccountId.from_string(custom_fee_params.feeCollectorAccountId))
 
     if custom_fee_params.feeCollectorsExempt:
         custom_fee.set_all_collectors_are_exempt(custom_fee_params.feeCollectorsExempt)
@@ -37,9 +35,7 @@ def _build_custom_fee(custom_fee_params: CreateTopicCustomFeeParams) -> CustomFi
             custom_fee.amount = custom_fee_params.fixedFee.amount
 
         if custom_fee_params.fixedFee.denominatingTokenId:
-            custom_fee.set_denominating_token_id(
-                TokenId.from_string(custom_fee_params.fixedFee.denominatingTokenId)
-            )
+            custom_fee.set_denominating_token_id(TokenId.from_string(custom_fee_params.fixedFee.denominatingTokenId))
 
     return custom_fee
 
@@ -60,22 +56,16 @@ def _build_create_topic_transaction(params: CreateTopicParams) -> TopicCreateTra
         transaction.set_auto_renew_period(params.autoRenewPeriod)
 
     if params.autoRenewAccountId:
-        transaction.set_auto_renew_account(
-            AccountId.from_string(params.autoRenewAccountId)
-        )
+        transaction.set_auto_renew_account(AccountId.from_string(params.autoRenewAccountId))
 
     if params.feeScheduleKey:
         transaction.set_fee_schedule_key(get_key_from_string(params.feeScheduleKey))
 
     if params.feeExemptKeys:
-        transaction.set_fee_exempt_keys(
-            [get_key_from_string(key) for key in params.feeExemptKeys]
-        )
+        transaction.set_fee_exempt_keys([get_key_from_string(key) for key in params.feeExemptKeys])
 
     if params.customFees is not None:
-        transaction.set_custom_fees(
-            [_build_custom_fee(custom_fee_params) for custom_fee_params in params.customFees]
-        )
+        transaction.set_custom_fees([_build_custom_fee(custom_fee_params) for custom_fee_params in params.customFees])
 
     return transaction
 
@@ -96,6 +86,7 @@ def _get_auto_renew_account_state(client, auto_renew_account_id: str | None) ->
             return "deleted"
         return "unknown"
 
+
 @rpc_method("createTopic")
 def create_topic(params: CreateTopicParams) -> CreateTopicResponse:
     client = get_client(params.sessionId)
@@ -119,14 +110,9 @@ def create_topic(params: CreateTopicParams) -> CreateTopicResponse:
         receipt: TransactionReceipt = response.get_receipt(client, validate_status=True)
     except (PrecheckError, ReceiptStatusError) as exc:
         status = ResponseCode(exc.status).name
-        if (
-            params.autoRenewAccountId
-            and status == "INVALID_SIGNATURE"
-            and auto_renew_account_state != "deleted"
-        ):
-            raise JsonRpcError.hiero_error({"status": "INVALID_AUTORENEW_ACCOUNT"})
-        raise
-
+        if params.autoRenewAccountId and status == "INVALID_SIGNATURE" and auto_renew_account_state != "deleted":
+            raise JsonRpcError.hiero_error({"status": "INVALID_AUTORENEW_ACCOUNT"}) from exc
+        raise JsonRpcError.hiero_error({"status": status}) from exc
     topic_id = ""
     if receipt.status == ResponseCode.SUCCESS and receipt.topic_id is not None:
         topic_id = str(receipt.topic_id)
diff --git a/tck/param/common.py b/tck/param/common.py
@@ -34,13 +34,9 @@ def apply_common_params(self, transaction: Transaction, client: Client) -> None:
         """Apply commonTransactionParams to a given transaction."""
         if self.transactionId is not None:
             try:
-                transaction.set_transaction_id(
-                    TransactionId.from_string(self.transactionId)
-                )
+                transaction.set_transaction_id(TransactionId.from_string(self.transactionId))
             except Exception:
-                transaction.set_transaction_id(
-                    TransactionId.generate(AccountId.from_string(self.transactionId))
-                )
+                transaction.set_transaction_id(TransactionId.generate(AccountId.from_string(self.transactionId)))
 
         if self.maxTransactionFee is not None:
             transaction.transaction_fee = int(self.maxTransactionFee)
diff --git a/tck/param/topic.py b/tck/param/topic.py
@@ -16,11 +16,12 @@
 @dataclass
 class CreateTopicFixedFeeParams:
     """Parameters for a fixed fee custom fee in topic creation."""
+
     amount: int | None = None
     denominatingTokenId: str | None = None
 
     @classmethod
-    def parse_json_params(cls, params: dict) -> "CreateTopicFixedFeeParams":
+    def parse_json_params(cls, params: dict) -> CreateTopicFixedFeeParams:
         return cls(
             amount=to_int(params.get("amount")),
             denominatingTokenId=non_empty_string_or_none(params.get("denominatingTokenId")),
@@ -30,12 +31,13 @@ def parse_json_params(cls, params: dict) -> "CreateTopicFixedFeeParams":
 @dataclass
 class CreateTopicCustomFeeParams:
     """Parameters for a custom fee in topic creation."""
+
     feeCollectorAccountId: str | None = None
     feeCollectorsExempt: bool | None = None
     fixedFee: CreateTopicFixedFeeParams | None = None
 
     @classmethod
-    def parse_json_params(cls, params: dict) -> "CreateTopicCustomFeeParams":
+    def parse_json_params(cls, params: dict) -> CreateTopicCustomFeeParams:
         fixed_fee = params.get("fixedFee")
 
         fee_collector_account_id = params.get("feeCollectorAccountId")
@@ -45,17 +47,14 @@ def parse_json_params(cls, params: dict) -> "CreateTopicCustomFeeParams":
         return cls(
             feeCollectorAccountId=fee_collector_account_id,
             feeCollectorsExempt=to_bool(params.get("feeCollectorsExempt")),
-            fixedFee=(
-                CreateTopicFixedFeeParams.parse_json_params(fixed_fee)
-                if isinstance(fixed_fee, dict)
-                else None
-            ),
+            fixedFee=(CreateTopicFixedFeeParams.parse_json_params(fixed_fee) if isinstance(fixed_fee, dict) else None),
         )
 
 
 @dataclass
 class CreateTopicParams(BaseTransactionParams):
     """Parameters for creating a topic. Extends BaseTransactionParams to include common transaction parameters."""
+   
     memo: str | None = None
     adminKey: str | None = None
     submitKey: str | None = None
@@ -66,7 +65,7 @@ class CreateTopicParams(BaseTransactionParams):
     customFees: list[CreateTopicCustomFeeParams] | None = None
 
     @classmethod
-    def parse_json_params(cls, params: dict) -> "CreateTopicParams":
+    def parse_json_params(cls, params: dict) -> CreateTopicParams:
         fee_exempt_keys = params.get("feeExemptKeys")
         if fee_exempt_keys is not None and not isinstance(fee_exempt_keys, list):
             raise ValueError("feeExemptKeys must be a list")
@@ -85,10 +84,7 @@ def parse_json_params(cls, params: dict) -> "CreateTopicParams":
             feeScheduleKey=non_empty_string_or_none(params.get("feeScheduleKey")),
             feeExemptKeys=non_empty_string_list(fee_exempt_keys),
             customFees=(
-                [
-                    CreateTopicCustomFeeParams.parse_json_params(custom_fee)
-                    for custom_fee in custom_fees
-                ]
+                [CreateTopicCustomFeeParams.parse_json_params(custom_fee) for custom_fee in custom_fees]
                 if custom_fees is not None
                 else None
             ),
diff --git a/tck/util/param_utils.py b/tck/util/param_utils.py
@@ -1,3 +1,6 @@
+from __future__ import annotations
+
+
 def parse_session_id(params: dict) -> str:
     """Parse sessionId from the json rpc params."""
     session_id = params.get("sessionId")
@@ -16,9 +19,7 @@ def parse_common_transaction_params(params: dict):
     if common_params is None:
         return None
 
-    return CommonTransactionParams.parse_json_params(
-        params.get("commonTransactionParams")
-    )
+    return CommonTransactionParams.parse_json_params(params.get("commonTransactionParams"))
 
 
 def to_int(value) -> int | None:
@@ -28,6 +29,7 @@ def to_int(value) -> int | None:
     except (TypeError, ValueError):
         return None
 
+
 def non_empty_string_or_none(value: str | None) -> str | None:
     """Trim string values; convert blank strings to None."""
     if not isinstance(value, str):
@@ -49,6 +51,7 @@ def non_empty_string_list(values) -> list[str] | None:
 
     return cleaned_values
 
+
 def to_bool(value) -> bool | None:
     """Helper to convert value to bool."""
     if isinstance(value, str):
diff --git a/tests/tck/topic_handlers_test.py b/tests/tck/topic_handlers_test.py
@@ -1,4 +1,5 @@
 """Focused createTopic tests for TCK handlers."""
+
 from __future__ import annotations
 
 from unittest.mock import MagicMock, patch
@@ -27,7 +28,18 @@
 
 
 def _params(**overrides):
-    base = dict(sessionId="test", memo=None, adminKey=None, submitKey=None, autoRenewPeriod=None, autoRenewAccountId=None, feeScheduleKey=None, feeExemptKeys=None, customFees=None, commonTransactionParams=None)
+    base = dict(
+        sessionId="test",
+        memo=None,
+        adminKey=None,
+        submitKey=None,
+        autoRenewPeriod=None,
+        autoRenewAccountId=None,
+        feeScheduleKey=None,
+        feeExemptKeys=None,
+        customFees=None,
+        commonTransactionParams=None,
+    )
     base.update(overrides)
     return CreateTopicParams(**base)
 
@@ -55,17 +67,40 @@ def test_parse_json_and_validation():
 
 
 def test_build_custom_fee_and_reject_empty_collector():
-    fee = _build_custom_fee(CreateTopicCustomFeeParams(feeCollectorAccountId="0.0.98", feeCollectorsExempt=True, fixedFee=CreateTopicFixedFeeParams(amount=100, denominatingTokenId="0.0.500")))
+    fee = _build_custom_fee(
+        CreateTopicCustomFeeParams(
+            feeCollectorAccountId="0.0.98",
+            feeCollectorsExempt=True,
+            fixedFee=CreateTopicFixedFeeParams(amount=100, denominatingTokenId="0.0.500"),
+        )
+    )
     assert fee.amount == 100
     assert fee.fee_collector_account_id == AccountId(0, 0, 98)
     assert fee.denominating_token_id == TokenId(0, 0, 500)
     assert fee.all_collectors_are_exempt is True
     with pytest.raises(ValueError, match="feeCollectorAccountId cannot be empty"):
-        _build_custom_fee(CreateTopicCustomFeeParams(feeCollectorAccountId="", fixedFee=CreateTopicFixedFeeParams(amount=1)))
+        _build_custom_fee(
+            CreateTopicCustomFeeParams(feeCollectorAccountId="", fixedFee=CreateTopicFixedFeeParams(amount=1))
+            )
 
 
 def test_build_transaction_core_fields():
-    tx = _build_create_topic_transaction(_params(memo="m", adminKey=TEST_KEY, submitKey=TEST_KEY, autoRenewPeriod=7776000, autoRenewAccountId="0.0.98", feeScheduleKey=TEST_KEY, feeExemptKeys=[TEST_KEY], customFees=[CreateTopicCustomFeeParams(feeCollectorAccountId="0.0.98", fixedFee=CreateTopicFixedFeeParams(amount=100))]))
+    tx = _build_create_topic_transaction(
+        _params(
+            memo="m",
+            adminKey=TEST_KEY,
+            submitKey=TEST_KEY,
+            autoRenewPeriod=7776000,
+            autoRenewAccountId="0.0.98",
+            feeScheduleKey=TEST_KEY,
+            feeExemptKeys=[TEST_KEY],
+            customFees=[
+                CreateTopicCustomFeeParams(
+                    feeCollectorAccountId="0.0.98", fixedFee=CreateTopicFixedFeeParams(amount=100)
+                )
+            ],
+        )
+    )
     assert tx.memo == "m"
     assert getattr(tx.auto_renew_period, "seconds", tx.auto_renew_period) == 7776000
     assert len(tx.custom_fees) == 1
@@ -78,7 +113,9 @@ def test_build_transaction_core_fields():
         (None, "0.0.98", "exists"),
         (PrecheckError(status=ResponseCode.INVALID_ACCOUNT_ID), "0.0.999", "missing"),
         (
-            ReceiptStatusError(status=ResponseCode.ACCOUNT_DELETED, transaction_id=None, transaction_receipt=MagicMock()),
+            ReceiptStatusError(
+                status=ResponseCode.ACCOUNT_DELETED, transaction_id=None, transaction_receipt=MagicMock()
+            ),
             "0.0.98",
             "deleted",
         ),
@@ -114,6 +151,23 @@ def test_create_topic_rejects_missing_auto_renew(_, mock_get_client, client_mock
 def test_create_topic_with_all_parameters(_, mock_get_client, client_mock):
     mock_get_client.return_value = client_mock
     with patch.object(TopicCreateTransaction, "execute", return_value=_success_response(2000)):
-        result = create_topic(_params(memo="Full", adminKey=TEST_KEY, submitKey=TEST_KEY, autoRenewPeriod=7776000, autoRenewAccountId="0.0.98", feeScheduleKey=TEST_KEY, feeExemptKeys=[TEST_KEY], customFees=[CreateTopicCustomFeeParams(feeCollectorAccountId="0.0.98", feeCollectorsExempt=True, fixedFee=CreateTopicFixedFeeParams(amount=500, denominatingTokenId="0.0.500"))]))
+        result = create_topic(
+            _params(
+                memo="Full",
+                adminKey=TEST_KEY,
+                submitKey=TEST_KEY,
+                autoRenewPeriod=7776000,
+                autoRenewAccountId="0.0.98",
+                feeScheduleKey=TEST_KEY,
+                feeExemptKeys=[TEST_KEY],
+                customFees=[
+                    CreateTopicCustomFeeParams(
+                        feeCollectorAccountId="0.0.98",
+                        feeCollectorsExempt=True,
+                        fixedFee=CreateTopicFixedFeeParams(amount=500, denominatingTokenId="0.0.500"),
+                    )
+                ],
+            )
+        )
     assert result.status == "SUCCESS"
     assert result.topicId == "0.0.2000"
