fix: address review feedback from Gourav

1. index.js: Exit with code 1 if errors occurred during PR processing
   so that the GitHub Action workflow fails instead of hiding failures
   behind a green checkmark.
2. labels.js: Tighten ready-to-merge logic to strictly require at least
   2 core reviews (maintainer + write). Soft approvals (triage/read)
   no longer satisfy the second review requirement for merge status.
3. test-labels.js: Update tests to reflect the new strict requirement.

Signed-off-by: darshit2308 <darshit2308@gmail.com>

Author: darshit2308

.github/scripts/review-sync/helpers/labels.js

@@ -57,20 +57,20 @@ async function ensureLabel(github, owner, repo, label, dryRun) {
  * Determine the correct queue label for a PR based on approval counts.
  *
  * Phase 1 logic (4-stage pipeline):
- *   maintainerApproval >= 1 AND anyApproval >= 2  → status: ready-to-merge      (CODEOWNERS + min reviews)
+ *   maintainerApproval >= 1 AND (maintainerApproval + writeApproval) >= 2  → status: ready-to-merge      (CODEOWNERS + min core reviews)
  *   writeApproval >= 1 OR maintainerApproval >= 1 → queue:maintainers   (senior review present, needs more)
  *   anyApproval >= 1                               → queue:committers    (has any approval, needs committer)
  *   else                                           → queue:junior-committer (no approvals yet)
  *
  * Note: status: ready-to-merge requires BOTH a maintainer approval AND at least 2
- * total reviews. This prevents a single maintainer approval from marking
- * a PR as status: ready-to-merge when branch protection requires 2+ reviews.
+ * total core reviews (maintainer or write). This prevents a single maintainer approval 
+ * + a soft approval from marking a PR as ready when branch protection requires 2+ core reviews.
  *
  * @param {{ maintainerApproval: number, writeApproval: number, softApproval: number, anyApproval: number }} approvals
  * @returns {object} The correct QUEUE_LABELS entry
  */
 function determineLabel(approvals) {
-  if (approvals.maintainerApproval >= 1 && approvals.anyApproval >= 2) {
+  if (approvals.maintainerApproval >= 1 && (approvals.maintainerApproval + approvals.writeApproval) >= 2) {
     return QUEUE_LABELS.MERGE;
   }
   if (approvals.writeApproval >= 1 || approvals.maintainerApproval >= 1) {

.github/scripts/review-sync/index.js

@@ -88,4 +88,8 @@ module.exports = async ({ github, context, core }) => {
   console.log(`  Labels changed: ${changed}`);
   console.log(`  Labels already correct: ${skipped}`);
   console.log(`  Errors: ${errors}`);
+
+  if (errors > 0) {
+    process.exitCode = 1;
+  }
 };

.github/scripts/review-sync/tests/test-labels.js

@@ -54,10 +54,10 @@ const unitTests = [
     },
   },
   {
-    name: 'determineLabel: 1 maintainer + 1 soft → status: ready-to-merge (2 reviews satisfied)',
+    name: 'determineLabel: 1 maintainer + 1 soft → queue:maintainers (soft approvals do not count as core review)',
     test: () => {
       const r = determineLabel({ maintainerApproval: 1, writeApproval: 0, softApproval: 1, anyApproval: 2 });
-      return r.name === 'status: ready-to-merge';
+      return r.name === 'queue:maintainers';
     },
   },
   {