fix: address CodeRabbit review on

- Replace remaining logging.error(...) (root logger) with logger.error()
- Add exc_info=True to file_contents_query.py for traceback parity
- Strengthen tests: seed valid IDs, assert emitting logger identity (record.name == module), assert traceback is attached (record.exc_info)

Signed-off-by: iron-prog <dt915725@gmail.com>

Author: iron-prog

src/hiero_sdk_python/file/file_contents_query.py

@@ -81,7 +81,7 @@ def _make_request(self) -> query_pb2.Query:
 
             return query
         except Exception as e:
-            logger.error("Exception in _make_request: %s", e)
+            logger.error("Exception in _make_request: %s", e, exc_info=True)
             raise
 
     def _get_method(self, channel: _Channel) -> _Method:

src/hiero_sdk_python/file/file_info_query.py

@@ -78,7 +78,7 @@ def _make_request(self) -> query_pb2.Query:
 
             return query
         except Exception as e:
-            logging.error("Exception in _make_request: %s", e, exc_info=True)
+            logger.error("Exception in _make_request: %s", e, exc_info=True)
             raise
 
     def _get_method(self, channel: _Channel) -> _Method:

src/hiero_sdk_python/query/account_info_query.py

@@ -72,7 +72,7 @@ def _make_request(self):
 
             return query
         except Exception as e:
-            logging.error("Exception in _make_request: %s", e)
+            logger.error("Exception in _make_request: %s", e, exc_info=True)
             raise
 
     def _get_method(self, channel: _Channel) -> _Method:

src/hiero_sdk_python/query/token_info_query.py

@@ -74,7 +74,7 @@ def _make_request(self) -> query_pb2.Query:
 
             return query
         except Exception as e:
-            logging.error("Exception in _make_request: %s", e)
+            logger.error("Exception in _make_request: %s", e, exc_info=True)
             raise
 
     def _get_method(self, channel: _Channel) -> _Method:

src/hiero_sdk_python/query/token_nft_info_query.py

@@ -72,7 +72,7 @@ def _make_request(self) -> query_pb2.Query:
 
             return query
         except Exception as e:
-            logging.error("Exception in _make_request: %s", e, exc_info=True)
+            logger.error("Exception in _make_request: %s", e, exc_info=True)
             raise
 
     def _get_method(self, channel: _Channel) -> _Method:

src/hiero_sdk_python/query/topic_info_query.py

@@ -102,7 +102,7 @@ def _make_request(self) -> query_pb2.Query:
             return query
 
         except Exception as e:
-            logging.error("Exception in _make_request: %s", e, exc_info=True)
+            logger.error("Exception in _make_request: %s", e, exc_info=True)
             raise
 
     def _get_method(self, channel: _Channel) -> _Method:

src/hiero_sdk_python/query/transaction_get_receipt_query.py

@@ -187,7 +187,7 @@ def _make_request(self) -> query_pb2.Query:
 
             return query
         except Exception as e:
-            logging.error("Exception in _make_request: %s", e, exc_info=True)
+            logger.error("Exception in _make_request: %s", e, exc_info=True)
             raise
 
     def _get_method(self, channel: _Channel) -> _Method:

src/hiero_sdk_python/schedule/schedule_info_query.py

@@ -74,7 +74,7 @@ def _make_request(self) -> query_pb2.Query:
 
             return query
         except Exception as e:
-            logging.error("Exception in _make_request: %s", e, exc_info=True)
+            logger.error("Exception in _make_request: %s", e, exc_info=True)
             raise
 
     def _get_method(self, channel: _Channel) -> _Method:

tests/unit/query_error_logging_test.py

@@ -7,91 +7,119 @@
 import pytest
 import requests
 
+from hiero_sdk_python.account.account_id import AccountId
 from hiero_sdk_python.account.account_records_query import AccountRecordsQuery
 from hiero_sdk_python.client.network import Network
+from hiero_sdk_python.consensus.topic_id import TopicId
 from hiero_sdk_python.contract.contract_bytecode_query import ContractBytecodeQuery
 from hiero_sdk_python.contract.contract_call_query import ContractCallQuery
+from hiero_sdk_python.contract.contract_id import ContractId
 from hiero_sdk_python.contract.contract_info_query import ContractInfoQuery
 from hiero_sdk_python.file.file_contents_query import FileContentsQuery
+from hiero_sdk_python.file.file_id import FileId
 from hiero_sdk_python.file.file_info_query import FileInfoQuery
 from hiero_sdk_python.query.account_balance_query import CryptoGetAccountBalanceQuery
 from hiero_sdk_python.query.account_info_query import AccountInfoQuery
 from hiero_sdk_python.query.token_info_query import TokenInfoQuery
 from hiero_sdk_python.query.token_nft_info_query import TokenNftInfoQuery
 from hiero_sdk_python.query.topic_info_query import TopicInfoQuery
 from hiero_sdk_python.query.transaction_get_receipt_query import TransactionGetReceiptQuery
+from hiero_sdk_python.schedule.schedule_id import ScheduleId
 from hiero_sdk_python.schedule.schedule_info_query import ScheduleInfoQuery
+from hiero_sdk_python.tokens.nft_id import NftId
+from hiero_sdk_python.tokens.token_id import TokenId
+from hiero_sdk_python.transaction.transaction_id import TransactionId
 
 
 pytestmark = pytest.mark.unit
 
-QUERY_CLASSES = [
-    AccountInfoQuery,
-    FileContentsQuery,
-    TokenInfoQuery,
-    AccountRecordsQuery,
-    ContractBytecodeQuery,
-    ContractCallQuery,
-    ContractInfoQuery,
-    FileInfoQuery,
-    CryptoGetAccountBalanceQuery,
-    TokenNftInfoQuery,
-    TopicInfoQuery,
-    TransactionGetReceiptQuery,
-    ScheduleInfoQuery,
+_ACCOUNT_ID = AccountId(0, 0, 100)
+_TOKEN_ID = TokenId(0, 0, 200)
+
+QUERY_FACTORIES = [
+    (AccountInfoQuery, lambda: AccountInfoQuery(_ACCOUNT_ID), "_make_request_header"),
+    (FileContentsQuery, lambda: FileContentsQuery(FileId(0, 0, 101)), "_make_request_header"),
+    (TokenInfoQuery, lambda: TokenInfoQuery(_TOKEN_ID), "_make_request_header"),
+    (AccountRecordsQuery, lambda: AccountRecordsQuery(_ACCOUNT_ID), "_make_request_header"),
+    (
+        ContractBytecodeQuery,
+        lambda: ContractBytecodeQuery(ContractId(0, 0, 102)),
+        "_make_request_header",
+    ),
+    (ContractCallQuery, lambda: ContractCallQuery(ContractId(0, 0, 102)), "_make_request_header"),
+    (ContractInfoQuery, lambda: ContractInfoQuery(ContractId(0, 0, 102)), "_make_request_header"),
+    (FileInfoQuery, lambda: FileInfoQuery(FileId(0, 0, 101)), "_make_request_header"),
+    (
+        CryptoGetAccountBalanceQuery,
+        lambda: CryptoGetAccountBalanceQuery(_ACCOUNT_ID),
+        "_make_request_header",
+    ),
+    (TokenNftInfoQuery, lambda: TokenNftInfoQuery(NftId(_TOKEN_ID, 1)), "_make_request_header"),
+    (TopicInfoQuery, lambda: TopicInfoQuery(TopicId(0, 0, 103)), "_make_request_header"),
+    (
+        TransactionGetReceiptQuery,
+        lambda: TransactionGetReceiptQuery(TransactionId(_ACCOUNT_ID)),
+        "transaction_id._to_proto",
+    ),
+    (ScheduleInfoQuery, lambda: ScheduleInfoQuery(ScheduleId(0, 0, 104)), "_make_request_header"),
 ]
 
+_IDS = [cls.__name__ for cls, _, _ in QUERY_FACTORIES]
 
-@pytest.mark.parametrize("query_cls", QUERY_CLASSES, ids=[c.__name__ for c in QUERY_CLASSES])
-def test_make_request_source_has_no_print_or_traceback_dump(query_cls):
-    """
-    Static regression check preventing accidental reintroduction of
-    print() or traceback.print_exc() in _make_request().
-    """
+
+@pytest.mark.parametrize("query_cls,factory,patch_target", QUERY_FACTORIES, ids=_IDS)
+def test_make_request_source_has_no_print_or_traceback_dump(query_cls, factory, patch_target):
+    """Ensure _make_request does not use print() or traceback.print_exc()."""
     source = inspect.getsource(query_cls._make_request)
     assert "print(" not in source, f"{query_cls.__name__}._make_request still calls print()"
     assert "traceback.print_exc()" not in source, (
         f"{query_cls.__name__}._make_request still calls traceback.print_exc()"
     )
 
 
-@pytest.mark.parametrize("query_cls", QUERY_CLASSES, ids=[c.__name__ for c in QUERY_CLASSES])
-def test_make_request_logs_exception_via_logging_module(query_cls, caplog):
-    """
-    Verify that _make_request routes exceptions through the logging module
-    instead of printing directly to stdout or stderr.
+@pytest.mark.parametrize("query_cls,factory,patch_target", QUERY_FACTORIES, ids=_IDS)
+def test_make_request_logs_exception_via_module_logger(query_cls, factory, patch_target, caplog):
+    """Ensure _make_request logs exceptions with the module logger and exc_info."""
+    query = factory()
 
-    The request header is mocked to raise an exception so the error logging
-    path can be exercised consistently across query implementations.
-    """
-    query = query_cls()
+    # Patch either the query helper or an inline header builder.
+    if "." in patch_target:
+        attr_name, method_name = patch_target.split(".")
+        patch_obj = type(getattr(query, attr_name))
+        patch_ctx = patch.object(patch_obj, method_name, side_effect=ValueError("boom"))
+    else:
+        patch_ctx = patch.object(query_cls, patch_target, side_effect=ValueError("boom"))
 
-    # Some tests disable the SDK's root logger via the shared client fixture.
-    # Override the logger level here so caplog can capture ERROR records.
+    # Override the parent logger level so ERROR logs are captured.
     with (
-        patch.object(query_cls, "_make_request_header", side_effect=ValueError("boom")),
+        patch_ctx,
         caplog.at_level(logging.ERROR, logger="hiero_sdk_python"),
         caplog.at_level(logging.ERROR),
         pytest.raises(ValueError),
     ):
         query._make_request()
 
-    assert any(
-        record.levelno == logging.ERROR and "Exception in _make_request" in record.message for record in caplog.records
-    ), f"No ERROR-level 'Exception in _make_request' log record captured for {query_cls.__name__}"
+    matching = [
+        record
+        for record in caplog.records
+        if record.levelno == logging.ERROR and "Exception in _make_request" in record.message
+    ]
+    assert matching, f"No ERROR-level 'Exception in _make_request' log record captured for {query_cls.__name__}"
+
+    record = matching[0]
+    assert record.name == query_cls.__module__, (
+        f"Expected log emitted by '{query_cls.__module__}', got '{record.name}' "
+        "(likely used logging.error(...) instead of logger.error(...))"
+    )
+    assert record.exc_info is not None, f"{query_cls.__name__} logged the error without exc_info -- traceback is lost"
 
 
-def test_fetch_nodes_from_mirror_node_source_has_no_print(caplog):
-    """
-    Static + dynamic check for the missing-mirror-URL fallback path:
-    no print(), and the warning is captured by the logging module.
-    """
+def test_fetch_nodes_from_mirror_node_logs_missing_url(caplog):
+    """Ensure missing mirror URL is logged and an empty list is returned."""
     source = inspect.getsource(Network._fetch_nodes_from_mirror_node)
     assert "print(" not in source
 
-    # Bypass __init__ (which would itself raise ValueError for an unknown
-    # network with no mirror URL and no default nodes) -- we only need
-    # `self.network` set to exercise this specific private method.
+    # Bypass __init__; only self.network is needed for this private method.
     network = Network.__new__(Network)
     network.network = "not-a-known-network"
 
@@ -102,17 +130,17 @@ def test_fetch_nodes_from_mirror_node_source_has_no_print(caplog):
         result = network._fetch_nodes_from_mirror_node()
 
     assert result == []
-    assert any(
-        record.levelno == logging.WARNING and "No known mirror node URL" in record.message for record in caplog.records
-    )
+    matching = [
+        record
+        for record in caplog.records
+        if record.levelno == logging.WARNING and "No known mirror node URL" in record.message
+    ]
+    assert matching
+    assert matching[0].name == Network.__module__
 
 
 def test_fetch_nodes_from_mirror_node_logs_request_exception(caplog, monkeypatch):
-    """
-    Static + dynamic check for the mirror-node-fetch-failure fallback path:
-    no print(), and the error is captured by the logging module, with the
-    method still falling back to an empty list rather than raising.
-    """
+    """Ensure request failures are logged and fall back to an empty list."""
     source = inspect.getsource(Network._fetch_nodes_from_mirror_node)
     assert "print(" not in source
 
@@ -131,7 +159,10 @@ def raise_request_exception(*args, **kwargs):
         result = network._fetch_nodes_from_mirror_node()
 
     assert result == []
-    assert any(
-        record.levelno == logging.ERROR and "Error fetching nodes from mirror node API" in record.message
+    matching = [
+        record
         for record in caplog.records
-    )
+        if record.levelno == logging.ERROR and "Error fetching nodes from mirror node API" in record.message
+    ]
+    assert matching
+    assert matching[0].name == Network.__module__