Skip to content

Commit a7bddd6

Browse files
refactor: standardize Good First Issue label usage
Signed-off-by: Bhuvan Somisetty <somisettybhuvan5@gmail.com>
1 parent 30b947d commit a7bddd6

7 files changed

Lines changed: 12 additions & 12 deletions

File tree

.github/ISSUE_TEMPLATE/00-good-first-issue-candidate.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ body:
8282
- The complete steps to implement the solution
8383
- What the final result or output should look like
8484
- Links to relevant documentation or code (if helpful)
85-
For good first issues, please keep this as guided and clear as possible.
85+
For Good First Issues, please keep this as guided and clear as possible.
8686
value: |
8787
<!-- Identify what to change in which files -->
8888
@@ -95,7 +95,7 @@ body:
9595
attributes:
9696
label: 🧠 Good First Issue Developers — Prerequisites & Expectations
9797
description: |
98-
Adapt as needed. Concrete requirements before claiming this good first issue. Adapt as needed.
98+
Adapt as needed. Concrete requirements before claiming this Good First Issue. Adapt as needed.
9999
value: |
100100
> [!IMPORTANT]
101101
> **This issue does not require prior domain knowledge.**

.github/ISSUE_TEMPLATE/01-good-first-issue.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ body:
6969
- The complete steps to implement the solution
7070
- What the final result or output should look like
7171
- Links to relevant documentation or code (if helpful)
72-
For good first issues, please keep this as guided and clear as possible.
72+
For Good First Issues, please keep this as guided and clear as possible.
7373
value: |
7474
<!-- Identify what to change in which files -->
7575
@@ -82,7 +82,7 @@ body:
8282
attributes:
8383
label: 🧠 Good First Issue Developers — Prerequisites & Expectations
8484
description: |
85-
Adapt as needed. Concrete requirements before claiming this good first issue. Adapt as needed.
85+
Adapt as needed. Concrete requirements before claiming this Good First Issue. Adapt as needed.
8686
value: |
8787
> [!IMPORTANT]
8888
> **This issue does not require prior domain knowledge.**

.github/ISSUE_TEMPLATE/02-beginner-issue.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ body:
9898
> **Beginner issues are low-risk but we expect a working solution.**
9999
100100
> [!IMPORTANT]
101-
> We recommend completing at least 3 good first issues before attempting a beginner issue.
101+
> We recommend completing at least 3 Good First Issues before attempting a beginner issue.
102102
103103
**Difficulty:**
104104
@@ -113,7 +113,7 @@ body:
113113
> - Keeping your fork up to date with main by [rebasing](https://github.com/hiero-ledger/sdk-collaboration-hub/blob/main/guides/issue-progression/for-developers/rebasing.md)
114114
> - Looking things up on your own before asking for help
115115
116-
If any of that feels unfamiliar, good first issues might still be the most rewarding path for you right now — [find one here](https://github.com/issues?q=is%3Aopen%20is%3Aissue%20org%3Ahiero-ledger%20archived%3Afalse%20no%3Aassignee%20(label%3A%22good%20first%20issue%22%20OR%20label%3A%22skill%3A%20good%20first%20issue%22)%20(repo%3Ahiero-ledger%2Fhiero-sdk-cpp%20OR%20repo%3Ahiero-ledger%2Fhiero-sdk-swift%20OR%20repo%3Ahiero-ledger%2Fhiero-sdk-python%20OR%20repo%3Ahiero-ledger%2Fhiero-sdk-js%20OR%20repo%3Ahiero-ledger%2Fhiero-website)).
116+
If any of that feels unfamiliar, Good First Issues might still be the most rewarding path for you right now — [find one here](https://github.com/issues?q=is%3Aopen%20is%3Aissue%20org%3Ahiero-ledger%20archived%3Afalse%20no%3Aassignee%20(label%3A%22good%20first%20issue%22%20OR%20label%3A%22skill%3A%20good%20first%20issue%22)%20(repo%3Ahiero-ledger%2Fhiero-sdk-cpp%20OR%20repo%3Ahiero-ledger%2Fhiero-sdk-swift%20OR%20repo%3Ahiero-ledger%2Fhiero-sdk-python%20OR%20repo%3Ahiero-ledger%2Fhiero-sdk-js%20OR%20repo%3Ahiero-ledger%2Fhiero-website)).
117117
You can always come back when you are ready.
118118
119119
### ⚠️ AI Usage Policy

.github/scripts/bot-gfi-assign-on-comment.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ function commentRequestsAssignment(body) {
6060
}
6161

6262
/**
63-
* Returns true if the issue has the good first issue label.
63+
* Returns true if the issue has the Good First Issue label.
6464
*/
6565
function issueIsGoodFirstIssue(issue) {
6666
const labels = issue?.labels?.map(label => label.name) ?? [];

.github/scripts/bot-next-issue-recommendation.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ module.exports = async ({ github, context, core }) => {
5959
// Determine issue difficulty level
6060
const difficultyLevels = {
6161
beginner: labelSet.has('beginner'),
62-
goodFirstIssue: labelSet.has('good first issue'),
62+
goodFirstIssue: labelSet.has('Good First Issue'),
6363
intermediate: labelSet.has('intermediate'),
6464
advanced: labelSet.has('advanced'),
6565
};
@@ -85,7 +85,7 @@ module.exports = async ({ github, context, core }) => {
8585

8686
if (recommendedIssues.length === 0) {
8787
isFallback = true;
88-
recommendedIssues = await searchIssues(github, core, repoOwner, repoName, 'good first issue');
88+
recommendedIssues = await searchIssues(github, core, repoOwner, repoName, 'Good First Issue');
8989
recommendedLabel = 'Good First Issue';
9090
}
9191

@@ -170,7 +170,7 @@ async function generateAndPostComment(github, context, core, prNumber, recommend
170170
`org:${context.repo.owner}`,
171171
'archived:false',
172172
'no:assignee',
173-
'(label:"good first issue" OR label:"skill: good first issue")',
173+
'(label:"Good First Issue" OR label:"skill: Good First Issue")',
174174
`(${repoQuery})`,
175175
].join(' ');
176176

.github/workflows/bot-gfi-candidate-notification.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ permissions:
1414
jobs:
1515
gfi_candidate_notify_team:
1616
runs-on: hl-sdk-py-lin-md
17-
if: contains(github.event.issue.labels.*.name, 'good first issue candidate')
17+
if: contains(github.event.issue.labels.*.name, 'Good First Issue candidate')
1818
concurrency:
1919
group: gfi-candidate-${{ github.event.issue.number }}
2020
cancel-in-progress: false

docs/sdk_developers/training/workflow/04_assigning_issues.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
## Getting Assigned to an Issue
22

3-
Claim an issue as yours to work on by commenting on a good first issue with exactly: /assign
3+
Claim an issue as yours to work on by commenting on a Good First Issue with exactly: /assign
44

55
We recommend Good First Issues for developers new to the Python SDK. These are easier and better documented tasks.
66

0 commit comments

Comments
 (0)