refactor: centralize Good First Issue labels and remove migration script

Signed-off-by: DeathGun44 <krishnamewara841@gmail.com>

Author: DeathGun44

.github/scripts/bot-gfi-assign-on-comment.js

@@ -6,7 +6,7 @@
 
 const fs = require('fs'); // For spam list
 
-const GOOD_FIRST_ISSUE_LABEL = 'Good First Issue';
+const { GOOD_FIRST_ISSUE_LABEL } = require('./shared/labels.js');
 const UNASSIGNED_GFI_SEARCH_URL =
     'https://github.com/hiero-ledger/hiero-sdk-python/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22Good%20First%20Issue%22%20no%3Aassignee';
 

.github/scripts/bot-gfi-candidate-notification.js

@@ -1,5 +1,6 @@
 // Script to notify the team when a Good First Issue Candidate is created.
 
+const { GOOD_FIRST_ISSUE_CANDIDATE_LABEL } = require('./shared/labels.js');
 const marker = '<!-- GFI Candidate Notification -->';
 const TEAM_ALIAS = '@hiero-ledger/hiero-sdk-good-first-issue-support';
 
@@ -53,7 +54,7 @@ module.exports = async ({ github, context }) => {
     }
 
     //  Only handle Good First Issue Candidate
-    if (label.name.toLowerCase() !== 'good first issue candidate') {
+    if (label.name.toLowerCase() !== GOOD_FIRST_ISSUE_CANDIDATE_LABEL.toLowerCase()) {
       return;
     }
 

.github/scripts/bot-next-issue-recommendation.js

@@ -1,4 +1,4 @@
-const { BEGINNER_LABEL, INTERMEDIATE_LABEL, ADVANCED_LABEL } = require('./shared/labels.js');
+const { GOOD_FIRST_ISSUE_LABEL, BEGINNER_LABEL, INTERMEDIATE_LABEL, ADVANCED_LABEL } = require('./shared/labels.js');
 
 const SUPPORTED_GFI_REPOS = [
   'hiero-sdk-cpp',
@@ -61,7 +61,7 @@ module.exports = async ({ github, context, core }) => {
     // Determine issue difficulty level
     const difficultyLevels = {
       beginner: labelSet.has(BEGINNER_LABEL.toLowerCase()),
-      goodFirstIssue: labelSet.has('good first issue'),
+      goodFirstIssue: labelSet.has(GOOD_FIRST_ISSUE_LABEL.toLowerCase()),
       intermediate: labelSet.has(INTERMEDIATE_LABEL.toLowerCase()),
       advanced: labelSet.has(ADVANCED_LABEL.toLowerCase()),
     };
@@ -87,8 +87,8 @@ module.exports = async ({ github, context, core }) => {
 
     if (recommendedIssues.length === 0) {
       isFallback = true;
-      recommendedIssues = await searchIssues(github, core, repoOwner, repoName, 'good first issue');
-      recommendedLabel = 'Good First Issue';
+      recommendedIssues = await searchIssues(github, core, repoOwner, repoName, GOOD_FIRST_ISSUE_LABEL);
+      recommendedLabel = GOOD_FIRST_ISSUE_LABEL;
     }
 
 

.github/scripts/coderabbit_plan_trigger.js

@@ -1,7 +1,7 @@
 // Script to trigger CodeRabbit plan for intermediate and advanced issues
 
 const CODERABBIT_MARKER = '<!-- CodeRabbit Plan Trigger -->';
-const { DIFFICULTY_LABELS } = require('./shared/labels.js');
+const { DIFFICULTY_LABELS, GOOD_FIRST_ISSUE_LABEL } = require('./shared/labels.js');
 
 async function triggerCodeRabbitPlan(github, owner, repo, issue, marker = CODERABBIT_MARKER, isDryRun = false) {
   const comment = `${marker} @coderabbitai plan`;
@@ -33,8 +33,12 @@ async function triggerCodeRabbitPlan(github, owner, repo, issue, marker = CODERA
 }
 
 function hasBeginnerOrHigherLabel(issue, label) {
-  // Check if issue has a difficulty label (case-insensitive)
-  const allowed = new Set(DIFFICULTY_LABELS.map(d => d.toLowerCase()));
+  // Only beginner+ labels qualify here; GFI gets its own CodeRabbit plan
+  // trigger via the assignment bot chain (bot-gfi-assign-on-comment.js).
+  const beginnerPlus = DIFFICULTY_LABELS
+    .filter(d => d !== GOOD_FIRST_ISSUE_LABEL)
+    .map(d => d.toLowerCase());
+  const allowed = new Set(beginnerPlus);
 
   const hasAllowedLabel = issue.labels?.some(l => allowed.has(l?.name?.toLowerCase()));
 

.github/scripts/cron-admin-update-spam-list.js

@@ -8,6 +8,7 @@
  */
 
 const fs = require('fs').promises;
+const { GOOD_FIRST_ISSUE_LABEL } = require('./shared/labels.js');
 
 const SPAM_LIST_PATH = '.github/spam-list.txt';
 const dryRun = (process.env.DRY_RUN || 'false').toString().toLowerCase() === 'true';
@@ -137,7 +138,7 @@ module.exports = async ({github, context, core}) => {
       },
       {
         name:  'rehabilitated PRs',
-        query: `repo:${owner}/${repo} is:pr is:merged label:"Good First Issue"`,
+        query: `repo:${owner}/${repo} is:pr is:merged label:"${GOOD_FIRST_ISSUE_LABEL}"`,
         process: async (pr) => {
          if (!pr.user?.login) {
             console.log(`Skipping PR #${pr.number}: user account unavailable`);

.github/scripts/migrate-skill-labels.sh

@@ -8,18 +8,28 @@
  * corresponding workflow YAML `if:` conditions (which cannot import JS).
  *
  * Environment variable overrides are supported for per-workflow customization:
+ *   GOOD_FIRST_ISSUE_LABEL, GOOD_FIRST_ISSUE_CANDIDATE_LABEL,
  *   BEGINNER_LABEL, INTERMEDIATE_LABEL, ADVANCED_LABEL
  */
 
-const BEGINNER_LABEL     = process.env.BEGINNER_LABEL?.trim()     || 'skill: beginner';
-const INTERMEDIATE_LABEL = process.env.INTERMEDIATE_LABEL?.trim() || 'skill: intermediate';
-const ADVANCED_LABEL     = process.env.ADVANCED_LABEL?.trim()     || 'skill: advanced';
+const GOOD_FIRST_ISSUE_LABEL           = process.env.GOOD_FIRST_ISSUE_LABEL?.trim()           || 'Good First Issue';
+const GOOD_FIRST_ISSUE_CANDIDATE_LABEL = process.env.GOOD_FIRST_ISSUE_CANDIDATE_LABEL?.trim() || 'Good First Issue Candidate';
+const BEGINNER_LABEL                   = process.env.BEGINNER_LABEL?.trim()                   || 'skill: beginner';
+const INTERMEDIATE_LABEL               = process.env.INTERMEDIATE_LABEL?.trim()               || 'skill: intermediate';
+const ADVANCED_LABEL                   = process.env.ADVANCED_LABEL?.trim()                   || 'skill: advanced';
 
 /**
- * All difficulty labels as an array, for scripts that need to check
- * whether an issue has *any* difficulty label (e.g. coderabbit_plan_trigger).
+ * All difficulty labels as an array, ordered by ascending difficulty.
+ *
+ * Scripts that need to check whether an issue has *any* difficulty label
+ * (e.g. coderabbit_plan_trigger) should test against this array.
  */
-const DIFFICULTY_LABELS = [BEGINNER_LABEL, INTERMEDIATE_LABEL, ADVANCED_LABEL];
+const DIFFICULTY_LABELS = [
+  GOOD_FIRST_ISSUE_LABEL,
+  BEGINNER_LABEL,
+  INTERMEDIATE_LABEL,
+  ADVANCED_LABEL,
+];
 
 /**
  * Validates a label string for safe use in API queries.
@@ -39,6 +49,8 @@ function isSafeLabel(value) {
 }
 
 module.exports = {
+  GOOD_FIRST_ISSUE_LABEL,
+  GOOD_FIRST_ISSUE_CANDIDATE_LABEL,
   BEGINNER_LABEL,
   INTERMEDIATE_LABEL,
   ADVANCED_LABEL,

.github/scripts/shared/labels.js

@@ -21,12 +21,22 @@ describe('labels.js — default exports', () => {
 
   beforeEach(() => {
     // Clear any env overrides from previous tests
+    delete process.env.GOOD_FIRST_ISSUE_LABEL;
+    delete process.env.GOOD_FIRST_ISSUE_CANDIDATE_LABEL;
     delete process.env.BEGINNER_LABEL;
     delete process.env.INTERMEDIATE_LABEL;
     delete process.env.ADVANCED_LABEL;
     labels = freshRequire();
   });
 
+  it('exports correct default GOOD_FIRST_ISSUE_LABEL', () => {
+    assert.equal(labels.GOOD_FIRST_ISSUE_LABEL, 'Good First Issue');
+  });
+
+  it('exports correct default GOOD_FIRST_ISSUE_CANDIDATE_LABEL', () => {
+    assert.equal(labels.GOOD_FIRST_ISSUE_CANDIDATE_LABEL, 'Good First Issue Candidate');
+  });
+
   it('exports correct default BEGINNER_LABEL', () => {
     assert.equal(labels.BEGINNER_LABEL, 'skill: beginner');
   });
@@ -39,24 +49,48 @@ describe('labels.js — default exports', () => {
     assert.equal(labels.ADVANCED_LABEL, 'skill: advanced');
   });
 
-  it('exports DIFFICULTY_LABELS array with all three', () => {
-    assert.equal(labels.DIFFICULTY_LABELS.length, 3);
+  it('exports DIFFICULTY_LABELS array with all four difficulty tiers', () => {
+    assert.equal(labels.DIFFICULTY_LABELS.length, 4);
+    assert.ok(labels.DIFFICULTY_LABELS.includes('Good First Issue'));
     assert.ok(labels.DIFFICULTY_LABELS.includes('skill: beginner'));
     assert.ok(labels.DIFFICULTY_LABELS.includes('skill: intermediate'));
     assert.ok(labels.DIFFICULTY_LABELS.includes('skill: advanced'));
   });
+
+  it('orders DIFFICULTY_LABELS by ascending difficulty', () => {
+    assert.deepEqual(labels.DIFFICULTY_LABELS, [
+      'Good First Issue',
+      'skill: beginner',
+      'skill: intermediate',
+      'skill: advanced',
+    ]);
+  });
+
+  it('does not include GOOD_FIRST_ISSUE_CANDIDATE_LABEL in DIFFICULTY_LABELS', () => {
+    assert.ok(!labels.DIFFICULTY_LABELS.includes('Good First Issue Candidate'));
+  });
 });
 
 describe('labels.js — isSafeLabel', () => {
   let isSafeLabel;
 
   beforeEach(() => {
+    delete process.env.GOOD_FIRST_ISSUE_LABEL;
+    delete process.env.GOOD_FIRST_ISSUE_CANDIDATE_LABEL;
     delete process.env.BEGINNER_LABEL;
     delete process.env.INTERMEDIATE_LABEL;
     delete process.env.ADVANCED_LABEL;
     isSafeLabel = freshRequire().isSafeLabel;
   });
 
+  it('accepts "Good First Issue"', () => {
+    assert.ok(isSafeLabel('Good First Issue'));
+  });
+
+  it('accepts "Good First Issue Candidate"', () => {
+    assert.ok(isSafeLabel('Good First Issue Candidate'));
+  });
+
   it('accepts "skill: beginner"', () => {
     assert.ok(isSafeLabel('skill: beginner'));
   });
@@ -69,10 +103,6 @@ describe('labels.js — isSafeLabel', () => {
     assert.ok(isSafeLabel('skill: advanced'));
   });
 
-  it('accepts "Good First Issue"', () => {
-    assert.ok(isSafeLabel('Good First Issue'));
-  });
-
   it('accepts simple alphanumeric labels', () => {
     assert.ok(isSafeLabel('beginner'));
     assert.ok(isSafeLabel('scope/CI'));
@@ -102,6 +132,21 @@ describe('labels.js — isSafeLabel', () => {
 });
 
 describe('labels.js — environment variable overrides', () => {
+  it('overrides GOOD_FIRST_ISSUE_LABEL from env', () => {
+    process.env.GOOD_FIRST_ISSUE_LABEL = 'custom: gfi';
+    const labels = freshRequire();
+    assert.equal(labels.GOOD_FIRST_ISSUE_LABEL, 'custom: gfi');
+    assert.ok(labels.DIFFICULTY_LABELS.includes('custom: gfi'));
+    delete process.env.GOOD_FIRST_ISSUE_LABEL;
+  });
+
+  it('overrides GOOD_FIRST_ISSUE_CANDIDATE_LABEL from env', () => {
+    process.env.GOOD_FIRST_ISSUE_CANDIDATE_LABEL = 'custom: gfi candidate';
+    const labels = freshRequire();
+    assert.equal(labels.GOOD_FIRST_ISSUE_CANDIDATE_LABEL, 'custom: gfi candidate');
+    delete process.env.GOOD_FIRST_ISSUE_CANDIDATE_LABEL;
+  });
+
   it('overrides BEGINNER_LABEL from env', () => {
     process.env.BEGINNER_LABEL = 'custom: beginner';
     const labels = freshRequire();

.github/scripts/shared/labels.test.js

@@ -1,6 +1,5 @@
-# This workflow automatically triggers CodeRabbit's plan feature for intermediate and advanced issues.
-# Fix for #1427: Only triggers when a beginner/intermediate/advanced label is specifically added,
-# preventing duplicate runs when other labels are added to the same issue.
+# Triggers CodeRabbit's plan feature when a difficulty label is added to an issue.
+# Only fires for skill: beginner/intermediate/advanced labels, preventing duplicate runs.
 name: CodeRabbit Plan Trigger
 on:
   issues: