Edit the auto close bots

[exploreriii]

The auto close bots need an extension as pr's are taking longer to review
Perhaps they can be consolidated as we seem to be experiencing small bugs in preventing unassign for certain pr's that are stuck in review or have a discussion label applied

[github-actions]

@coderabbitai plan

[github-actions]

Thanks for your submission.

This issue is awaiting approval from @hiero-ledger/hiero-sdk-python-triage and @hiero-ledger/hiero-sdk-python-committers and @hiero-ledger/hiero-sdk-python-maintainers.

[github-actions]

Approved by @hiero-ledger/hiero-sdk-python-triage and @hiero-ledger/hiero-sdk-python-committers and @hiero-ledger/hiero-sdk-python-maintainers.

[coderabbitai]

Coding Plan

Summary

• Extend timeout durations to calendar-round values (28/14/10 days) by updating workflow environment variables and script constants
• Fix the Phase 1 gap in bot-inactivity-unassign.sh by adding issue-level label checks before unassigning
• Add in-review label recognition alongside discussion in all scripts that take destructive actions (close/unassign)
• Maintain separate workflows rather than consolidating, as the root cause is inconsistent label checking, not architectural duplication

Design Choices

Design Choice 1: Consolidation of workflows

Options Considered:

1. Consolidate into a single workflow with multiple jobs
2. Keep workflows separate and fix the label-checking bugs

Chosen Option: 2

Rationale: The bugs stem from inconsistent label checking, not workflow duplication. Consolidation would introduce unnecessary complexity and risk without solving the core issue.

Design Choice 2: Extended timeout durations

Options Considered:

1. Extend all timeouts by a fixed percentage (e.g., 50%)
2. Extend to round calendar increments (e.g., 21 days → 28 days)
3. Make timeouts configurable via repository variables

Chosen Option: 2

Rationale: Use round calendar increments that are easy to reason about. Recommend: 21→28 days (unassign), 10→14 days (PR reminder), 7→10 days (issue reminder). Keep 24 hours for linked-issue enforcer as it addresses missing issue links, not review time.

💡 User Tips

Regenerate the plan with different choices with @coderabbitai <feedback>.

Implementation Steps

Phase 1: Extend Timeout Durations

Update the configurable timeout thresholds across all relevant workflows to accommodate longer review cycles.

Task 1: Update Inactivity Unassign Timeout

Extend the main unassign threshold from 21 days to 28 days.

• Update DAYS environment variable in .github/workflows/bot-inactivity-unassign.yml from 21 to 28
• This affects both Phase 1 (issues without PRs) and Phase 2 (issues with stale PRs)

Task 2: Update PR Inactivity Reminder Timeout

Extend the PR reminder threshold from 10 days to 14 days.

• Update inactivityThresholdDays constant in .github/scripts/cron-reminder-pr-inactive.js from 10 to 14

Task 3: Update Issue Reminder Timeout

Extend the issue reminder threshold from 7 days to 10 days.

• Update DAYS environment variable in .github/workflows/cron-reminder-issue-no-pr.yml from 7 to 10

🤖 Prompt for AI agents

Update timeout threshold values across workflow files and scripts to accommodate
longer PR review cycles.

- In `.github/workflows/bot-inactivity-unassign.yml`, update the `DAYS`
environment variable from `21` to `28`
- In `.github/scripts/cron-reminder-pr-inactive.js`, update the
`inactivityThresholdDays` constant from `10` to `14`
- In `.github/workflows/cron-reminder-issue-no-pr.yml`, update the `DAYS`
environment variable from `7` to `10`

Phase 2: Fix Label-Based Exemptions

Add consistent label checking for both discussion and in-review labels across all scripts that close PRs or unassign contributors.

Task 1: Add Label Checks to Phase 1 of Inactivity Bot

Fix the gap where Phase 1 (no linked PR) doesn't check issue labels before unassigning.

• Modify .github/scripts/bot-inactivity-unassign.sh to fetch issue labels at the start of processing each issue
• Before the Phase 1 unassign action, check if the issue has discussion or in-review labels
• If either label is present, skip unassignment and log a skip message
• Use the existing grep -qi '^labelname$' pattern for case-insensitive exact matching

Task 2: Extend Phase 2 Label Check to Include `in-review`

Add in-review label recognition to the existing Phase 2 label check.

• Modify the label-checking block in .github/scripts/bot-inactivity-unassign.sh (around lines 215-219)
• Extend the condition to also check for in-review label using the same grep -qi pattern
• When either discussion or in-review is detected, skip both PR close and issue unassign

Task 3: Add Label Exemption to PR Inactivity Reminder

Prevent reminder comments on PRs with exempt labels.

• Modify .github/scripts/cron-reminder-pr-inactive.js to fetch PR labels before posting a comment
• Check for discussion and in-review labels
• Skip posting the inactivity reminder if either label is present

Task 4: Add Label Exemption to Linked Issue Enforcer

Prevent auto-close of PRs with exempt labels that may legitimately lack linked issues.

• Modify .github/scripts/cron-enforcer-pr-linked-issue.js to fetch PR labels before closing
• Check for discussion and in-review labels
• Skip auto-close if either label is present

🤖 Prompt for AI agents

Add consistent `discussion` and `in-review` label exemption checks across all
scripts that perform destructive actions (close/unassign) on PRs and issues.

**`.github/scripts/bot-inactivity-unassign.sh` — Phase 1 fix:**
- Fetch issue labels at the start of processing each issue in Phase 1
- Before executing the unassign action, check if the issue has a `discussion` or
`in-review` label using the existing `grep -qi '^labelname$'` pattern for
case-insensitive exact matching
- If either label is present, skip unassignment and log a skip message

**`.github/scripts/bot-inactivity-unassign.sh` — Phase 2 fix (around lines
215-219):**
- Extend the existing label-checking condition to also check for the `in-review`
label using the same `grep -qi` pattern
- When either `discussion` or `in-review` is detected, skip both PR close and
issue unassign

**`.github/scripts/cron-reminder-pr-inactive.js`:**
- Fetch PR labels before posting an inactivity reminder comment
- Check for `discussion` and `in-review` labels
- Skip posting the reminder if either label is present

**`.github/scripts/cron-enforcer-pr-linked-issue.js`:**
- Fetch PR labels before executing the auto-close action
- Check for `discussion` and `in-review` labels
- Skip auto-close if either label is present

Phase 3: Update Test Coverage

Ensure the test suite covers the new label exemptions.

Add Test Cases for `in-review` Label

Extend the existing test suite to verify in-review label behavior.

• Add test cases to .github/scripts/test-bot-inactivity-unassign.sh for in-review label exemption in Phase 2
• Add test case verifying Phase 1 now respects discussion label on issues
• Add test case verifying Phase 1 respects in-review label on issues
• Follow existing test patterns (e.g., test_case_insensitivity) for consistency

🤖 Prompt for AI agents

Extend the existing test suite in
`.github/scripts/test-bot-inactivity-unassign.sh` to cover the new label
exemption behavior added in Phase 2.

- Add a test case verifying `in-review` label exemption in Phase 2 (PR close +
unassign skipped)
- Add a test case verifying Phase 1 now respects the `discussion` label
(unassign skipped)
- Add a test case verifying Phase 1 respects the `in-review` label (unassign
skipped)
- Follow existing test patterns (e.g., `test_case_insensitivity`) for
consistency

Research

The repository has five GitHub Actions workflows in .github/workflows/ handling auto-close and unassign behavior, with corresponding scripts in .github/scripts/. The primary inactivity bot (bot-inactivity-unassign.sh) operates in two phases: Phase 1 handles issues without linked PRs, Phase 2 handles issues with linked PRs. Currently, only Phase 2 checks for the discussion label before closing/unassigning. The in-review label is not recognized by any script. Timeout thresholds are configured via workflow environment variables (DAYS, HOURS_BEFORE_CLOSE).

---

🚀 Next Steps

🤖 All AI agent prompts combined

Task: 1

Update timeout threshold values across workflow files and scripts to accommodate
longer PR review cycles.

- In `.github/workflows/bot-inactivity-unassign.yml`, update the `DAYS`
environment variable from `21` to `28`
- In `.github/scripts/cron-reminder-pr-inactive.js`, update the
`inactivityThresholdDays` constant from `10` to `14`
- In `.github/workflows/cron-reminder-issue-no-pr.yml`, update the `DAYS`
environment variable from `7` to `10`
===============================================================================

Task: 2

Add consistent `discussion` and `in-review` label exemption checks across all
scripts that perform destructive actions (close/unassign) on PRs and issues.

**`.github/scripts/bot-inactivity-unassign.sh` — Phase 1 fix:**
- Fetch issue labels at the start of processing each issue in Phase 1
- Before executing the unassign action, check if the issue has a `discussion` or
`in-review` label using the existing `grep -qi '^labelname$'` pattern for
case-insensitive exact matching
- If either label is present, skip unassignment and log a skip message

**`.github/scripts/bot-inactivity-unassign.sh` — Phase 2 fix (around lines
215-219):**
- Extend the existing label-checking condition to also check for the `in-review`
label using the same `grep -qi` pattern
- When either `discussion` or `in-review` is detected, skip both PR close and
issue unassign

**`.github/scripts/cron-reminder-pr-inactive.js`:**
- Fetch PR labels before posting an inactivity reminder comment
- Check for `discussion` and `in-review` labels
- Skip posting the reminder if either label is present

**`.github/scripts/cron-enforcer-pr-linked-issue.js`:**
- Fetch PR labels before executing the auto-close action
- Check for `discussion` and `in-review` labels
- Skip auto-close if either label is present
===============================================================================

Task: 3

Extend the existing test suite in
`.github/scripts/test-bot-inactivity-unassign.sh` to cover the new label
exemption behavior added in Phase 2.

- Add a test case verifying `in-review` label exemption in Phase 2 (PR close +
unassign skipped)
- Add a test case verifying Phase 1 now respects the `discussion` label
(unassign skipped)
- Add a test case verifying Phase 1 respects the `in-review` label (unassign
skipped)
- Follow existing test patterns (e.g., `test_case_insensitivity`) for
consistency

💡 Iterate on the plan with: `@coderabbitai` <feedback>

Example Feedback
- `@coderabbitai` You can skip phase 3. Add a simple unit test case for phase 2.
- `@coderabbitai` For design choice 1 go ahead with option 3 and replan.

---

💬 Have feedback or questions? Drop into our discord!