Bug - linked issue warning comment

[exploreriii]

We had a PR that got closed because the issue is not linked.

We want to ensure there is an automatic reminder to warn before it is linked.

#2358

We believe we have a reminder already, but it is not triggering.

[github-actions]

Thanks for your submission.

This issue is awaiting approval from @hiero-ledger/hiero-sdk-python-triage and @hiero-ledger/hiero-sdk-python-committers and @hiero-ledger/hiero-sdk-python-maintainers.

[github-actions]

Approved by @hiero-ledger/hiero-sdk-python-triage and @hiero-ledger/hiero-sdk-python-committers and @hiero-ledger/hiero-sdk-python-maintainers.

[github-actions]

@coderabbitai plan

[coderabbitai]

Coding Plan

Summary

• Restore the two archived PR warning workflows into the active workflows directory so the intended advance reminder fires on PR open/edit/reopen events again.
• Bring the restored workflows up to the repo-standard pinned versions of actions/checkout and actions/github-script; the backing scripts already work and need no changes.
• Harden the daily enforcer to close a PR only after a matching warning marker comment is present, guaranteeing contributors are always warned before closure and preventing recurrence of the PR #2358 issue.

Design Choices

Design Choice 1: Is reactivating the warning bots sufficient, or should the enforcer also be hardened to never close an unwarned PR?

Options Considered:

1. Reactivate the two archived warning workflows only (minimal restore of the intended design).
2. Reactivate the warning workflows AND add a safety check so the enforcer only closes PRs that already carry a prior warning marker comment.

Chosen Option: 2

Rationale: Reactivating restores the intended reminder, and the enforcer safety check guarantees the ticket's outcome ("warn before close") even if a warning run is missed or delayed, directly preventing recurrence of the exact bug.

💡 User Tips

Regenerate the plan with different choices with @coderabbitai <feedback>.

Implementation Steps

Phase 1: Reactivate the Proactive Warning Workflows

This phase restores the two reminder bots that fire on PR events so contributors receive a clear, idempotent warning to link an issue (and to be assigned) well before the daily enforcer can close the PR. The backing scripts already work and need no changes; only the workflow definitions must be re-enabled and brought in line with the current action toolchain.

Task 1: Restore the "missing linked issue" warning workflow

Re-enable the workflow that warns when a PR has no linked issue.

• Move .github/workflows/archive/bot-pr-missing-linked-issue.yml into the active .github/workflows/ directory so it triggers on pull_request_target (opened, edited, reopened) plus workflow_dispatch.
• Confirm it continues to invoke .github/scripts/bot-pr-missing-linked-issue.js and passes the same PR_NUMBER, DRY_RUN, and GITHUB_TOKEN env vars the script expects.
• Keep the fork-safe pattern intact: pull_request_target with ref: main checkout, harden-runner step, runner hl-sdk-py-lin-md, and least-privilege permissions (pull-requests: write, contents: read, issues: write).

Task 2: Restore the "linked issue not assigned" warning workflow

Re-enable the companion workflow that warns when a PR is linked but its author is not assigned to the issue.

• Move .github/workflows/archive/bot-pr-linked-issue-not-assigned.yml into the active .github/workflows/ directory with the same triggers and permissions as Task 1.1.
• Confirm it continues to invoke .github/scripts/bot-pr-linked-issue-not-assigned.js (which defers to the missing-link bot when no issue is linked, avoiding duplicate/conflicting comments).

Task 3: Update stale action version pins on the restored workflows

Align the restored workflows with the toolchain used by all active workflows.

• In both restored workflow files, bump actions/checkout from the old @8e8c483d… (v6.0.1) pin to the repo-standard @9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0.
• Bump actions/github-script from @ed597411… (v8.0.0) to the dominant active SHA @3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0.
• Leave the runner label hl-sdk-py-lin-md as-is (still current for bot workflows).
• Validate via workflow_dispatch in DRY_RUN mode against a test PR to confirm comments post and marker-based deduplication still prevents duplicates.

🤖 Prompt for AI agents

Restore the two archived PR warning workflows to the active workflows directory
and update their pinned action versions to match the repo standard.

- Move `.github/workflows/archive/bot-pr-missing-linked-issue.yml` to
`.github/workflows/bot-pr-missing-linked-issue.yml`
- Ensure triggers are set to `pull_request_target` (`opened`, `edited`,
`reopened`) plus `workflow_dispatch`
- Confirm the workflow invokes `.github/scripts/bot-pr-missing-linked-issue.js`
with env vars `PR_NUMBER`, `DRY_RUN`, and `GITHUB_TOKEN`
- Preserve the fork-safe pattern: `pull_request_target` with `ref: main`
checkout, harden-runner step, runner `hl-sdk-py-lin-md`, and least-privilege
permissions (`pull-requests: write`, `contents: read`, `issues: write`)
- Move `.github/workflows/archive/bot-pr-linked-issue-not-assigned.yml` to
`.github/workflows/bot-pr-linked-issue-not-assigned.yml`
  - Apply the same triggers and permissions as above
- Confirm the workflow invokes
`.github/scripts/bot-pr-linked-issue-not-assigned.js`
- In both restored workflow files:
- Bump `actions/checkout` from `@8e8c483d… (v6.0.1)` to
`@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0`
- Bump `actions/github-script` from `@ed597411… (v8.0.0)` to
`@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0`
  - Leave the runner label `hl-sdk-py-lin-md` unchanged

Phase 2: Guarantee "Warn Before Close" in the Enforcer

This phase closes the structural gap that allowed PR #2358 to be closed without warning: the enforcer currently closes solely on PR age and validation, without confirming that a warning was actually posted. Adding a warning-awareness check ensures the enforcer never closes a PR that has not already been reminded.

Task 1: Require a prior warning marker before the enforcer closes a PR

Make the daily enforcer act only as the second stage of the warn→close flow.

• Update .github/scripts/cron-enforcer-pr-linked-issue.js so that, before closing a PR, it checks the PR's existing comments for the warning markers <!-- LinkBot Missing Issue --> (for the no-linked-issue case) and <!-- LinkBot Unassigned Linked Issue --> (for the not-assigned case).
• If the corresponding warning marker is absent, skip closing for this run (the warning bots will have a chance to post it), reserving closure for PRs that have already been warned and remain non-compliant past the grace period.
• Keep existing guards (bot-author skip, HOURS_BEFORE_CLOSE=24, REQUIRE_AUTHOR_ASSIGNED, DRY_RUN) unchanged; this adds an additional precondition, not a replacement.
• Reuse the same comment-listing approach already present in the warning scripts for marker detection to stay consistent with established patterns.

Task 2: Verify end-to-end warn-then-close behavior

Confirm the two stages now interoperate as intended.

• Exercise the enforcer in DRY_RUN mode (workflow_dispatch) to confirm it logs "would skip (no prior warning)" for freshly opened non-compliant PRs and "would close" only for PRs that already carry the appropriate warning marker and exceed the grace period.
• Confirm the marker strings used by the enforcer exactly match those emitted by the two warning scripts so detection is reliable.

🤖 Prompt for AI agents

Harden the daily enforcer script so it only closes PRs that have already
received a warning comment, then verify end-to-end behavior.

- Update `.github/scripts/cron-enforcer-pr-linked-issue.js`:
- Before closing a PR, fetch the PR's existing comments and check for the
appropriate warning marker:
    - `<!-- LinkBot Missing Issue -->` for the no-linked-issue case
    - `<!-- LinkBot Unassigned Linked Issue -->` for the not-assigned case
- If the corresponding warning marker is absent, skip closing for this run and
log accordingly (e.g., "would skip (no prior warning)")
- Keep all existing guards unchanged (`bot-author skip`,
`HOURS_BEFORE_CLOSE=24`, `REQUIRE_AUTHOR_ASSIGNED`, `DRY_RUN`); this is an
additional precondition only
- Reuse the same comment-listing approach already present in the warning scripts
for marker detection
- Verify end-to-end behavior:
- Confirm the enforcer logs "would skip (no prior warning)" for freshly opened
non-compliant PRs in `DRY_RUN` mode
- Confirm the enforcer logs "would close" only for PRs carrying the appropriate
warning marker that also exceed the grace period
- Confirm marker strings in the enforcer exactly match those emitted by the two
warning scripts

Research

The .github/ directory implements a multi-stage PR-to-issue linking system. Two reminder bots (bot-pr-missing-linked-issue and bot-pr-linked-issue-not-assigned) were designed to post advance warning comments on PR opened/edited/reopened events, while a daily cron enforcer (cron-enforcer-pr-linked-issue.yml) closes non-compliant PRs after a 24-hour grace period. The two warning workflow definitions currently live in .github/workflows/archive/ and are inactive, so no active workflow triggers them — leaving the enforcer to close PRs as the first and only communication to the author. The backing scripts in .github/scripts/ are intact and correct; only the archived workflow files (with stale action version pins) and the enforcer's lack of a warning-awareness check are at fault.

---

🚀 Next Steps

🤖 All AI agent prompts combined

Task: 1

Restore the two archived PR warning workflows to the active workflows directory
and update their pinned action versions to match the repo standard.

- Move `.github/workflows/archive/bot-pr-missing-linked-issue.yml` to
`.github/workflows/bot-pr-missing-linked-issue.yml`
- Ensure triggers are set to `pull_request_target` (`opened`, `edited`,
`reopened`) plus `workflow_dispatch`
- Confirm the workflow invokes `.github/scripts/bot-pr-missing-linked-issue.js`
with env vars `PR_NUMBER`, `DRY_RUN`, and `GITHUB_TOKEN`
- Preserve the fork-safe pattern: `pull_request_target` with `ref: main`
checkout, harden-runner step, runner `hl-sdk-py-lin-md`, and least-privilege
permissions (`pull-requests: write`, `contents: read`, `issues: write`)
- Move `.github/workflows/archive/bot-pr-linked-issue-not-assigned.yml` to
`.github/workflows/bot-pr-linked-issue-not-assigned.yml`
  - Apply the same triggers and permissions as above
- Confirm the workflow invokes
`.github/scripts/bot-pr-linked-issue-not-assigned.js`
- In both restored workflow files:
- Bump `actions/checkout` from `@8e8c483d… (v6.0.1)` to
`@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0`
- Bump `actions/github-script` from `@ed597411… (v8.0.0)` to
`@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0`
  - Leave the runner label `hl-sdk-py-lin-md` unchanged
===============================================================================

Task: 2

Harden the daily enforcer script so it only closes PRs that have already
received a warning comment, then verify end-to-end behavior.

- Update `.github/scripts/cron-enforcer-pr-linked-issue.js`:
- Before closing a PR, fetch the PR's existing comments and check for the
appropriate warning marker:
    - `<!-- LinkBot Missing Issue -->` for the no-linked-issue case
    - `<!-- LinkBot Unassigned Linked Issue -->` for the not-assigned case
- If the corresponding warning marker is absent, skip closing for this run and
log accordingly (e.g., "would skip (no prior warning)")
- Keep all existing guards unchanged (`bot-author skip`,
`HOURS_BEFORE_CLOSE=24`, `REQUIRE_AUTHOR_ASSIGNED`, `DRY_RUN`); this is an
additional precondition only
- Reuse the same comment-listing approach already present in the warning scripts
for marker detection
- Verify end-to-end behavior:
- Confirm the enforcer logs "would skip (no prior warning)" for freshly opened
non-compliant PRs in `DRY_RUN` mode
- Confirm the enforcer logs "would close" only for PRs carrying the appropriate
warning marker that also exceed the grace period
- Confirm marker strings in the enforcer exactly match those emitted by the two
warning scripts

💡 Iterate on the plan with: `@coderabbitai` <feedback>

Example Feedback
- `@coderabbitai` You can skip phase 3. Add a simple unit test case for phase 2.
- `@coderabbitai` For design choice 1 go ahead with option 3 and replan.

---

💬 Have feedback or questions? Drop into our discord!

[aceppaluni]

#2379

[github-actions]

Hi @aceppaluni 👋

This issue has been assigned but no pull request has been created yet.
Are you still planning on working on it?
If you are, please create a draft PR linked to this issue or comment /working to let us know.
If you’re no longer able to work on this issue, you can comment /unassign to release it.

From the Python SDK Team