feat: add workflow to review PRs labeled with GFI and Beginner#1828
Conversation
There was a problem hiding this comment.
Pull request overview
Adds GitHub Actions automation intended to involve the triage community when PRs are labeled as beginner/GFI, and documents the change in the changelog.
Changes:
- Add a new workflow that triggers on PR label events for “Good First Issue” / “Beginner”.
- Add a changelog entry describing the new workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
CHANGELOG.md |
Documents the addition of a new PR triage-review workflow. |
.github/workflows/request-triage-review.yml |
Introduces a workflow meant to request triage review based on PR labels. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds a GitHub Actions workflow, a helper script, and a changelog entry to post a triage-request comment on PRs labeled "Good First Issue" or "Beginner" (or run manually). The script reads triage reviewers from a repo file or env, supports dry-run, checks idempotency, and posts comments via the GitHub API. Changes
Sequence Diagram(s)sequenceDiagram
participant PR as "Pull Request"
participant Workflow as "GitHub Actions\n(request-triage-review)"
participant Script as "bot-pr-gfi-review-triage.sh"
participant TriageList as ".github/triage-reviewers.txt\nor TRIAGE_REVIEWERS"
participant GitHub as "GitHub API"
participant Reviewer as "Selected triage member"
PR->>Workflow: label added ("Good First Issue"/"Beginner") or manual dispatch
Workflow->>Script: run script (env: GITHUB_EVENT_PATH, GITHUB_TOKEN, GITHUB_REPOSITORY, DRY_RUN)
Script->>TriageList: read reviewers (file or env)
Script->>GitHub: GET /repos/:owner/:repo/issues/:number/comments (check marker)
GitHub-->>Script: comments list
alt marker not present and not dry-run
Script->>GitHub: POST /repos/:owner/:repo/issues/:number/comments (mention selected reviewer)
GitHub-->>Script: 201 Created (comment id)
Script->>Reviewer: notify via comment mention
else marker present or dry-run
Script-->>Workflow: no-op or preview output
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
aceppaluni
left a comment
There was a problem hiding this comment.
@tech0priyanshu Thank you very much!
Was this tested on your fork?
Could we extract some of the logic into a sperate file (i.e .sh or .js)?
|
Hi, this is MergeConflictBot. Please resolve these conflicts locally and push the changes. Quick Fix for CHANGELOG.md ConflictsIf your conflict is only in CHANGELOG.md, you can resolve it easily using the GitHub web editor:
For all other merge conflicts, please read: Thank you for contributing! |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1828 +/- ##
=======================================
Coverage 93.68% 93.68%
=======================================
Files 144 144
Lines 9350 9350
=======================================
Hits 8760 8760
Misses 590 590 🚀 New features to boost your workflow:
|
0a34082 to
63cc81f
Compare
exploreriii
left a comment
There was a problem hiding this comment.
Hi @tech0priyanshu
As this workflow is not urgent, we should focus on creating clean code that is as easy as possible to maintain in the future
May i suggest you switch this from bash to javascript, using github script action
This will mean less manual constructions and is less error prone
Then please focus on writing this with clear exits and logs
Additionally it is essential to research each package you will be using, and use the latest version
docs/sdk_developers/how-to-pin-github-actions.md
We have some guides now in
docs/workflows
|
Hello, this is the OfficeHourBot. This is a reminder that the Hiero Python SDK Office Hours are scheduled in approximately 4 hours (14:00 UTC). This session provides an opportunity to ask questions regarding this Pull Request. Details:
Disclaimer: This is an automated reminder. Please verify the schedule here for any changes. From, |
|
Hi @tech0priyanshu, This pull request has had no commit activity for 10 days. Are you still working on it?
If you're no longer working on this, please comment Reach out on discord or join our office hours if you need assistance. From the Python SDK Team |
|
Yeah, I will resume my work after this. I have exams from Monday to Friday, so I’m busy revising for them. |
f22179e to
42b6c36
Compare
|
Hi, this is WorkflowBot.
|
5079f5d to
7c2c202
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The above repository does not have access to self-hosted runners, so I used runs-on: ubuntu-latest during testing. Additionally, to avoid spamming PR comments, the comment is posted only once when the label is present. Subsequent runs will skip posting. During the second review, the CODEOWNERS file already assigns the relevant reviewers once they are mentioned. cc: @exploreriii |
|
Please could you also help to speed up the review process and resolve the conversations that are. Thanks |
exploreriii
left a comment
There was a problem hiding this comment.
Requesting changes due to inactive package
5fe5551 to
de3b421
Compare
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@tech0priyanshu Can you resolve the open conversations to help speed up review? Thank you! |
Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com> fix updated things Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com> fix Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com> fixs Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com> log remove not needed Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com> update Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com> fix Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com> fixs Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>
Signed-off-by: tech0priyanshu <priyanshuyadv101106@gmail.com>
de3b421 to
6b30c56
Compare
|
Thanks @tech0priyanshu ! |
Description:
Related issue(s): need triage review for pr with GFI and beginner
Fixes #1721
Notes for reviewer:
Checklist