feat: Ruff formating and pre-commit ci for the codebase#2082
Merged
Conversation
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #2082 +/- ##
==========================================
- Coverage 93.70% 93.68% -0.02%
==========================================
Files 145 145
Lines 9452 9426 -26
==========================================
- Hits 8857 8831 -26
Misses 595 595 🚀 New features to boost your workflow:
|
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Complexity | 4 medium |
🟢 Metrics 0 complexity
Metric Results Complexity 0
TIP This summary will be updated as you push new changes. Give us feedback
manishdait
force-pushed
the
feat/ruff-linting
branch
from
April 13, 2026 15:23
5b35115 to
bce5e3c
Compare
Contributor
|
i would not want to accept codacy's current changes for this PR! too much in one to refactor those. |
|
Hi, this is WorkflowBot.
|
manishdait
marked this pull request as ready for review
April 13, 2026 16:11
exploreriii
marked this pull request as draft
April 13, 2026 17:01
manishdait
force-pushed
the
feat/ruff-linting
branch
from
April 13, 2026 18:59
8edc502 to
cd31d5d
Compare
exploreriii
marked this pull request as ready for review
April 13, 2026 20:40
exploreriii
reviewed
Apr 14, 2026
exploreriii
left a comment
Contributor
There was a problem hiding this comment.
Looks really great job, couple questions/notes
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
manishdait
force-pushed
the
feat/ruff-linting
branch
from
April 14, 2026 19:16
02d0894 to
8b3d7d2
Compare
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
exploreriii
approved these changes
Apr 14, 2026
Akshat8510
approved these changes
Apr 14, 2026
Contributor
|
Thanks so much @manishdait |
AntonioCeppellini
pushed a commit
to AntonioCeppellini/hiero-sdk-python
that referenced
this pull request
Apr 22, 2026
…#2082) Signed-off-by: Manish Dait <daitmanish88@gmail.com>
parvninama
pushed a commit
to parvninama/hiero-sdk-python
that referenced
this pull request
Apr 25, 2026
…#2082) Signed-off-by: Manish Dait <daitmanish88@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds
pre-commithooks and GitHub Actions to enforce consistent code quality, security, and modern Python standards across the SDK.Changes Made:
GitHub Actionto run pre-commit on all PRs.Python 3.10+standards and sorted imports. (Mostly handle byRuff)pre-commitRelated issue(s):
Fixes #2043
Notes for reviewer:
-Ddocs check as some of our classes is currently missing the docstring.Checklist