chore: refactor spam labels by Gitjay11 · Pull Request #2151 · hiero-ledger/hiero-sdk-python

Gitjay11 · 2026-04-16T06:07:09Z

Description:
Refactor the GitHub spam list automation script to use the newly standardized label names for spam tracking and issue creation. To make future renaming effortless, the label strings have been extracted into central constants at the top of the module.

Add LABEL_SPAM and LABEL_SPAM_LIST_UPDATE constants to the spam list updater script
Change search queries querying the spam label to query "notes: spam" with proper syntax quoting
Change the default issue-tracking label from spam-list-update to notes: spam-list-update
Update module documentation to clearly specify how to rename these labels in the future

Related issue(s):

Fixes #2129

Notes for reviewer:
N/A - This is an internal CI/automation script refactor. The search query string syntax was specifically verified to properly handle the spaces inside notes: spam during graph queries.

Checklist

Documented (Code comments)

codacy-production · 2026-04-16T06:08:17Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{TIP This summary will be updated as you push new changes. Give us feedback}

coderabbitai · 2026-04-16T06:11:22Z

Walkthrough

Added constants LABEL_SPAM and LABEL_SPAM_LIST_UPDATE to the spam list automation script, replacing hardcoded label name strings with centralized constant definitions for improved maintainability.

Changes

Cohort / File(s)	Summary
Label Constants Refactoring `.github/scripts/cron-admin-update-spam-list.js`	Introduced two constants for label names and updated all references throughout the script to use these constants instead of hardcoded strings, enabling easier future label name modifications.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	The PR partially addresses issue `#2129` by adding constants and updating labels in one file, but does not appear to have comprehensively searched and updated all occurrences of old labels across workflows and scripts as required.	Ensure all instances of 'Spam' and 'spam-list-update' labels are identified and updated across all .github workflows and related scripts, not just the cron-admin-update-spam-list.js file.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'chore: refactor spam labels' accurately summarizes the main change of centralizing and updating spam-related label constants in the automation script.
Description check	✅ Passed	The description clearly explains the refactoring objectives, the constants added, label name changes, and future maintainability improvements, all directly related to the changeset.
Out of Scope Changes check	✅ Passed	All changes in the PR are directly related to refactoring spam labels and centralizing label constants as specified in issue `#2129`, with no extraneous modifications detected.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

📋 Issue Planner

Built with CodeRabbit's Coding Plans for faster development and fewer bugs.

View plan used: #2129

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

.github/scripts/update-spam-list.js (1)
219-232: 🛠️ Refactor suggestion | 🟠 Major

Promote 'automated' label to a top-level constant.

One label value is still hardcoded in the changed path; keep all label config centralized.
♻️ Proposed refactor
 const LABEL_SPAM = 'notes: spam';
 const LABEL_SPAM_LIST_UPDATE = 'notes: spam-list-update';
+const LABEL_AUTOMATED = 'automated';
@@
-          labels: [LABEL_SPAM_LIST_UPDATE, 'automated']
+          labels: [LABEL_SPAM_LIST_UPDATE, LABEL_AUTOMATED]
As per coding guidelines, "Use top-level constants for configuration — avoid hardcoded values scattered through the script."

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6d43ad67-78b6-4a61-a688-04af1105ba6c

📥 Commits

Reviewing files that changed from the base of the PR and between 245133d and 5ef0350.

📒 Files selected for processing (1)

.github/scripts/update-spam-list.js

exploreriii

Great work!

exploreriii · 2026-04-16T14:57:21Z

Rebase please @Gitjay11 or hit update branch

Gitjay11 · 2026-04-16T23:48:07Z

@exploreriii I did it now.

manishdait · 2026-04-20T11:48:01Z

Hi @Gitjay11, please update the branch

Signed-off-by: Ajay Rajera <newajay.11r@gmail.com>

Gitjay11 · 2026-04-20T13:35:14Z

Hi @Gitjay11, please update the branch

@manishdait I did it again

coderabbitai

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

.github/scripts/cron-admin-update-spam-list.js (1)
1-8: ⚠️ Potential issue | 🟡 Minor

Update the module docstring to reflect the renamed label.

Line 5 still references the old 'spam' label. Since this PR standardizes on notes: spam, update the header comment accordingly to stay consistent with the new constants and the issue #2129 intent.
📝 Proposed doc tweak
- * - Identifies spam users from closed unmerged PRs with 'spam' label
+ * - Identifies spam users from closed unmerged PRs with the 'notes: spam' label

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 060ea822-edcc-4665-ad58-22b9492424a8

📥 Commits

Reviewing files that changed from the base of the PR and between 5ef0350 and 4d6b924.

📒 Files selected for processing (1)

.github/scripts/cron-admin-update-spam-list.js

Signed-off-by: Ajay Rajera <newajay.11r@gmail.com>

Gitjay11 requested review from a team as code owners April 16, 2026 06:07

Gitjay11 requested review from leninmehedy and nadineloepfe April 16, 2026 06:07

coderabbitai Bot reviewed Apr 16, 2026

View reviewed changes

Gitjay11 force-pushed the Refactor-spam-label branch from 5ef0350 to 1526f29 Compare April 16, 2026 06:24

exploreriii previously approved these changes Apr 16, 2026

View reviewed changes

exploreriii added step: 2nd second stage of the review approval process reviewer: write requires a review with write permissions labels Apr 16, 2026

github-actions Bot added skill: beginner Achievable by a fairly new comer that has already completed a couple of good first issues notes: extra care requires extra attention to detail or requirements scope: CI/CD involves continuous integration or delivery labels Apr 16, 2026

AntonioCeppellini previously approved these changes Apr 16, 2026

View reviewed changes

manishdait previously approved these changes Apr 16, 2026

View reviewed changes

Gitjay11 dismissed stale reviews from manishdait, AntonioCeppellini, and exploreriii via f13609b April 16, 2026 23:45

Gitjay11 force-pushed the Refactor-spam-label branch from 1526f29 to f13609b Compare April 16, 2026 23:45

exploreriii approved these changes Apr 17, 2026

View reviewed changes

manishdait approved these changes Apr 20, 2026

View reviewed changes

AntonioCeppellini approved these changes Apr 20, 2026

View reviewed changes

github-actions Bot added the notes: extra care requires extra attention to detail or requirements label Apr 20, 2026

chore: refactor spam labels (hiero-ledger#2129)

4d6b924

Signed-off-by: Ajay Rajera <newajay.11r@gmail.com>

Gitjay11 force-pushed the Refactor-spam-label branch from f13609b to 4d6b924 Compare April 20, 2026 13:33

coderabbitai Bot reviewed Apr 20, 2026

View reviewed changes

manishdait merged commit 4cf8bee into hiero-ledger:main Apr 20, 2026
11 checks passed

Abhijeet2409 pushed a commit to Abhijeet2409/hiero-sdk-python that referenced this pull request Apr 22, 2026

chore: refactor spam labels (hiero-ledger#2151)

e598de6

Signed-off-by: Ajay Rajera <newajay.11r@gmail.com>

AntonioCeppellini pushed a commit to AntonioCeppellini/hiero-sdk-python that referenced this pull request Apr 22, 2026

chore: refactor spam labels (hiero-ledger#2151)

b838709

Signed-off-by: Ajay Rajera <newajay.11r@gmail.com>

parvninama pushed a commit to parvninama/hiero-sdk-python that referenced this pull request Apr 25, 2026

chore: refactor spam labels (hiero-ledger#2151)

06c00a9

Signed-off-by: Ajay Rajera <newajay.11r@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: refactor spam labels #2151

chore: refactor spam labels #2151
manishdait merged 1 commit into
hiero-ledger:mainfrom
Gitjay11:Refactor-spam-label

Gitjay11 commented Apr 16, 2026

Uh oh!

codacy-production Bot commented Apr 16, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Apr 16, 2026 •

edited

Loading

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

exploreriii left a comment

Uh oh!

exploreriii commented Apr 16, 2026

Uh oh!

Gitjay11 commented Apr 16, 2026

Uh oh!

manishdait commented Apr 20, 2026

Uh oh!

Gitjay11 commented Apr 20, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Gitjay11 commented Apr 16, 2026

Uh oh!

codacy-production Bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Up to standards ✅

Uh oh!

coderabbitai Bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

exploreriii left a comment

Choose a reason for hiding this comment

Uh oh!

exploreriii commented Apr 16, 2026

Uh oh!

Gitjay11 commented Apr 16, 2026

Uh oh!

manishdait commented Apr 20, 2026

Uh oh!

Gitjay11 commented Apr 20, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codacy-production Bot commented Apr 16, 2026 •

edited

Loading

coderabbitai Bot commented Apr 16, 2026 •

edited

Loading