Skip to content

chore: update Python setup step to specify version 3.14 for the publish and sign workflow#2162

Merged
exploreriii merged 4 commits into
hiero-ledger:mainfrom
danielmarv:cry2-sdk-br
Apr 17, 2026
Merged

chore: update Python setup step to specify version 3.14 for the publish and sign workflow#2162
exploreriii merged 4 commits into
hiero-ledger:mainfrom
danielmarv:cry2-sdk-br

Conversation

@danielmarv

Copy link
Copy Markdown
Member

Description:
This pull request adds a Python setup step to the GitHub Actions workflow. The workflow will now ensure that Python 3.14 is available before proceeding with subsequent steps.

Workflow improvements:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ntege Daniel <danientege785@gmail.com>
Copilot AI review requested due to automatic review settings April 16, 2026 21:35
@danielmarv
danielmarv requested review from a team as code owners April 16, 2026 21:35
@coderabbitai

coderabbitai Bot commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4270e41d-69d3-49f3-8720-eb58a3810ff4

📥 Commits

Reviewing files that changed from the base of the PR and between fc67d6f and 31e1296.

📒 Files selected for processing (1)
  • .github/workflows/publish.yml

Walkthrough

A Python 3.14 setup step using actions/setup-python@v6.2.0 was added to the publish-and-sign job in .github/workflows/publish.yml, occurring before artifact download and Sigstore/PyPI publishing steps.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
.github/workflows/publish.yml
Added a "Set up Python" step to the publish-and-sign job using actions/setup-python@v6.2.0 with python-version: '3.14'; no other job logic changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a Python 3.14 setup step to the publish and sign workflow.
Description check ✅ Passed The description clearly explains the purpose of the change and provides specific details about the workflow file modified and the setup-python action version used.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codacy-production

codacy-production Bot commented Apr 16, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the PyPI publish workflow to ensure a Python runtime is available in the publish-and-sign job (in addition to the existing setup in the build job), supporting signing and publishing release artifacts.

Changes:

  • Add an actions/setup-python@v6.2.0 step to the publish-and-sign job in the publish workflow.
  • Configure the workflow to use Python 3.14 for that job.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@danielmarv
danielmarv marked this pull request as draft April 16, 2026 21:38
Signed-off-by: Ntege Daniel <danientege785@gmail.com>
Signed-off-by: Ntege Daniel <danientege785@gmail.com>
@danielmarv
danielmarv marked this pull request as ready for review April 16, 2026 22:12
@danielmarv

Copy link
Copy Markdown
Member Author

CC @exploreriii
now all runs before the signing works correctly
https://github.com/danielmarv/hiero-sdk-python/actions/runs/24536441051/job/71732499234

@manishdait

Copy link
Copy Markdown
Contributor

Thanks @danielmarv

@manishdait manishdait added step: 2nd second stage of the review approval process reviewer: maintainer PR needs a review from the maintainer team labels Apr 17, 2026
@exploreriii

Copy link
Copy Markdown
Contributor

update branch please @danielmarv

@exploreriii exploreriii added step: merge ready PR is ready and waiting to merge status: update branch developer needs to click update branch labels Apr 17, 2026
@exploreriii
exploreriii merged commit bd69634 into hiero-ledger:main Apr 17, 2026
10 checks passed
@exploreriii exploreriii added this to the v0.2.5 milestone Apr 17, 2026
Abhijeet2409 pushed a commit to Abhijeet2409/hiero-sdk-python that referenced this pull request Apr 22, 2026
…sh and sign workflow (hiero-ledger#2162)

Signed-off-by: Ntege Daniel <danientege785@gmail.com>
AntonioCeppellini pushed a commit to AntonioCeppellini/hiero-sdk-python that referenced this pull request Apr 22, 2026
…sh and sign workflow (hiero-ledger#2162)

Signed-off-by: Ntege Daniel <danientege785@gmail.com>
parvninama pushed a commit to parvninama/hiero-sdk-python that referenced this pull request Apr 25, 2026
…sh and sign workflow (hiero-ledger#2162)

Signed-off-by: Ntege Daniel <danientege785@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewer: maintainer PR needs a review from the maintainer team status: update branch developer needs to click update branch step: merge ready PR is ready and waiting to merge step: 2nd second stage of the review approval process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants