chore: add return type annotation to _is_payment_required in CryptoGetAccountBalanceQuery#2188
Conversation
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull request overview
Adds the missing -> bool return type annotation to _is_payment_required() in CryptoGetAccountBalanceQuery, aligning it with the rest of the query classes’ typed method signatures without changing runtime behavior.
Changes:
- Add
-> boolreturn type annotation toCryptoGetAccountBalanceQuery._is_payment_required().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe change adds an explicit return type annotation ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📋 Issue PlannerBuilt with CodeRabbit's Coding Plans for faster development and fewer bugs. View plan used: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
376f07e to
99c6908
Compare
|
@ManmathX, Thanks for the PR, the commit is missing signoff. you can run |
…tAccountBalanceQuery Signed-off-by: ManmathX <manmath2006n@gmail.com>
99c6908 to
bc259f1
Compare
|
Hi @manishdait , thanks for pointing that out. I’ve fixed the issue by adding the sign-off and updated the commit. Please let me know if anything else needs to be addressed. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #2188 +/- ##
=======================================
Coverage 93.68% 93.68%
=======================================
Files 145 145
Lines 9426 9426
=======================================
Hits 8831 8831
Misses 595 595 🚀 New features to boost your workflow:
|
…tAccountBalanceQuery (hiero-ledger#2188) Signed-off-by: ManmathX <manmath2006n@gmail.com>
…tAccountBalanceQuery (hiero-ledger#2188) Signed-off-by: ManmathX <manmath2006n@gmail.com>
Description
Add the missing
-> boolreturn type annotation to the_is_payment_required()method inCryptoGetAccountBalanceQuery.This was the only public/private method in the class without a return type annotation. The return type is unambiguous — the method always returns
False, and the existing docstring already documents it asbool.Changes
src/hiero_sdk_python/query/account_balance_query.pydef _is_payment_required(self):→def _is_payment_required(self) -> bool:No other files, methods, or lines were modified. SDK behavior is unchanged.
Testing
tests/unit/account_balance_query_test.pypass ✅Related Issue
Closes #2059