Skip to content

Fix: Issue 2187, invalid link for PR Submits (Quick Start list)#2189

Merged
manishdait merged 2 commits into
hiero-ledger:mainfrom
kenimoraj:fix/2187-quickstart-submit-pr-link
Apr 24, 2026
Merged

Fix: Issue 2187, invalid link for PR Submits (Quick Start list)#2189
manishdait merged 2 commits into
hiero-ledger:mainfrom
kenimoraj:fix/2187-quickstart-submit-pr-link

Conversation

@kenimoraj

@kenimoraj kenimoraj commented Apr 22, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Description:
Change a link in the CONTRIBUTING.md file.

Related issue(s):
#2187

@kenimoraj
kenimoraj requested review from a team as code owners April 22, 2026 11:35
@codacy-production

codacy-production Bot commented Apr 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@coderabbitai

coderabbitai Bot commented Apr 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3d7bcb25-a525-496f-8f52-ee86e537924c

📥 Commits

Reviewing files that changed from the base of the PR and between bb13be1 and 3e9fb63.

📒 Files selected for processing (1)
  • CONTRIBUTING.md

Walkthrough

Updated a documentation link in CONTRIBUTING.md: the "Quickstart Submit PR" reference now points to docs/sdk_developers/training/workflow/10_submit_pull_request.md instead of .../11_submit_pull_request.md.

Changes

Cohort / File(s) Summary
Documentation Link Update
CONTRIBUTING.md		 Replaced the "Quickstart Submit PR" link target from docs/sdk_developers/training/workflow/11_submit_pull_request.md to docs/sdk_developers/training/workflow/10_submit_pull_request.md.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

broken-markdown-links, merge: ready

Suggested reviewers

  • AntonioCeppellini
  • manishdait
  • PavelSBorisov

Poem

🐰 A hop, a skip, a link renumbered,
From ten to—wait, it was eleven before!
The path is now straight, no longer encumbered,
Our docs flow like clover across the floor. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically identifies the main change: fixing an invalid link for PR submission documentation in the Quick Start list, directly addressing issue 2187.
Description check ✅ Passed The description is related to the changeset and concisely explains the primary change: updating a link in CONTRIBUTING.md to correct an invalid reference.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@manishdait

manishdait commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

@kenimoraj , Thanks for the PR, the commit is missing signoff follow the docs to add it Signing Docs

@aceppaluni

aceppaluni commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

@kenimoraj Happy to review once changes are addressed, thank you!

@aceppaluni aceppaluni added the step: 1st 1st stage of the review approval process label Apr 22, 2026
@kenimoraj
Fix: Issue 2187, invalid link for PR Submits (Quick Start list)
3e9fb63 
Signed-off-by: Michal Jarominek <michal@jarominek.com>
@kenimoraj
kenimoraj force-pushed the fix/2187-quickstart-submit-pr-link branch from bb13be1 to 3e9fb63 Compare April 22, 2026 17:27
@kenimoraj

kenimoraj commented Apr 22, 2026

Copy link
Copy Markdown
Contributor Author

@manishdait @aceppaluni Sorry for that! I missed this part. I hope it's okay now;)

@tech0priyanshu tech0priyanshu added step: 2nd second stage of the review approval process and removed step: 1st 1st stage of the review approval process labels Apr 22, 2026
@github-actions

github-actions Bot commented Apr 23, 2026

Copy link
Copy Markdown

Hi there! I'm the LinkedIssueBot.
This pull request has been automatically closed due to the following reason(s):

Thank you,
From Python SDK team

@github-actions github-actions Bot closed this Apr 23, 2026
@manishdait manishdait reopened this Apr 23, 2026
@manishdait manishdait linked an issue Apr 23, 2026 that may be closed by this pull request
Fix broken documentation link for Pull Request submission in CONTRIBUTING.md #2187
Closed
33 tasks
@manishdait

manishdait commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

@kenimoraj, Please update the branch

@manishdait manishdait added step: merge ready PR is ready and waiting to merge status: update branch developer needs to click update branch and removed step: 2nd second stage of the review approval process labels Apr 23, 2026
@exploreriii

exploreriii commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

Hi @kenimoraj please click the update branch button on this form

@manishdait
manishdait merged commit e5f7c00 into hiero-ledger:main Apr 24, 2026
9 checks passed
parvninama pushed a commit to parvninama/hiero-sdk-python that referenced this pull request Apr 25, 2026
@kenimoraj @parvninama
Fix: Issue 2187, invalid link for PR Submits (Quick Start list) (hier…
fe7644a 
…o-ledger#2189)

Signed-off-by: Michal Jarominek <michal@jarominek.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manishdait manishdait manishdait approved these changes
@aceppaluni aceppaluni aceppaluni approved these changes
@Adityarya11 Adityarya11 Awaiting requested review from Adityarya11 Adityarya11 is a code owner automatically assigned from hiero-ledger/hiero-sdk-python-committers
@exploreriii exploreriii Awaiting requested review from exploreriii exploreriii is a code owner automatically assigned from hiero-ledger/hiero-sdk-python-maintainers
+1 more reviewer
@cheese-cakee cheese-cakee cheese-cakee approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: update branch developer needs to click update branch step: merge ready PR is ready and waiting to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix broken documentation link for Pull Request submission in CONTRIBUTING.md

6 participants

@kenimoraj @manishdait @aceppaluni @exploreriii @cheese-cakee @tech0priyanshu