Skip to content

refactor: standardize Good First Issue label usage#2218

Merged
manishdait merged 1 commit into
hiero-ledger:mainfrom
bhuvan-somisetty:fix/2178-gfi-clean
May 1, 2026
Merged

refactor: standardize Good First Issue label usage#2218
manishdait merged 1 commit into
hiero-ledger:mainfrom
bhuvan-somisetty:fix/2178-gfi-clean

Conversation

@bhuvan-somisetty

Copy link
Copy Markdown
Contributor

Description

Standardizes the usage of the "Good First Issue" label across issue templates and related scripts.

  • Updated label text to use consistent capitalization ("Good First Issue")
  • Ensured no functional or behavioral changes
  • Limited scope strictly to label standardization

Related Issue

Fixes #2178

Notes

This PR only modifies label naming consistency and does not introduce any logic changes.

Signed-off-by: Bhuvan Somisetty <somisettybhuvan5@gmail.com>
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@coderabbitai

coderabbitai Bot commented May 1, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8b041ba6-bd8a-4bc9-8c68-bd4a27b7b69d

📥 Commits

Reviewing files that changed from the base of the PR and between ce4713d and 1ad9096.

📒 Files selected for processing (4)
  • .github/ISSUE_TEMPLATE/00-good-first-issue-candidate.yml
  • .github/ISSUE_TEMPLATE/01-good-first-issue.yml
  • .github/ISSUE_TEMPLATE/02-beginner-issue.yml
  • .github/scripts/bot-gfi-assign-on-comment.js

Walkthrough

This pull request standardizes capitalization of the "Good First Issue" label terminology across GitHub issue templates and script documentation. Four files receive capitalization updates to use consistent title casing ("Good First Issue(s)") instead of lowercase variants in description text fields and JSDoc comments.

Changes

Cohort / File(s) Summary
Issue Templates
.github/ISSUE_TEMPLATE/00-good-first-issue-candidate.yml, .github/ISSUE_TEMPLATE/01-good-first-issue.yml, .github/ISSUE_TEMPLATE/02-beginner-issue.yml
Capitalized "good first issue(s)" to "Good First Issue(s)" in template description text fields for consistent terminology presentation.
Script Documentation
.github/scripts/bot-gfi-assign-on-comment.js
Updated JSDoc comment to reference the label using proper casing "Good First Issue" instead of lowercase variant.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR addresses only capitalization standardization in templates and JSDoc comments, which is a subset of issue #2178's broader scope. The PR does not implement the core requirement to centralize label handling across scripts/workflows or provide testing evidence. Implement centralized label constant handling across .github scripts [#2178], add script-level validation tests, and include fork-based end-to-end verification with evidence in the PR before requesting review.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'refactor: standardize Good First Issue label usage' directly and clearly describes the main change—standardizing label naming consistency across templates and scripts.
Description check ✅ Passed The description accurately relates to the changeset, explaining that label text was updated to consistent capitalization across issue templates and scripts with no functional changes.
Out of Scope Changes check ✅ Passed All four changed files are GitHub template and script files within .github scope; however, only capitalization and JSDoc updates were made, which are narrower than the centralization refactoring required by issue #2178.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📋 Issue Planner

Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).

View plan for ticket: #2178

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@bhuvan-somisetty

Copy link
Copy Markdown
Contributor Author

@exploreriii

Created a fresh PR from updated main with only the required changes for Good First Issue label standardization.

Only the relevant files are changed. Please review when you have time.

@exploreriii exploreriii added step: 2nd second stage of the review approval process reviewer: write requires a review with write permissions labels May 1, 2026
@github-actions github-actions Bot added skill: intermediate requires some knowledge of the codebase with some defined steps to implement or examples lang: javascript Uses Javascript programming language notes: extra care requires extra attention to detail or requirements scope: CI/CD involves continuous integration or delivery labels May 1, 2026
@bhuvan-somisetty

Copy link
Copy Markdown
Contributor Author

Thanks for the review. I kept this PR intentionally scoped to the four GFI-related files after the previous feedback. Please let me know if maintainers expect this PR to also implement centralized label handling and tests, or if that should be handled separately.

@bhuvan-somisetty

Copy link
Copy Markdown
Contributor Author

Thank you for the review and approval!

@manishdait
manishdait merged commit bcc8417 into hiero-ledger:main May 1, 2026
14 checks passed
@manishdait manishdait added this to the v0.2.6 milestone May 4, 2026
NssGourav pushed a commit to NssGourav/hiero-sdk-python that referenced this pull request May 14, 2026
Signed-off-by: Bhuvan Somisetty <somisettybhuvan5@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang: javascript Uses Javascript programming language notes: extra care requires extra attention to detail or requirements reviewer: write requires a review with write permissions scope: CI/CD involves continuous integration or delivery skill: intermediate requires some knowledge of the codebase with some defined steps to implement or examples step: 2nd second stage of the review approval process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor Good First Issue label handling across .github workflows and scripts

3 participants