fix: handle beginner label in triage workflow#2250
Conversation
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughReformats the ChangesGitHub Actions Workflow Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📋 Issue PlannerLet us write the prompt for your AI agent so you can ship faster (with fewer bugs). View plan for ticket: ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
|
LGTM - Great work on identifying and fixing this, @NssGourav! 🎉 The root cause analysis is spot-on — the ${{ }} wrapper inside the if: condition causes YAML to misinterpret the colon in 'skill: beginner' as a key-value separator. Since GitHub Actions automatically evaluates if: conditions as expressions, removing the wrapper is the cleanest fix. One small suggestion for improvement: Thanks for the contribution! 🙌 |
e44907d to
6ff9e83
Compare
|
Thanks @ManmathX ,addressed the feedback cleaned the branch history and normalizing github script indentation. |
Signed-off-by: Gourav NSS <gourav341111@gmail.com>
6ff9e83 to
065b62b
Compare
aceppaluni
left a comment
There was a problem hiding this comment.
This is looking good. Are you able to share a link to your test?
Sure, I added the test evidence here: It includes the successful pre commit run from before the rebase and notes that the latest upstream workflow runs are awaiting maintainer approval after rebasing. |
|
@NssGourav This is great! Please update your branch and then we can merge. Thank you! |
|
Hi, this is WorkflowBot.
|
|
@NssGourav Thank you so much! |
Signed-off-by: Gourav NSS <gourav341111@gmail.com>
Description:
Fix the triage review workflow condition for beginner labeled PRs.
${{ }}wrapper from the job-levelifconditionskill: beginnerlabel in the triage review workflowGood First Issueandbeginnerlabel checksRelated issue(s):
Fixes #2227
Notes for reviewer:
This is a CI workflow only change. GitHub Actions evaluates job-level
if:conditions as expressions by default, so removing the wrapper avoids YAML parsing issues with labels containing a colon, such asskill: beginner.Validated locally:
.github/workflows/request-triage-review.ymlwith Python YAML loadingactionlintwith the repository’s custom self-hosted runner label warning ignoredChecklist