Skip to content

fix: handle beginner label in triage workflow#2250

Merged
aceppaluni merged 2 commits into
hiero-ledger:mainfrom
NssGourav:fix-request-triage-review-label
May 7, 2026
Merged

fix: handle beginner label in triage workflow#2250
aceppaluni merged 2 commits into
hiero-ledger:mainfrom
NssGourav:fix-request-triage-review-label

Conversation

@NssGourav

Copy link
Copy Markdown
Contributor

Description:

Fix the triage review workflow condition for beginner labeled PRs.

  • Remove the redundant ${{ }} wrapper from the job-level if condition
  • Add support for the skill: beginner label in the triage review workflow
  • Preserve the existing Good First Issue and beginner label checks
  • Format the workflow condition and GitHub script block for readability

Related issue(s):

Fixes #2227

Notes for reviewer:

This is a CI workflow only change. GitHub Actions evaluates job-level if: conditions as expressions by default, so removing the wrapper avoids YAML parsing issues with labels containing a colon, such as skill: beginner.

Validated locally:

  • Parsed .github/workflows/request-triage-review.yml with Python YAML loading
  • Ran actionlint with the repository’s custom self-hosted runner label warning ignored

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@NssGourav
NssGourav requested review from a team as code owners May 7, 2026 05:23
@coderabbitai

coderabbitai Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 56a3551e-99b9-41b9-9001-bcc1ed1d007f

📥 Commits

Reviewing files that changed from the base of the PR and between 6ff9e83 and 065b62b.

📒 Files selected for processing (1)
  • .github/workflows/request-triage-review.yml

Walkthrough

Reformats the request-triage job if condition into a multiline OR expression and reindents the inline actions/github-script JavaScript so listComments and createComment consistently pass owner, repo, and issue_number; triage comment creation remains gated on absence of <!-- triage -->.

Changes

GitHub Actions Workflow Fix

Layer / File(s) Summary
Job Condition Expression
.github/workflows/request-triage-review.yml (range_f2c570beace7)
Reformatted jobs.request-triage.if from a single-line expression to a multiline if: > OR chain keeping the same three contains(...) label checks.
Embedded Script Formatting
.github/workflows/request-triage-review.yml (range_6e29351e8dde)
Reindented inline JavaScript so github.rest.issues.listComments and the conditional github.rest.issues.createComment consistently pass owner, repo, and issue_number from context; preserved <!-- triage --> existence gating.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing the triage workflow to handle the beginner label by removing the ${{ }} wrapper and adding skill: beginner support.
Description check ✅ Passed The description clearly explains the fix, lists all changes made, references the linked issue #2227, and includes validation details and a checklist.
Linked Issues check ✅ Passed The PR successfully addresses issue #2227 by removing the ${{ }} wrapper from the if condition and adding support for the 'skill: beginner' label alongside existing label checks.
Out of Scope Changes check ✅ Passed All changes are directly related to fixing the triage workflow and are scoped to the .github/workflows/request-triage-review.yml file only.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📋 Issue Planner

Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).

View plan for ticket: #2227

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@exploreriii exploreriii added step: 1st 1st stage of the review approval process reviewer: community pull requests looking for community reviews labels May 7, 2026
@codacy-production

codacy-production Bot commented May 7, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@ManmathX

ManmathX commented May 7, 2026

Copy link
Copy Markdown
Contributor

LGTM - Great work on identifying and fixing this, @NssGourav! 🎉

The root cause analysis is spot-on — the ${{ }} wrapper inside the if: condition causes YAML to misinterpret the colon in 'skill: beginner' as a key-value separator. Since GitHub Actions automatically evaluates if: conditions as expressions, removing the wrapper is the cleanest fix.

One small suggestion for improvement:
The indentation of the JavaScript block inside actions/github-script (lines 31–43) is a bit inconsistent — some lines use different levels of indentation. If you'd like to clean that up in the same PR, it would make the file easier to maintain going forward. Totally optional though, the core fix is what matters here.

Thanks for the contribution! 🙌

@NssGourav
NssGourav force-pushed the fix-request-triage-review-label branch from e44907d to 6ff9e83 Compare May 7, 2026 10:52
@NssGourav

Copy link
Copy Markdown
Contributor Author

Thanks @ManmathX ,addressed the feedback cleaned the branch history and normalizing github script indentation.

@github-actions github-actions Bot added scope: CI/CD involves continuous integration or delivery skill: beginner Achievable by a fairly new comer that has already completed a couple of good first issues labels May 7, 2026
@exploreriii exploreriii added step: 2nd second stage of the review approval process and removed step: 1st 1st stage of the review approval process reviewer: community pull requests looking for community reviews labels May 7, 2026
Signed-off-by: Gourav NSS <gourav341111@gmail.com>
@NssGourav
NssGourav force-pushed the fix-request-triage-review-label branch from 6ff9e83 to 065b62b Compare May 7, 2026 14:29

@aceppaluni aceppaluni left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NssGourav

This is looking good. Are you able to share a link to your test?

@NssGourav

Copy link
Copy Markdown
Contributor Author

@NssGourav

This is looking good. Are you able to share a link to your test?

Sure, I added the test evidence here:
NssGourav#2

It includes the successful pre commit run from before the rebase and notes that the latest upstream workflow runs are awaiting maintainer approval after rebasing.

@aceppaluni

Copy link
Copy Markdown
Contributor

@NssGourav This is great!

Please update your branch and then we can merge. Thank you!

@aceppaluni aceppaluni added the step: merge ready PR is ready and waiting to merge label May 7, 2026
@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown

Hi, this is WorkflowBot.
Your pull request cannot be merged as it is not passing all our workflow checks.
Please click on each check to review the logs and resolve issues so all checks pass.
To help you:

@aceppaluni
aceppaluni merged commit 71bd38f into hiero-ledger:main May 7, 2026
13 of 16 checks passed
@aceppaluni

Copy link
Copy Markdown
Contributor

@NssGourav Thank you so much!

@NssGourav
NssGourav deleted the fix-request-triage-review-label branch May 7, 2026 19:34
@manishdait manishdait added this to the v0.2.7 milestone May 8, 2026
manishdait pushed a commit to manishdait/hiero-sdk-python that referenced this pull request May 18, 2026
Signed-off-by: Gourav NSS <gourav341111@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: CI/CD involves continuous integration or delivery skill: beginner Achievable by a fairly new comer that has already completed a couple of good first issues step: merge ready PR is ready and waiting to merge step: 2nd second stage of the review approval process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Workflow fails with YAML parsing error when checking for skill: beginner label

5 participants