Skip to content

fix: grant write permissions for review queue sync#2254

Merged
exploreriii merged 1 commit into
hiero-ledger:mainfrom
darshit2308:feature/review-sync-phase1
May 8, 2026
Merged

fix: grant write permissions for review queue sync#2254
exploreriii merged 1 commit into
hiero-ledger:mainfrom
darshit2308:feature/review-sync-phase1

Conversation

@darshit2308

@darshit2308 darshit2308 commented May 7, 2026

Copy link
Copy Markdown
Contributor

Description:
Adds pull-requests: write permissions to review-sync.yml to resolve the 403 Resource not accessible by integration error encountered during the label sync phase.

Notes for reviewer:
Opening a follow-up PR specifically to fix the missing GitHub Actions permissions we discussed.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copilot AI review requested due to automatic review settings May 7, 2026 21:46
@darshit2308
darshit2308 requested review from a team as code owners May 7, 2026 21:46
@codacy-production

codacy-production Bot commented May 7, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions workflow token permissions for the Review Queue Label Sync workflow to allow it to write to pull requests (needed for label/PR state updates during the sync job), addressing the 403 Resource not accessible by integration failure during label sync.

Changes:

  • Change pull-requests permission from read to write in .github/workflows/review-sync.yml.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai

coderabbitai Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2b291fb6-c648-4db9-857e-dd8ce510b9d6

📥 Commits

Reviewing files that changed from the base of the PR and between c996045 and b0c539d.

📒 Files selected for processing (1)
  • .github/workflows/review-sync.yml

Walkthrough

The review-sync GitHub Actions workflow updates its top-level permissions to grant pull-requests: write (was read). All other workflow settings and steps remain unchanged.

Changes

Workflow Pull Request Permissions

Layer / File(s) Summary
Workflow Permissions
.github/workflows/review-sync.yml
Workflow-level permissions.pull-requests changed from read to write, allowing the workflow token to perform pull request API operations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: granting write permissions for pull-requests in the review-sync workflow to fix a permissions error.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose of adding pull-requests write permissions and referencing the 403 error that prompted the fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@exploreriii exploreriii left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase with latest changes please, your main is out dated
https://github.com/darshit2308/hiero-sdk-python

this PR should not contain 14 commits from the prior PR

@darshit2308
darshit2308 force-pushed the feature/review-sync-phase1 branch from c996045 to f9eb2cc Compare May 7, 2026 22:14
@darshit2308
darshit2308 marked this pull request as draft May 7, 2026 23:07
@darshit2308
darshit2308 force-pushed the feature/review-sync-phase1 branch from f9eb2cc to c668d78 Compare May 7, 2026 23:10
Signed-off-by: darshit2308 <darshit2308@gmail.com>
@darshit2308
darshit2308 force-pushed the feature/review-sync-phase1 branch from c668d78 to b0c539d Compare May 8, 2026 05:48
@darshit2308
darshit2308 marked this pull request as ready for review May 8, 2026 06:15
@exploreriii
exploreriii merged commit 80bf1b9 into hiero-ledger:main May 8, 2026
13 checks passed
@manishdait manishdait added this to the v0.2.7 milestone May 8, 2026
darshit2308 added a commit to darshit2308/hiero-sdk-python that referenced this pull request May 9, 2026
Signed-off-by: darshit2308 <darshit2308@gmail.com>
darshit2308 added a commit to darshit2308/hiero-sdk-python that referenced this pull request May 9, 2026
Signed-off-by: darshit2308 <darshit2308@gmail.com>
NssGourav pushed a commit to NssGourav/hiero-sdk-python that referenced this pull request May 14, 2026
Signed-off-by: darshit2308 <darshit2308@gmail.com>
manishdait pushed a commit to manishdait/hiero-sdk-python that referenced this pull request May 18, 2026
Signed-off-by: darshit2308 <darshit2308@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants