Fix signer_nonce serialization in ContractFunctionResult#2293
Conversation
Signed-off-by: utkarsh patrikar <utkarshpatrikar@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
Walkthrough
Changessigner_nonce Optional Field Serialization
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📋 Issue PlannerBuilt with CodeRabbit's Coding Plans for faster development and fewer bugs. View plan used: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #2293 +/- ##
=======================================
Coverage 93.97% 93.97%
=======================================
Files 163 163
Lines 10408 10408
=======================================
Hits 9781 9781
Misses 627 627 🚀 New features to boost your workflow:
|
|
@utkarsh232005, Please update the branch |
AntonioCeppellini
left a comment
There was a problem hiding this comment.
LGTM 🛩️ :D
thank you for your contribution!
|
👋 Hi @utkarsh232005! Great work completing a Beginner issue! 🎉 Thanks for your contribution! 🚀 Here are some issues you might want to explore next:
🌟 Stay connected: Happy coding! 🚀 |
This PR fixes a serialization bug in ContractFunctionResult._to_proto() and adds corresponding unit test coverage. Fixes #2251