refactor: simplify delete_token_nft_allowance_all_serials entry handling#2294
Conversation
Signed-off-by: dosi <dosi.kolev@limechain.tech>
Signed-off-by: dosi <dosi.kolev@limechain.tech>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #2294 +/- ##
==========================================
+ Coverage 93.97% 94.01% +0.03%
==========================================
Files 163 163
Lines 10408 10403 -5
==========================================
- Hits 9781 9780 -1
+ Misses 627 623 -4 🚀 New features to boost your workflow:
|
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThis PR modifies the ChangesNFT Allowance Delete-All-Serials Append Behavior
🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 7edca58d-7060-48d8-be10-931fb8c85687
📒 Files selected for processing (3)
src/hiero_sdk_python/account/account_allowance_approve_transaction.pytests/integration/account_allowance_e2e_test.pytests/unit/account_allowance_approve_transaction_test.py
💤 Files with no reviewable changes (1)
- src/hiero_sdk_python/account/account_allowance_approve_transaction.py
Signed-off-by: dosi <dosi.kolev@limechain.tech>
Description:
Simplify
AccountAllowanceApproveTransaction.delete_token_nft_allowance_all_serialsso that each call produces its ownTokenNftAllowanceentry. Repeated or chained calls on the same(token, spender)pair are no longer folded into a single entrydelete_token_nft_allowance_all_serialsto append a newTokenNftAllowanceentry per call instead of folding into an existing entryapprove_token_nft_allowancefollowed bydelete_token_nft_allowance_all_serialson the same(token, spender)pairdelete_token_nft_allowance_all_serialscalls on the same(token, spender)pairapprove_token_nft_allowancefollowed bydelete_token_nft_allowance_all_serialson the same(token, spender)pairRelated issue(s):
Fixes #
Notes for reviewer:
Checklist