feat(tck): Add getTopicInfo method to TCK

[manishdait]

Description:
This PR introduce the getTopicId method to tck module.

Changes Made:

• Added the getTopicInfo method to tck.
• Update the topic_info_query to handle None topic_id.

Related issue(s):

Fixes #2394

Notes for reviewer:

• Updated topic_info to include topicId and replace the proto type to use sdk-types for autoRenewAccount, adminKey, submitKey
• Update the unit/integration test for this changes.

Checklist

• Documented (Code comments, README, etc.)
• Tested (unit, integration, etc.)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main    #2395      +/-   ##
==========================================
- Coverage   95.04%   95.01%   -0.04%     
==========================================
  Files         163      163              
  Lines       10461    10465       +4     
==========================================
  Hits         9943     9943              
- Misses        518      522       +4     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

Hi, this is WorkflowBot.
Your pull request cannot be merged as it is not passing all our workflow checks.
Please click on each check to review the logs and resolve issues so all checks pass.
To help you:

• DCO signing guide
• Merge conflicts guide
• Rebase guide
• Testing guide
• Discord
• Community Calls
  Thank you for contributing!
  From the Hiero Python SDK Team

[coderabbitai]

Walkthrough

TopicInfo now carries topic_id and parses from ConsensusGetTopicInfoResponse, TopicInfoQuery forwards that wrapper, and the TCK module adds getTopicInfo support with new params, response types, mapping helpers, and shared key serialization. Tests and examples were updated to match the new shapes.

Changes

TopicInfo refactor and getTopicInfo TCK handler

Layer / File(s)	Summary
TopicInfo and query wrapper parsing src/hiero_sdk_python/consensus/topic_info.py, src/hiero_sdk_python/query/topic_info_query.py	TopicInfo.__init__ adds topic_id: TopicId; _from_proto now accepts ConsensusGetTopicInfoResponse and reads nested topicInfo/topicID; key and account conversions use Key.from_proto_key and AccountId._from_proto; __str__ includes topic_id. TopicInfoQuery._make_request makes topicID population conditional on non-None; execute passes response.consensusGetTopicInfo directly to _from_proto.
TCK params, response types, and key serialization tck/param/topic.py, tck/response/topic.py, tck/util/key_utils.py, tck/handlers/account.py	TopicMessageInfoParams is added with topicId, queryPayment, and maxQueryPayment. TopicInfoResponse, CustomFeeResponse, and FixedFeeResponse are added. key_to_string is added and account key output switches to it.
getTopicInfo RPC handler tck/handlers/topic.py	getTopicInfo builds and executes TopicInfoQuery, then maps TopicInfo fields to TopicInfoResponse covering keys, durations, running hash, fee-exempt keys, custom fees, and ledgerId.
Tests and example updated tests/unit/topic_info_test.py, tests/unit/topic_info_query_test.py, tests/integration/topic_*.py, examples/consensus/topic_info.py	Unit test fixtures wrap proto in ConsensusGetTopicInfoResponse; topic_id is added to TopicInfo constructions; query tests replace the ValueError check with a None topic-id proto assertion. Integration tests replace _to_proto() admin key comparisons with isinstance(PublicKey) + to_bytes_raw(). The example is updated to match the new constructor and proto builder.

Estimated code review effort: 3 (Moderate) | ~25 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Out of Scope Changes check	⚠️ Warning	Most changes fit the topic-info work, but tck/handlers/account.py changes GetAccountInfoResponse serialization and is unrelated to #2394.	Move the account handler serialization refactor into a separate PR unless it is required as supporting work for getTopicInfo.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: adding getTopicInfo to TCK.
Description check	✅ Passed	The description is related to the changeset and mentions the new getTopicInfo method and TopicInfoQuery updates.
Linked Issues check	✅ Passed	The PR appears to implement #2394 by adding getTopicInfo and the related query/response plumbing for TopicInfoQuery.
Docstring Coverage	✅ Passed	Docstring coverage is 80.49% which is sufficient. The required threshold is 80.00%.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 7

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: e34349a6-aa3a-46ec-b62f-cf8af31a0bae

📥 Commits

Reviewing files that changed from the base of the PR and between 2f1705a and 7e59016.

📒 Files selected for processing (13)

• examples/consensus/topic_info.py
• src/hiero_sdk_python/consensus/topic_info.py
• src/hiero_sdk_python/query/topic_info_query.py
• tck/handlers/account.py
• tck/handlers/topic.py
• tck/param/topic.py
• tck/response/topic.py
• tck/util/key_utils.py
• tests/integration/topic_create_transaction_e2e_test.py
• tests/integration/topic_info_query_e2e_test.py
• tests/integration/topic_update_transaction_e2e_test.py
• tests/unit/topic_info_query_test.py
• tests/unit/topic_info_test.py

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/hiero_sdk_python/consensus/topic_info.py (1)

69-80: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Align the constructor contract with the new SDK wrapper types.

These fields are now stored and parsed as AccountId / generic Key, but the public __init__ surface still advertises AccountID / PublicKey. That incorrectly narrows valid topic key shapes and leaves the SDK model out of sync with what _from_proto() returns.

Suggested fix

-        auto_renew_account: AccountID | None,
+        auto_renew_account: AccountId | None,
...
-        fee_schedule_key: PublicKey | None,
-        fee_exempt_keys: list[PublicKey] | None,
+        fee_schedule_key: Key | None,
+        fee_exempt_keys: list[Key] | None,

As per path instructions, proto message fields should use the corresponding SDK wrapper class in the SDK surface.

Source: Path instructions

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: fb542e36-c8a2-45c2-9ccc-99872ebe7e33

📥 Commits

Reviewing files that changed from the base of the PR and between ed72b5d and 3a597fe.

📒 Files selected for processing (3)

• examples/consensus/topic_info.py
• src/hiero_sdk_python/consensus/topic_info.py
• tck/handlers/topic.py

[coderabbitai]

Actionable comments posted: 3

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/hiero_sdk_python/consensus/topic_info.py (1)

45-49: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Type-hint mismatch: auto_renew_account/fee_schedule_key still typed for the old protobuf/PublicKey types.

This diff switches the stored attribute types to SDK types but leaves the constructor parameter type hints stale:

• Line 77: self.auto_renew_account: AccountId | None = auto_renew_account, but the __init__ parameter (line 45) is still typed auto_renew_account: AccountID | None (the raw protobuf type, imported at line 20). _from_proto now passes AccountId._from_proto(...) (SDK type), not AccountID.
• Line 79: self.fee_schedule_key: Key = fee_schedule_key declares a required Key, but the parameter (line 47) is still fee_schedule_key: PublicKey | None (optional, wrong type name). _from_proto populates this via Key.from_proto_key(...), which can be None.
• Same stale PublicKey typing applies to fee_exempt_keys: list[PublicKey] | None (line 48) vs. the actual list[Key] produced by _from_proto and stored at line 80.

These inconsistencies will mislead type checkers/IDE users of this public class.

🩹 Proposed fix

         auto_renew_period: Duration | None,
-        auto_renew_account: AccountID | None,
+        auto_renew_account: AccountId | None,
         ledger_id: bytes | None,
-        fee_schedule_key: PublicKey | None,
-        fee_exempt_keys: list[PublicKey] | None,
+        fee_schedule_key: Key | None,
+        fee_exempt_keys: list[Key] | None,
         custom_fees: list[CustomFixedFee] | None,
     ) -> None:
...
-        self.fee_schedule_key: Key = fee_schedule_key
+        self.fee_schedule_key: Key | None = fee_schedule_key

Also update the docstring (Args: block) and remove the now-unused AccountID/PublicKey imports if no longer referenced elsewhere in the signature.

As per path instructions for src/hiero_sdk_python/**/*.py, "Check that each SDK field type correctly represents the proto type" and flag any SDK attribute referencing a mismatched type.

Also applies to: 69-84

Source: Path instructions

♻️ Duplicate comments (1)

src/hiero_sdk_python/query/topic_info_query.py (1)

88-94: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Client-side topic_id validation removed from _make_request().

This drops the previous guard that rejected a missing topic_id before sending the query, matching a concern already raised in a prior review round (still unresolved in this revision). A TopicInfoQuery with no topic_id set will now silently produce a ConsensusGetTopicInfoQuery without topicID and round-trip to the network instead of failing fast locally.

This appears intentional to let the TCK's getTopicInfo handler exercise "missing topicId" as a server-side negative-path scenario (see tck/handlers/topic.py's if params.topicId is not None: query.set_topic_id(...)), and is covered by a new unit test (test_topic_id_not_set_when_none). However, it also changes behavior for any general SDK caller who constructs TopicInfoQuery() and calls .execute() without ever setting topic_id — they now pay for a network round trip and get a less specific error instead of an immediate client-side ValueError.

Please confirm this is an intentional, permanent contract change (not just an oversight retained from the TCK requirement) since Query path instructions treat identifier validation in _make_request() as a MUST.

As per path instructions, "_make_request() MUST: Validate all required identifiers (accountId, tokenId, topicId, etc.)".

Source: Path instructions

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: ff1068d5-0578-4f14-b29d-6133291d97bc

📥 Commits

Reviewing files that changed from the base of the PR and between 3a597fe and 97e741b.

📒 Files selected for processing (13)

• examples/consensus/topic_info.py
• src/hiero_sdk_python/consensus/topic_info.py
• src/hiero_sdk_python/query/topic_info_query.py
• tck/handlers/account.py
• tck/handlers/topic.py
• tck/param/topic.py
• tck/response/topic.py
• tck/util/key_utils.py
• tests/integration/topic_create_transaction_e2e_test.py
• tests/integration/topic_info_query_e2e_test.py
• tests/integration/topic_update_transaction_e2e_test.py
• tests/unit/topic_info_query_test.py
• tests/unit/topic_info_test.py