Skip to content

feat: Add RejctToken to TCK#2396

Closed
aceppaluni wants to merge 3 commits into
hiero-ledger:mainfrom
aceppaluni:rejecttoken
Closed

feat: Add RejctToken to TCK#2396
aceppaluni wants to merge 3 commits into
hiero-ledger:mainfrom
aceppaluni:rejecttoken

Conversation

@aceppaluni

Copy link
Copy Markdown
Contributor

Description:

This PR adds support for the rejctToken TCK method

  • Added the RPC handler
  • Added the corresponding response class
  • Added a new dataclass

Related issue(s):

Fixes #2365

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: aceppaluni <aceppaluni@gmail.com>
@aceppaluni aceppaluni added skill: intermediate requires some knowledge of the codebase with some defined steps to implement or examples scope: TCK involves engineering for the implementation of TCK method and module labels Jun 30, 2026
@github-actions github-actions Bot added approved Issue has been approved by team member skill: advanced requires knowledge of multiple areas in the codebase without defined steps to implement or examples labels Jun 30, 2026
@aceppaluni
aceppaluni marked this pull request as ready for review June 30, 2026 20:16
@aceppaluni
aceppaluni requested a review from a team as a code owner June 30, 2026 20:16
@aceppaluni
aceppaluni requested a review from nadineloepfe June 30, 2026 20:16
@aceppaluni aceppaluni removed skill: intermediate requires some knowledge of the codebase with some defined steps to implement or examples approved Issue has been approved by team member labels Jun 30, 2026
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: ef8060c8-28cc-4580-b0a4-a99773d59a06

📥 Commits

Reviewing files that changed from the base of the PR and between 1af88ec and ff7cb5c.

📒 Files selected for processing (1)
  • tck/response/token.py

Walkthrough

Adds the RejectTokenResponse dataclass to represent the status-only response payload for the rejectToken endpoint.

Changes

rejectToken RPC support

Layer / File(s) Summary
RejectTokenResponse model
tck/response/token.py
Adds RejectTokenResponse as a dataclass subclass of StatusOnlyResponse with endpoint documentation.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The linked issue requires handler, param, response, and tests, but the summary shows only a new response class. Add the rejectToken handler, token-reject param dataclass, and tests against hiero-sdk-tck, then verify the response model still matches the spec.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and matches the PR's TCK rejectToken work, despite the typo.
Description check ✅ Passed The description is related to the rejectToken TCK change and its intended components.
Out of Scope Changes check ✅ Passed No unrelated or clearly out-of-scope changes are evident in the provided summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
📋 Issue Planner

Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).

View plan for ticket: #2365

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: e27c551e-4a60-47f9-b83c-243aaeffad2e

📥 Commits

Reviewing files that changed from the base of the PR and between 07be7f6 and 781138e.

📒 Files selected for processing (3)
  • tck/handlers/token.py
  • tck/param/token.py
  • tck/response/token.py

Comment thread tck/handlers/token.py Outdated
Comment thread tck/param/token.py Outdated
@aceppaluni
aceppaluni requested a review from manishdait June 30, 2026 20:21
@aceppaluni aceppaluni added reviewer: maintainer PR needs a review from the maintainer team reviewer: committer request review help from a committer open to community review PR is open for community review and feedback labels Jun 30, 2026
@github-actions github-actions Bot added the queue:junior-committer PR awaiting initial quality review label Jun 30, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

Hello, this is the OfficeHourBot.

This is a reminder that the Hiero Python SDK Office Hours will begin in approximately 2 hours and 57 minutes (14:00 UTC).

This session provides an opportunity to ask questions regarding this Pull Request.

Details:

Disclaimer: This is an automated reminder. Please verify the schedule here for any changes.

From,
The Python SDK Team

Comment thread tck/handlers/token.py Outdated
Comment thread tck/handlers/token.py Outdated
Comment thread tck/handlers/token.py Outdated
@prajeeta15
prajeeta15 self-requested a review July 1, 2026 18:17
Signed-off-by: aceppaluni <aceppaluni@gmail.com>
@github-actions github-actions Bot added the approved Issue has been approved by team member label Jul 1, 2026
@aceppaluni aceppaluni removed the approved Issue has been approved by team member label Jul 1, 2026
manishdait
manishdait previously approved these changes Jul 1, 2026

@danielmarv danielmarv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM!

@github-actions github-actions Bot added queue:committers PR awaiting committer technical review and removed queue:junior-committer PR awaiting initial quality review labels Jul 1, 2026
@manishdait manishdait added the status: update branch developer needs to click update branch label Jul 10, 2026
@manishdait

Copy link
Copy Markdown
Contributor

@aceppaluni please update the branch

@exploreriii exploreriii left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request some quick fixes :)

Comment thread tck/handlers/token.py Outdated
Comment thread tck/param/token.py Outdated
Comment thread tck/param/token.py Outdated
@exploreriii
exploreriii marked this pull request as draft July 10, 2026 10:51
@exploreriii exploreriii removed reviewer: maintainer PR needs a review from the maintainer team status: update branch developer needs to click update branch reviewer: committer request review help from a committer queue:committers PR awaiting committer technical review open to community review PR is open for community review and feedback labels Jul 10, 2026
@aceppaluni
aceppaluni marked this pull request as ready for review July 15, 2026 15:39
Signed-off-by: aceppaluni <113948612+aceppaluni@users.noreply.github.com>
@github-actions github-actions Bot added approved Issue has been approved by team member open to community review PR is open for community review and feedback queue:committers PR awaiting committer technical review labels Jul 15, 2026
@aceppaluni

Copy link
Copy Markdown
Contributor Author

Closing due to bad rebase. Will open fresh PR

@aceppaluni aceppaluni closed this Jul 15, 2026
@aceppaluni aceppaluni mentioned this pull request Jul 15, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Issue has been approved by team member open to community review PR is open for community review and feedback queue:committers PR awaiting committer technical review scope: TCK involves engineering for the implementation of TCK method and module skill: advanced requires knowledge of multiple areas in the codebase without defined steps to implement or examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add rejectToken method to tck module

5 participants