feat(tck): implement dissociateToken JSON-RPC method#2450
Conversation
Add DissociateTokenParams, DissociateTokenResponse, and the dissociateToken RPC method handler, mirroring the existing associateToken pattern. Fixes hiero-ledger#2418 Signed-off-by: iron-prog <dt915725@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThe TCK server adds the ChangesDissociate token RPC
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant Client
participant dissociate_token
participant TokenDissociateTransaction
participant HederaNetwork
Client->>dissociate_token: dissociateToken(params)
dissociate_token->>TokenDissociateTransaction: build with accountId and tokenIds
dissociate_token->>TokenDissociateTransaction: apply commonTransactionParams
TokenDissociateTransaction->>HederaNetwork: execute without waiting for receipt
HederaNetwork-->>dissociate_token: transaction receipt status
dissociate_token-->>Client: DissociateTokenResponse(status)
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
📋 Issue PlannerBuilt with CodeRabbit's Coding Plans for faster development and fewer bugs. View plan used: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
👋 Hi @iron-prog! Great work completing a Beginner issue! 🎉 Thanks for your contribution! 🚀 Here are some issues you might want to explore next: 🌟 Stay connected: Happy coding! 🚀 |
Description
Add support for the
dissociateTokenTCK JSON-RPC method by mirroring theexisting
associateTokenimplementation.DissociateTokenParamsDissociateTokenResponsedissociateTokenJSON-RPC handler usingTokenDissociateTransactionRelated issue(s)
Fixes #2418
Notes for reviewer
associateTokenhandler.commonTransactionParamsflow.Checklist