Skip to content

feat: implement endpoint for deleteTopic method#2451

Merged
MonaaEid merged 4 commits into
hiero-ledger:mainfrom
MonaaEid:feat/2404-deleteTopic-tck
Jul 18, 2026
Merged

feat: implement endpoint for deleteTopic method#2451
MonaaEid merged 4 commits into
hiero-ledger:mainfrom
MonaaEid:feat/2404-deleteTopic-tck

Conversation

@MonaaEid

Copy link
Copy Markdown
Contributor

Description:
This PR introduces a new JSON-RPC endpoint in the TCK to support the deleteTopic method.

Related issue(s):

Fixes #2404

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: MonaaEid <monaa_eid@hotmail.com>
@github-actions github-actions Bot added approved Issue has been approved by team member lang: python Uses Python programming language scope: TCK involves engineering for the implementation of TCK method and module skill: advanced requires knowledge of multiple areas in the codebase without defined steps to implement or examples labels Jul 18, 2026
@MonaaEid MonaaEid closed this Jul 18, 2026
@MonaaEid
MonaaEid force-pushed the feat/2404-deleteTopic-tck branch from 3811e2d to 2953918 Compare July 18, 2026 12:40
Signed-off-by: MonaaEid <monaa_eid@hotmail.com>
@MonaaEid MonaaEid reopened this Jul 18, 2026
@MonaaEid
MonaaEid marked this pull request as ready for review July 18, 2026 12:49
@MonaaEid
MonaaEid requested a review from a team as a code owner July 18, 2026 12:49
@MonaaEid
MonaaEid requested review from Copilot and exploreriii and removed request for Copilot July 18, 2026 12:49
@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@MonaaEid, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 38 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: f2a27ccb-1ab2-4a92-a387-c0fecf77b7df

📥 Commits

Reviewing files that changed from the base of the PR and between 7d234ed and 22f484d.

📒 Files selected for processing (1)
  • tck/param/topic.py

Walkthrough

Adds the deleteTopic JSON-RPC endpoint with validated topic parameters, a status-only response type, and transaction execution that returns the receipt status.

Changes

Topic deletion endpoint

Layer / File(s) Summary
Delete-topic request and response contract
tck/param/topic.py, tck/response/topic.py
Adds DeleteTopicParams with required string validation for topicId and adds DeleteTopicResponse as a status-only response type.
Delete-topic transaction handler
tck/handlers/topic.py
Registers deleteTopic, configures and executes TopicDeleteTransaction, validates the receipt, and returns the mapped response status.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the main change: adding the deleteTopic endpoint.
Description check ✅ Passed The description matches the changeset and says this PR adds a deleteTopic JSON-RPC endpoint.
Linked Issues check ✅ Passed The PR implements the requested deleteTopic endpoint with params, handler, and response types.
Out of Scope Changes check ✅ Passed The changes stay focused on deleteTopic endpoint support with no obvious unrelated additions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
📋 Issue Planner

Built with CodeRabbit's Coding Plans for faster development and fewer bugs.

View plan used: #2404

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 02cc9241-47c7-43b5-a8b9-cf7d33c55e6c

📥 Commits

Reviewing files that changed from the base of the PR and between 69eec2a and 7d234ed.

📒 Files selected for processing (3)
  • tck/handlers/topic.py
  • tck/param/topic.py
  • tck/response/topic.py

Comment thread tck/handlers/topic.py
Comment thread tck/handlers/topic.py
Comment thread tck/param/topic.py Outdated
Comment thread tck/param/topic.py
Signed-off-by: MonaaEid <monaa_eid@hotmail.com>
Copilot AI review requested due to automatic review settings July 18, 2026 13:10
@github-actions github-actions Bot added the skill: beginner Achievable by a fairly new comer that has already completed a couple of good first issues label Jul 18, 2026
@MonaaEid
MonaaEid removed the request for review from Copilot July 18, 2026 13:11
@MonaaEid MonaaEid removed the skill: advanced requires knowledge of multiple areas in the codebase without defined steps to implement or examples label Jul 18, 2026
@github-actions github-actions Bot added open to community review PR is open for community review and feedback queue:committers PR awaiting committer technical review labels Jul 18, 2026

@manishdait manishdait left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@github-actions github-actions Bot added the status: ready-to-merge PR has 1+ maintainer and 2+ total approvals, ready to merge label Jul 18, 2026
@github-actions github-actions Bot removed the queue:committers PR awaiting committer technical review label Jul 18, 2026
@MonaaEid
MonaaEid merged commit 832a5e9 into hiero-ledger:main Jul 18, 2026
11 checks passed
@github-actions

Copy link
Copy Markdown

@MonaaEid
MonaaEid deleted the feat/2404-deleteTopic-tck branch July 18, 2026 16:38
@MonaaEid MonaaEid added this to the v0.2.9 milestone Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Issue has been approved by team member lang: python Uses Python programming language open to community review PR is open for community review and feedback scope: TCK involves engineering for the implementation of TCK method and module skill: beginner Achievable by a fairly new comer that has already completed a couple of good first issues status: ready-to-merge PR has 1+ maintainer and 2+ total approvals, ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TCK: Implement endpoint for deleteTopic

3 participants