feat: Update PublicKey To Key In Node Create And Update#2457
Conversation
Signed-off-by: aceppaluni <aceppaluni@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #2457 +/- ##
==========================================
+ Coverage 95.01% 95.03% +0.01%
==========================================
Files 164 164
Lines 10464 10464
==========================================
+ Hits 9942 9944 +2
+ Misses 522 520 -2 🚀 New features to boost your workflow:
|
WalkthroughNode create and update transactions now accept ChangesNode admin key support
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant KeyInput
participant NodeTransaction
participant TransactionBody
KeyInput->>NodeTransaction: set_admin_key(Key)
NodeTransaction->>KeyInput: to_proto_key()
NodeTransaction->>TransactionBody: serialize admin_key
TransactionBody->>NodeTransaction: provide admin_key
NodeTransaction->>KeyInput: Key.from_proto_key()
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
📋 Issue PlannerBuilt with CodeRabbit's Coding Plans for faster development and fewer bugs. View plan used: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: aceppaluni <aceppaluni@gmail.com>
|
@aceppaluni, please rebase the branch |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: f45a0ebb-9d42-458c-a8e8-dcb6366d0eb9
📒 Files selected for processing (2)
tests/unit/node_create_transaction_test.pytests/unit/node_update_transaction_test.py
|
👋 Hi @aceppaluni! Great work completing a Intermediate issue! 🎉 Thanks for your contribution! 🚀 Here are some issues you might want to explore next:
🌟 Stay connected: Happy coding! 🚀 |
Description:
This PR updates node create/update to use Key instead of PublicKey as per issue #2337.
Related issue(s):
Fixes #2337
Notes for reviewer:
Checklist