feat: Add ```UpdateToken``` by aceppaluni · Pull Request #2474 · hiero-ledger/hiero-sdk-python

aceppaluni · 2026-07-22T19:01:30Z

Description:

Implements the updateToken JSON-RPC endpoint in the TCK module by adding the required parameter, response, and handler layers following the existing token transaction conventions.

The new endpoint integrates through the existing @rpc_method registration flow and does not require any server, protocol, or handler registration changes.

Changes

Parameter layer

Added UpdateTokenParams in tck/param/token.py.
Added support for all TokenUpdateTransaction fields exposed by the TCK surface:
- tokenId
- token metadata fields (name, symbol, memo, metadata)
- account fields (treasuryAccountId, autoRenewAccountId)
- key fields (adminKey, kycKey, freezeKey, wipeKey, supplyKey, feeScheduleKey, pauseKey, metadataKey)
- lifecycle fields (expirationTime, autoRenewPeriod)
Kept key, expiration, and auto-renew values as raw strings in params, matching existing createToken conventions and deferring conversion to the handler layer.
Intentionally omitted keyVerificationMode to align with the resolved TCK parameter surface.

Response layer

Added UpdateTokenResponse as a StatusOnlyResponse.
Matches existing status-only token transaction responses such as DeleteTokenResponse, FreezeTokenResponse, and PauseTokenResponse.

Handler layer

Added TokenUpdateTransaction support.
Added _build_update_token_transaction() to construct update transactions with:
- default gRPC timeout configuration
- conditional setter application only for provided fields
- existing TCK conversion conventions for IDs, keys, timestamps, and durations
Added the updateToken RPC handler:
- retrieves the client from the session
- applies common transaction parameters
- executes without waiting for receipt
- validates the receipt status
- returns the mapped ResponseCode

Related issue(s):

Fixes #2397

Notes for reviewer:

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

Signed-off-by: aceppaluni <aceppaluni@gmail.com>

coderabbitai · 2026-07-22T19:05:12Z

Walkthrough

Adds the updateToken RPC endpoint to the TCK module, including request parsing, token update transaction construction, transaction execution, receipt validation, and status response modeling. It also adjusts token transaction proto handling and key validation.

Changes

Token Update RPC

Layer / File(s)	Summary
Update token request and response contracts `tck/param/token.py`, `tck/response/token.py`	Adds `UpdateTokenParams` with token fields and JSON-RPC parsing, plus the `UpdateTokenResponse` status payload.
Update token transaction execution `tck/handlers/token.py`	Builds and executes `TokenUpdateTransaction`, applies common transaction parameters, validates the receipt, and returns the response status.
Transaction and key validation updates `src/hiero_sdk_python/tokens/token_update_transaction.py`, `tests/unit/token_update_transaction_test.py`, `tck/handlers/key.py`	Allows proto construction without a token ID, updates the related unit test, and changes threshold/list key validation for `None` values.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Client
  participant update_token
  participant TokenUpdateTransaction
  participant HederaNetwork
  Client->>update_token: UpdateTokenParams
  update_token->>TokenUpdateTransaction: Build update fields
  update_token->>TokenUpdateTransaction: Execute transaction
  TokenUpdateTransaction->>HederaNetwork: Submit token update
  HederaNetwork-->>update_token: Receipt status
  update_token-->>Client: UpdateTokenResponse

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly refers to the new UpdateToken feature and matches the main change.
Description check	✅ Passed	The description accurately summarizes the new updateToken endpoint and supporting changes.
Linked Issues check	✅ Passed	The PR adds the updateToken handler plus the required params and response types requested by `#2397`.
Out of Scope Changes check	✅ Passed	The modified files all support the updateToken work or its tests, with no clearly unrelated additions.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📋 Issue Planner

Built with CodeRabbit's Coding Plans for faster development and fewer bugs.

View plan used: #2397

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 71fedbdb-d60d-489d-b015-8e667cf0ac3e

📥 Commits

Reviewing files that changed from the base of the PR and between 3b976da and 42d17d4.

📒 Files selected for processing (3)

tck/handlers/token.py
tck/param/token.py
tck/response/token.py

Signed-off-by: aceppaluni <aceppaluni@gmail.com>

manishdait

@aceppaluni, small change request, rest looks good

Signed-off-by: aceppaluni <aceppaluni@gmail.com>

github-actions · 2026-07-23T16:06:13Z

Hi, this is WorkflowBot.
Your pull request cannot be merged as it is not passing all our workflow checks.
Please click on each check to review the logs and resolve issues so all checks pass.
To help you:

DCO signing guide
Merge conflicts guide
Rebase guide
Testing guide
Discord
Community Calls
Thank you for contributing!
From the Hiero Python SDK Team

Signed-off-by: aceppaluni <aceppaluni@gmail.com>

codecov · 2026-07-23T16:29:23Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main    #2474      +/-   ##
==========================================
- Coverage   95.27%   95.27%   -0.01%     
==========================================
  Files         164      164              
  Lines       10485    10483       -2     
==========================================
- Hits         9990     9988       -2     
  Misses        495      495

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

coderabbitai

Actionable comments posted: 2

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 783b78c3-a3b8-4917-8b0e-df896113678f

📥 Commits

Reviewing files that changed from the base of the PR and between 847235b and e6f2f88.

📒 Files selected for processing (3)

src/hiero_sdk_python/tokens/token_update_transaction.py
tck/handlers/key.py
tests/unit/token_update_transaction_test.py

manishdait

lgtm

exploreriii · 2026-07-23T17:51:45Z

update plz @aceppaluni

github-actions · 2026-07-23T21:34:57Z

👋 Hi @aceppaluni! Great work completing a Advanced issue! 🎉

Thanks for your contribution! 🚀

Here are some issues you might want to explore next:

🌟 Stay connected:

Happy coding! 🚀
— Hiero Python SDK Team

feat: Add UpdateToken

42d17d4

Signed-off-by: aceppaluni <aceppaluni@gmail.com>

aceppaluni requested a review from a team as a code owner July 22, 2026 19:01

aceppaluni requested a review from MonaaEid July 22, 2026 19:01

github-actions Bot assigned MonaaEid Jul 22, 2026

github-actions Bot added approved Issue has been approved by team member scope: TCK involves engineering for the implementation of TCK method and module skill: advanced requires knowledge of multiple areas in the codebase without defined steps to implement or examples labels Jul 22, 2026

coderabbitai Bot reviewed Jul 22, 2026

View reviewed changes

Comment thread tck/handlers/token.py Outdated

aceppaluni added reviewer: maintainer PR needs a review from the maintainer team reviewer: committer request review help from a committer and removed approved Issue has been approved by team member labels Jul 22, 2026

aceppaluni requested a review from manishdait July 22, 2026 19:08

github-actions Bot assigned manishdait Jul 22, 2026

github-actions Bot added open to community review PR is open for community review and feedback queue:junior-committer PR awaiting initial quality review labels Jul 22, 2026

fix: Token Handler

847235b

Signed-off-by: aceppaluni <aceppaluni@gmail.com>

github-actions Bot added the approved Issue has been approved by team member label Jul 22, 2026

exploreriii previously approved these changes Jul 22, 2026

View reviewed changes

Merge branch 'main' into updatetoken

e041fcb

github-actions Bot added queue:committers PR awaiting committer technical review and removed queue:junior-committer PR awaiting initial quality review labels Jul 22, 2026

manishdait requested changes Jul 23, 2026

View reviewed changes

Comment thread tck/handlers/token.py

Comment thread tck/handlers/token.py

fix: Apply Change To UpdateTransaction and Key

c2433f1

Signed-off-by: aceppaluni <aceppaluni@gmail.com>

aceppaluni dismissed exploreriii’s stale review via c2433f1 July 23, 2026 16:04

aceppaluni requested a review from a team as a code owner July 23, 2026 16:04

aceppaluni requested a review from parvninama July 23, 2026 16:04

fix: UpdateTokenTransaction Test

e6f2f88

Signed-off-by: aceppaluni <aceppaluni@gmail.com>

coderabbitai Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread src/hiero_sdk_python/tokens/token_update_transaction.py

Comment thread tck/handlers/key.py

aceppaluni requested review from exploreriii and manishdait July 23, 2026 16:45

github-actions Bot added queue:junior-committer PR awaiting initial quality review and removed queue:committers PR awaiting committer technical review labels Jul 23, 2026

manishdait approved these changes Jul 23, 2026

View reviewed changes

exploreriii approved these changes Jul 23, 2026

View reviewed changes

github-actions Bot added status: ready-to-merge PR has 1+ maintainer and 2+ total approvals, ready to merge and removed queue:junior-committer PR awaiting initial quality review labels Jul 23, 2026

Merge branch 'main' into updatetoken

4fbfbad

aceppaluni merged commit 2679cb5 into hiero-ledger:main Jul 23, 2026
28 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Add `UpdateToken` #2474

feat: Add `UpdateToken` #2474
aceppaluni merged 6 commits into
hiero-ledger:mainfrom
aceppaluni:updatetoken

aceppaluni commented Jul 22, 2026

Uh oh!

coderabbitai Bot commented Jul 22, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

manishdait left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 23, 2026

Uh oh!

codecov Bot commented Jul 23, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

manishdait left a comment

Uh oh!

exploreriii commented Jul 23, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

aceppaluni commented Jul 22, 2026

Changes

Parameter layer

Response layer

Handler layer

Uh oh!

coderabbitai Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

manishdait left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 23, 2026

Uh oh!

codecov Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

manishdait left a comment

Choose a reason for hiding this comment

Uh oh!

exploreriii commented Jul 23, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai Bot commented Jul 22, 2026 •

edited

Loading

codecov Bot commented Jul 23, 2026 •

edited

Loading