Skip to content

fix: allow credentialed public CORS #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarcStdt merged 1 commit into from
May 31, 2026
+14 −6
Merged

fix: allow credentialed public CORS #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions apps/druid/adapters/http/handlers/routes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,11 @@ func RegisterPublicRoutes(app *fiber.App, handlers RouteHandlers) {
authorizer = handlers.Server.ScrollHandler.authorizer
}
app.Use(cors.New(cors.Config{
AllowOrigins: "*",
AllowMethods: "GET,POST,PUT,DELETE,PATCH,OPTIONS,HEAD,PROPFIND,MOVE,MKCOL,COPY",
AllowHeaders: "Origin,Content-Type,Accept,Authorization,X-Requested-With,Cache-Control,DNT,Keep-Alive,User-Agent,If-Modified-Since,Depth,Destination,Overwrite,If,Lock-Token,Timeout,Dav",
ExposeHeaders: "Druid-Version",
AllowOrigins: "https://app.druid.gg,http://localhost:3000,http://127.0.0.1:3000",
AllowMethods: "GET,POST,PUT,DELETE,PATCH,OPTIONS,HEAD,PROPFIND,MOVE,MKCOL,COPY",
AllowHeaders: "Origin,Content-Type,Accept,Authorization,X-Requested-With,Cache-Control,DNT,Keep-Alive,User-Agent,If-Modified-Since,Depth,Destination,Overwrite,If,Lock-Token,Timeout,Dav",
AllowCredentials: true,
ExposeHeaders: "Druid-Version",
}))
app.Get("/health", handlers.Server.GetHealthAuth)
app.Get("/.well-known/jwks.json", RuntimeJWKS(authorizer))
Expand Down
7 changes: 5 additions & 2 deletions apps/druid/adapters/http/handlers/routes_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,11 @@ func TestPublicRoutesAnswerCorsPreflight(t *testing.T) {
if resp.StatusCode != http.StatusNoContent {
t.Fatalf("preflight status = %d, want 204", resp.StatusCode)
}
if got := resp.Header.Get("Access-Control-Allow-Origin"); got != "*" {
t.Fatalf("allow origin = %q, want *", got)
if got := resp.Header.Get("Access-Control-Allow-Origin"); got != "http://127.0.0.1:3000" {
t.Fatalf("allow origin = %q, want request origin", got)
}
if got := resp.Header.Get("Access-Control-Allow-Credentials"); got != "true" {
t.Fatalf("allow credentials = %q, want true", got)
}
}

Expand Down
2 changes: 2 additions & 0 deletions config/helm-charts/druid-cli/chart_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ func TestChartRendersDefaultAndCustomValues(t *testing.T) {
"runtime.example.test",
"name: public",
"nginx.ingress.kubernetes.io/enable-cors",
"nginx.ingress.kubernetes.io/cors-allow-origin",
"nginx.ingress.kubernetes.io/cors-allow-credentials",
"storageClassName: \"local-path\"",
} {
if !strings.Contains(customManifest, want) {
Expand Down
2 changes: 2 additions & 0 deletions config/helm-charts/druid-cli/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ ingress:
className: nginx
annotations:
nginx.ingress.kubernetes.io/enable-cors: "true"
nginx.ingress.kubernetes.io/cors-allow-origin: "https://app.druid.gg"
nginx.ingress.kubernetes.io/cors-allow-credentials: "true"
nginx.ingress.kubernetes.io/cors-allow-methods: "GET, PUT, POST, DELETE, PATCH, OPTIONS, PROPFIND, MOVE, MKCOL, COPY"
nginx.ingress.kubernetes.io/cors-allow-headers: "DNT,X-CustomHeader,Keep-Alive,User-Agent,X-Requested-With,If-Modified-Since,Cache-Control,Content-Type,Authorization,depth,destination,overwrite,if,lock-token,timeout,dav"
nginx.ingress.kubernetes.io/cors-expose-headers: "Druid-Version"
Expand Down
Loading