fix(rust): recognize escaped backslash and quote in char literals#4417
Open
sarathfrancis90 wants to merge 1 commit into
Open
fix(rust): recognize escaped backslash and quote in char literals#4417sarathfrancis90 wants to merge 1 commit into
sarathfrancis90 wants to merge 1 commit into
Conversation
The Rust char-literal mode listed the escapes \' , \w, \xNN, \uNNNN and \UNNNNNNNN but not the backslash escape \\ (nor \"). A char literal such as '\\' was therefore parsed as a stray backslash followed by an escaped closing quote, so the literal never terminated and every subsequent line was highlighted as a string. Add \\ and " to the char.escape alternation so '\\' and '\"' are matched as complete escapes and the literal closes correctly. Fixes highlightjs#4351
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4351
Changes
The Rust char-literal mode listed the escapes
\',\w,\xNN,\uNNNNand\UNNNNNNNN, but not the backslash escape\\(or\"). So a literal like'\\'was read as a lone backslash followed by an escaped closing quote — the literal never terminated and everything after it on the line/file was highlighted as a string.I added
\\and"to thechar.escapealternation so'\\'and'\"'are matched as complete escapes and the literal closes correctly. No other Rust cases are affected.Checklist
test/markup/rust/strings.txtwith'\\','\''and a line of code after a backslash char literal to prove highlighting no longer leaks)CHANGES.md