fix(types): resolve all 63 mypy strict mode errors across 19 files

- Fixed callable -> Callable[..., Any] in core/registry.py
- Added type arguments to all generic types (dict, list, Callable)
- Fixed Liskov violation: BasePlanner returns AssessmentPlan not list[dict]
- Made AgentContext ai_client/repository optional to match actual usage
- Fixed RulePlanner kwarg passing bug (repository passed as ai_client)
- Fixed knowledge_graph graph.py return types (int cast)
- Added proper type annotations to CLI commands.py
- Fixed TUI App typing with Generic type parameter
- Cleaned up all agent list/dict type annotations
- Removed continue-on-error from CI mypy job

Author: bot

.github/workflows/ci.yml

@@ -39,7 +39,6 @@ jobs:
         run: uv sync --all-extras
       - name: Run mypy
         run: uv run mypy bugfinder/ --ignore-missing-imports
-        continue-on-error: true
 
   test:
     name: Test (Python ${{ matrix.python-version }})

bugfinder/agents/api/discover.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+from typing import Any
 from urllib.parse import urljoin, urlparse
 
 import httpx
@@ -45,10 +46,12 @@ async def execute(self) -> AgentResult:
         base_url = base_url.rstrip("/")
 
         headers = {"User-Agent": "BugFinder/0.1.0", "Accept": "application/json"}
-        findings = []
-        assets = []
+        findings: list[dict[str, Any]] = []
+        assets: list[dict[str, Any]] = []
 
-        async with httpx.AsyncClient(timeout=settings.request_timeout, follow_redirects=True, verify=settings.ssl_verify) as client:
+        async with httpx.AsyncClient(
+            timeout=settings.request_timeout, follow_redirects=True, verify=settings.ssl_verify
+        ) as client:
             for path in API_PATTERNS:
                 url = urljoin(base_url, path)
                 parsed = urlparse(url)

bugfinder/agents/base.py

@@ -15,8 +15,8 @@ class AgentContext:
     target_type: str
     scan_id: str
     knowledge_graph: KnowledgeGraph
-    ai_client: NVIDIAClient
-    repository: Repository
+    ai_client: NVIDIAClient | None = None
+    repository: Repository | None = None
     config: dict[str, Any] = field(default_factory=dict)
 
 

bugfinder/agents/recon/dns.py

@@ -47,9 +47,9 @@ async def execute(self) -> AgentResult:
     def _resolve(self, hostname: str, rtype: str) -> list[str]:
         try:
             if rtype == "A":
-                return [r[4][0] for r in socket.getaddrinfo(hostname, 0, socket.AF_INET)]
+                return [str(r[4][0]) for r in socket.getaddrinfo(hostname, 0, socket.AF_INET)]
             if rtype == "AAAA":
-                return [r[4][0] for r in socket.getaddrinfo(hostname, 0, socket.AF_INET6)]
+                return [str(r[4][0]) for r in socket.getaddrinfo(hostname, 0, socket.AF_INET6)]
             return []
         except socket.gaierror:
             return []

bugfinder/agents/recon/tech.py

@@ -1,5 +1,7 @@
 from __future__ import annotations
 
+from typing import Any
+
 import httpx
 
 from bugfinder.agents.base import AgentResult, BaseAgent
@@ -36,11 +38,13 @@ async def execute(self) -> AgentResult:
             url = f"https://{url}"
 
         headers = {"User-Agent": "BugFinder/0.1.0"}
-        technologies = []
-        findings = []
+        technologies: list[dict[str, Any]] = []
+        findings: list[dict[str, Any]] = []
 
         try:
-            async with httpx.AsyncClient(timeout=settings.request_timeout, follow_redirects=True, verify=settings.ssl_verify) as client:
+            async with httpx.AsyncClient(
+                timeout=settings.request_timeout, follow_redirects=True, verify=settings.ssl_verify
+            ) as client:
                 response = await client.get(url, headers=headers)
                 body = response.text.lower()
                 raw_headers = dict(response.headers)

bugfinder/agents/secrets/scan.py

@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 import re
+from typing import Any
 
 import httpx
 
@@ -32,11 +33,13 @@ async def execute(self) -> AgentResult:
             base_url = f"https://{base_url}"
 
         headers = {"User-Agent": "BugFinder/0.1.0"}
-        findings = []
+        findings: list[dict[str, Any]] = []
 
         targets_to_scan = [base_url]
 
-        async with httpx.AsyncClient(timeout=settings.request_timeout, follow_redirects=True, verify=settings.ssl_verify) as client:
+        async with httpx.AsyncClient(
+            timeout=settings.request_timeout, follow_redirects=True, verify=settings.ssl_verify
+        ) as client:
             js_paths = ["/", "/static/js/", "/assets/", "/app.js", "/main.js"]
             for path in js_paths:
                 from urllib.parse import urljoin

bugfinder/agents/web/crawler.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+from typing import Any
 from urllib.parse import urljoin
 
 import httpx
@@ -44,10 +45,12 @@ async def execute(self) -> AgentResult:
         base_url = base_url.rstrip("/")
 
         headers = {"User-Agent": "BugFinder/0.1.0"}
-        findings = []
-        assets = []
+        findings: list[dict[str, Any]] = []
+        assets: list[dict[str, Any]] = []
 
-        async with httpx.AsyncClient(timeout=settings.request_timeout, follow_redirects=True, verify=settings.ssl_verify) as client:
+        async with httpx.AsyncClient(
+            timeout=settings.request_timeout, follow_redirects=True, verify=settings.ssl_verify
+        ) as client:
             try:
                 resp = await client.get(base_url, headers=headers)
                 assets.append(
@@ -76,7 +79,7 @@ async def execute(self) -> AgentResult:
                     summary=f"Crawl failed: {e}",
                 )
 
-            discovered_assets = []
+            discovered_assets: list[dict[str, Any]] = []
             for path in COMMON_PATHS:
                 url = urljoin(base_url, path)
                 try:

bugfinder/agents/web/sqli.py

@@ -35,7 +35,9 @@ async def execute(self) -> AgentResult:
         findings = []
         headers = {"User-Agent": "BugFinder/0.1.0"}
 
-        async with httpx.AsyncClient(timeout=settings.request_timeout, follow_redirects=True, verify=settings.ssl_verify) as client:
+        async with httpx.AsyncClient(
+            timeout=settings.request_timeout, follow_redirects=True, verify=settings.ssl_verify
+        ) as client:
             try:
                 resp = await client.get(base_url, headers=headers)
             except Exception:

bugfinder/agents/web/xss.py

@@ -28,7 +28,9 @@ async def execute(self) -> AgentResult:
         findings = []
         headers = {"User-Agent": "BugFinder/0.1.0"}
 
-        async with httpx.AsyncClient(timeout=settings.request_timeout, follow_redirects=True, verify=settings.ssl_verify) as client:
+        async with httpx.AsyncClient(
+            timeout=settings.request_timeout, follow_redirects=True, verify=settings.ssl_verify
+        ) as client:
             try:
                 resp = await client.get(base_url, headers=headers)
                 content = resp.text.lower()

bugfinder/ai/client.py

@@ -48,7 +48,7 @@ async def chat(
         messages: list[dict[str, str]],
         temperature: float | None = None,
         max_tokens: int | None = None,
-        response_format: dict | None = None,
+        response_format: dict[str, Any] | None = None,
     ) -> dict[str, Any]:
         if not self.api_key:
             msg = "NVIDIA API key not configured. Set BF_NVIDIA_API_KEY or run `bf config nvidia.api_key YOUR_KEY`."
@@ -71,7 +71,8 @@ async def chat(
         try:
             response = await client.post("/chat/completions", json=payload)
             response.raise_for_status()
-            return response.json()
+            data: dict[str, Any] = response.json()
+            return data
         except httpx.HTTPStatusError as e:
             raise NVIDIAError(f"API error: {e.response.status_code} - {e.response.text}") from e
         except httpx.RequestError as e:
@@ -91,7 +92,8 @@ async def chat_text(
             messages.append({"role": "system", "content": system_prompt})
         messages.append({"role": "user", "content": user_prompt})
         result = await self.chat(messages, **kwargs)
-        return result["choices"][0]["message"]["content"]
+        content: str = result["choices"][0]["message"]["content"]
+        return content
 
     async def chat_json(
         self,
@@ -106,7 +108,8 @@ async def chat_json(
             **kwargs,
         )
         try:
-            return json.loads(text)
+            data: dict[str, Any] = json.loads(text)
+            return data
         except json.JSONDecodeError as e:
             raise NVIDIAError(f"Failed to parse JSON response: {e}") from e