HP-2512 Cleaned up BillingRegistryService

src/product/Application/BillingRegistryService.php

@@ -49,19 +49,15 @@ public function getRepresentationsByType(string $representationClass): array
         return $representations;
     }
 
-    public function getTariffDefinitionByName(string $tariffName): ?TariffTypeDefinitionInterface
+    public function getTariffTypeDefinitionByName(string $tariffName): TariffTypeDefinitionInterface
     {
         foreach ($this->registry->getTariffTypeDefinitions() as $tariffTypeDefinition) {
-            if ($tariffName === $tariffTypeDefinition->tariffType()->name) {
+            if ($tariffTypeDefinition->tariffType()->equalsName($tariffName)) {
                 return $tariffTypeDefinition;
             }
         }
-        return null;
-    }
 
-    public function hasBehaviour(TariffTypeDefinitionInterface $tariffTypeDefinition, string $behaviorClassWrapper): bool
-    {
-        return $tariffTypeDefinition->hasBehavior($behaviorClassWrapper);
+        throw new TariffTypeDefinitionNotFoundException('Tariff type definition was not found');
     }
 
     public function createQuantityFormatter(string $type, FractionQuantityData $data): QuantityFormatterInterface {
@@ -157,19 +153,6 @@ public function getAggregate(string $type): AggregateInterface
         throw new AggregateNotFoundException('Aggregate was not found');
     }
 
-    public function findTariffTypeDefinitionByBehavior(BehaviorInterface $behavior): TariffTypeDefinitionInterface
-    {
-        $tariffType = $behavior->getTariffType();
-
-        foreach ($this->registry->getTariffTypeDefinitions() as $tariffTypeDefinition) {
-            if ($tariffTypeDefinition->belongToTariffType($tariffType)) {
-                return $tariffTypeDefinition;
-            }
-        }
-
-        throw new TariffTypeDefinitionNotFoundException('Tariff type definition was not found');
-    }
-
     public function findPriceTypeDefinitionsByBehavior(string $behaviorClassWrapper): \Generator
     {
         foreach ($this->registry->priceTypes() as $priceTypeDefinition) {

src/product/Application/BillingRegistryServiceInterface.php

@@ -2,18 +2,12 @@
 
 namespace hiqdev\php\billing\product\Application;
 
-use Generator;
 use hiqdev\php\billing\product\AggregateInterface;
-use hiqdev\php\billing\product\behavior\BehaviorInterface;
-use hiqdev\php\billing\product\behavior\BehaviorNotFoundException;
-use hiqdev\php\billing\product\behavior\InvalidBehaviorException;
 use hiqdev\php\billing\product\invoice\RepresentationInterface;
-use hiqdev\php\billing\product\price\PriceTypeDefinitionInterface;
 use hiqdev\php\billing\product\quantity\FractionQuantityData;
 use hiqdev\php\billing\product\quantity\QuantityFormatterInterface;
-use hiqdev\php\billing\product\TariffTypeDefinitionInterface;
 
-interface BillingRegistryServiceInterface extends BillingRegistryTariffServiseInterface, BillingRegistryBehaviorServiceInterface
+interface BillingRegistryServiceInterface extends BillingRegistryTariffServiceInterface, BillingRegistryBehaviorServiceInterface
 {
     /**
      * @param string $representationClass
@@ -24,5 +18,4 @@ public function getRepresentationsByType(string $representationClass): array;
     public function createQuantityFormatter(string $type, FractionQuantityData $data): QuantityFormatterInterface;
 
     public function getAggregate(string $type): AggregateInterface;
-
 }

src/product/Application/BillingRegistryTariffServiceInterface.php

@@ -0,0 +1,16 @@
+<?php declare(strict_types=1);
+
+namespace hiqdev\php\billing\product\Application;
+
+use hiqdev\php\billing\product\Exception\TariffTypeDefinitionNotFoundException;
+use hiqdev\php\billing\product\TariffTypeDefinitionInterface;
+
+interface BillingRegistryTariffServiceInterface
+{
+    /**
+     * @param string $tariffName
+     * @return TariffTypeDefinitionInterface
+     * @throws TariffTypeDefinitionNotFoundException
+     */
+    public function getTariffTypeDefinitionByName(string $tariffName): TariffTypeDefinitionInterface;
+}

src/product/invoice/Representation.php

@@ -0,0 +1,39 @@
+<?php declare(strict_types=1);
+
+namespace hiqdev\php\billing\product\invoice;
+
+use hiqdev\php\billing\type\TypeInterface;
+
+/**
+ * This class is made abstract intentionally.
+ * Because you can attach multiple representations, and thus you should distinguish them somehow.
+ * So, please implement you own representation.
+ */
+abstract class Representation implements RepresentationInterface
+{
+    private TypeInterface $type;
+
+    public function __construct(private readonly string $sql)
+    {
+        if (trim($this->sql) === '') {
+            throw new InvalidRepresentationException('Representation SQL cannot be empty.');
+        }
+    }
+
+    public function getSql(): string
+    {
+        return $this->sql;
+    }
+
+    public function setType(TypeInterface $type): RepresentationInterface
+    {
+        $this->type = $type;
+
+        return $this;
+    }
+
+    public function getType(): TypeInterface
+    {
+        return $this->type;
+    }
+}

tests/unit/product/Application/BillingRegistryServiceTest.php

@@ -2,8 +2,6 @@
 
 namespace hiqdev\php\billing\tests\unit\product\Application;
 
-use hiqdev\billing\registry\invoice\InvoiceRepresentation;
-use hiqdev\billing\registry\invoice\PaymentRequestRepresentation;
 use hiqdev\php\billing\product\Application\BillingRegistryService;
 use hiqdev\php\billing\product\behavior\BehaviorNotFoundException;
 use hiqdev\php\billing\product\BillingRegistry;
@@ -15,6 +13,7 @@
 use hiqdev\php\billing\tests\unit\product\behavior\TestBehavior;
 use hiqdev\php\billing\tests\unit\product\Domain\Model\DummyTariffType;
 use hiqdev\php\billing\tests\unit\product\Domain\Model\FakeTariffType;
+use hiqdev\php\billing\tests\unit\product\invoice\TestRepresentation;
 use hiqdev\php\billing\type\Type;
 use PHPUnit\Framework\TestCase;
 
@@ -51,8 +50,8 @@ public function testGetRepresentationsByInterfaceReturnsAllRepresentations(): vo
             ->withPrices()
                 ->priceType(Type::anyId('dummy'))
                     ->documentRepresentation()
-                        ->attach(new InvoiceRepresentation("Invoice"))
-                        ->attach(new PaymentRequestRepresentation("Payment Request"))
+                        ->attach(new TestRepresentation("Invoice"))
+                        ->attach(new TestRepresentation("Payment Request"))
                     ->end()
                 ->end()
             ->end();

tests/unit/product/Application/BillingRegistryTariffServiceTest.php

@@ -38,24 +38,8 @@ public function testGetTariffDefinitionByName(): void
 
         $this->registry->addTariffType($tariffTypeDefinition);
 
-        $tariff = $this->registryService->getTariffDefinitionByName('dummy');
+        $tariff = $this->registryService->getTariffTypeDefinitionByName('dummy');
 
         $this->assertSame($tariffType->name(), $tariff->tariffType()->name());
     }
-
-    public function testCheckBehaviorInTariff(): void
-    {
-        $tariffType = new DummyTariffType();
-        $tariffTypeDefinition = new TariffTypeDefinition($tariffType);
-        $dummyBehavior = new TestBehavior('dummy');
-        $tariffTypeDefinition
-            ->withBehaviors()
-            ->attach($dummyBehavior);
-
-        $this->registry->addTariffType($tariffTypeDefinition);
-
-        $tariff = $this->registryService->getTariffDefinitionByName('dummy');
-        $this->assertTrue($this->registryService->hasBehaviour($tariff, TestBehavior::class));
-    }
-
 }

tests/unit/product/invoice/TestRepresentation.php

@@ -0,0 +1,9 @@
+<?php declare(strict_types=1);
+
+namespace hiqdev\php\billing\tests\unit\product\invoice;
+
+use hiqdev\php\billing\product\invoice\Representation;
+
+class TestRepresentation extends Representation
+{
+}