HP-2433 Add billing-mrdp to the HiAPI CI Pipeline

[VadymHrechukha]

Summary by CodeRabbit

• New Features
  • The sale closing action now returns the updated sale instance, allowing for method chaining and improved usability when closing a sale.

[coderabbitai]

Walkthrough

The changes update the close method in both the Sale class and the SaleInterface interface, altering its return type from void to self. This means the method now returns the current instance of the class after execution. The implementation in the Sale class is adjusted to return $this, while the interface signature is updated to match. No other logic or structural changes are introduced.

Changes

File(s)	Change Summary
src/sale/Sale.php	Modified the close method in the Sale class to return self instead of void, and added a return of $this.
src/sale/SaleInterface.php	Updated the close method signature in the SaleInterface to return self instead of void.

Poem

In the land of sales, a change is nigh,
Now close returns itself—oh my!
A fluent hop, a chaining spree,
The interface and class agree.
With $this in tow, the code’s more neat,
The Sale hops forward, never skipping a beat!
🐇✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c52b7cd and be4953c.

📒 Files selected for processing (2)

• src/sale/Sale.php (2 hunks)
• src/sale/SaleInterface.php (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (2)

src/sale/SaleInterface.php (1)

src/sale/Sale.php (1)

• close (108-121)

src/sale/Sale.php (1)

src/sale/SaleInterface.php (1)

• close (74-74)

🔇 Additional comments (2)

src/sale/SaleInterface.php (1)

74-74: Return type change enables fluent interface pattern.

Changing the return type from void to self allows for method chaining, which improves code readability and follows the fluent interface pattern. The implementation in Sale.php has been updated to match this change by returning $this.

src/sale/Sale.php (1)

108-121: Implementation correctly updated to match interface.

The method signature has been properly updated to return self and the implementation now returns $this at the end, which aligns with the updated interface. This change maintains all the existing validation logic while enabling method chaining for a more fluent API.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.