Skip to content

HP-2446: format number as string #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SilverFire merged 2 commits into from
May 7, 2025
Merged

HP-2446: format number as string #98

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4a4ebe
HP-2446: format number as string
bladeroot Apr 22, 2025
b8a622b
Fix test
bladeroot May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/price/ProgressivePrice.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ public function calculateSum(QuantityInterface $quantity): ?Money
$price = $threshold->price();

$chargedAmount = $price->money()
->multiply((string)$billedUsage->getQuantity())
->divide((string)($price->multiplier()));
->multiply((string)(sprintf('%.14F', $billedUsage->getQuantity())))
->divide((string)(sprintf('%.14F', $price->multiplier())));
Comment on lines +108 to +109
Copy link
Copy Markdown
Member

@SilverFire SilverFire Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, cover this case with a unit test in https://github.com/hiqdev/php-billing/blob/master/tests/unit/price/ProgressivePriceTest.php


$this->calculationTraces[] = new ProgressivePriceCalculationTrace(
$threshold, $billedUsage, $chargedAmount
Expand Down
Loading