chore(deps): update dependency lucide-react to v1#73
Conversation
a92747d to
aab3c29
Compare
a30cbee to
65c4ee5
Compare
5559657 to
55abf4f
Compare
55abf4f to
70fc414
Compare
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/simulator/package.json`:
- Line 15: The lucide-react v1.8.0 release removed brand icons and the
simulator's import of Github and Twitter in apps/simulator/src/app/page.tsx
causes runtime errors; update the import and usage to use supported non-brand
icons (e.g., replace Github with GitBranch and Twitter with Hash or another
suitable icon) or switch to an icon library that provides brand icons, then
update the JSX where Github and Twitter are rendered to use the new component
names (e.g., GitBranch, Hash) so imports and usages (import lines in page.tsx
and the component references) match.
In `@apps/web/package.json`:
- Line 29: The lucide-react v1.8.0 upgrade removed brand icons so the import of
Github (used in the GitHubButton component) will break; update the import and
JSX in the GitHubButton component to use an alternative (either install and
import a brand icon from a different package like `@react-icons/fa` (e.g.,
FaGithub) and replace the Github symbol in the component, or import
lucide-react's ExternalLink and swap the Github symbol for ExternalLink as a
fallback), ensuring you remove the now-missing Github import and update the
component's prop/usages accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f62c9e9b-1af4-4982-acff-2e2360c2d60f
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
apps/simulator/package.jsonapps/web/package.json
| "dependencies": { | ||
| "@next/third-parties": "16.2.4", | ||
| "lucide-react": "0.577.0", | ||
| "lucide-react": "1.8.0", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Find all lucide-react imports in apps/simulator to verify v1 compatibility
# Search for all lucide-react imports with context
rg -n --type=ts --type=tsx -C2 "from ['\"]lucide-react['\"]" apps/simulator/src
# Check for potential brand icons (common ones removed in v1)
echo "=== Checking for potentially removed brand icons ==="
rg -n --type=ts --type=tsx -w "Github|Facebook|Twitter|Linkedin|Instagram|Youtube|Slack|Discord|Figma|Chrome|Firefox|Apple|Android|Windows" apps/simulator/src | grep -i "lucide-react"Repository: hiroppy/mf-dashboard
Length of output: 189
🏁 Script executed:
#!/bin/bash
# Find all .ts and .tsx files in apps/simulator/src and search for lucide-react imports
# First, verify the version in package.json
echo "=== lucide-react version in package.json ==="
rg -A 1 "lucide-react" apps/simulator/package.json
echo ""
echo "=== Finding lucide-react imports ==="
# Use fd to find all ts/tsx files, then grep for lucide-react imports
fd -e ts -e tsx . apps/simulator/src | xargs rg -n "from ['\"]lucide-react['\"]" 2>/dev/null || echo "No imports found"
echo ""
echo "=== Checking for potentially removed brand icons ==="
# Check for specific brand icon imports
fd -e ts -e tsx . apps/simulator/src -x rg -l "Github|Facebook|Twitter|Linkedin|Instagram|Youtube|Slack|Discord|Figma" {} \; 2>/dev/null || echo "No brand icons found"
echo ""
echo "=== List all files in apps/simulator/src to understand structure ==="
find apps/simulator/src -type f \( -name "*.ts" -o -name "*.tsx" \) | head -20Repository: hiroppy/mf-dashboard
Length of output: 556
Replace brand icons removed in lucide-react v1 with alternatives.
The simulator app imports Github and Twitter brand icons from lucide-react at apps/simulator/src/app/page.tsx:2. These icons were removed in v1.8.0 and will cause runtime errors. Replace them with non-brand alternatives like Github → GitBranch, or use an icon library that provides brand icons.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@apps/simulator/package.json` at line 15, The lucide-react v1.8.0 release
removed brand icons and the simulator's import of Github and Twitter in
apps/simulator/src/app/page.tsx causes runtime errors; update the import and
usage to use supported non-brand icons (e.g., replace Github with GitBranch and
Twitter with Hash or another suitable icon) or switch to an icon library that
provides brand icons, then update the JSX where Github and Twitter are rendered
to use the new component names (e.g., GitBranch, Hash) so imports and usages
(import lines in page.tsx and the component references) match.
| "clsx": "2.1.1", | ||
| "cmdk": "1.1.1", | ||
| "lucide-react": "0.577.0", | ||
| "lucide-react": "1.8.0", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Find all lucide-react imports in apps/web to identify brand icons and verify compatibility
# Search for all lucide-react imports with context
rg -n --type=ts --type=tsx -C2 "from ['\"]lucide-react['\"]" apps/web/src
# List common brand icons that were removed in v1 (search for usage)
echo "=== Checking for known removed brand icons ==="
rg -n --type=ts --type=tsx -w "Github|Facebook|Twitter|Linkedin|Instagram|Youtube|Slack|Discord|Figma|Chrome|Firefox" apps/web/src | grep -i "lucide-react"Repository: hiroppy/mf-dashboard
Length of output: 183
🏁 Script executed:
# First, let's check if the action-icons.tsx file exists and list its contents
find apps/web -name "action-icons.tsx" -type f 2>/dev/null
# Check the current directory structure
ls -la apps/web/src/components/layout/ 2>/dev/null || echo "Directory may not exist"
# List all files in apps/web/src to understand structure
find apps/web/src -type f -name "*.tsx" -o -name "*.ts" 2>/dev/null | head -20Repository: hiroppy/mf-dashboard
Length of output: 2193
🏁 Script executed:
# Search for lucide-react imports more broadly without file type restrictions
rg -n "lucide-react" apps/web/ 2>&1 | head -30
# Specifically look for Github import
rg -n "Github" apps/web/src/ 2>&1Repository: hiroppy/mf-dashboard
Length of output: 3423
🏁 Script executed:
# Check the package.json to verify the version
cat apps/web/package.json | grep -A2 -B2 "lucide-react"Repository: hiroppy/mf-dashboard
Length of output: 179
🌐 Web query:
lucide-react v1.0.0 breaking changes brand icons removed
💡 Result:
Yes, lucide-react v1.0.0 (released March 2026 as part of Lucide v1) includes breaking changes, most notably the complete removal of all brand icons. This affects icons such as Chromium, Codepen, Codesandbox, Dribbble, Facebook, Figma, Framer, Github, Gitlab, Instagram, LinkedIn, Pocket, RailSymbol, and Slack. This change was made for legal compliance (trademark/copyright issues), design consistency, and maintenance reasons, as detailed in the official Brand Logos Statement. Users relying on these icons must replace them with custom SVGs, official brand assets, or alternatives like Simple Icons. Other v1 breaking changes include: - Removed UMD build (ESM/CJS only, reducing bundle size significantly) - aria-hidden="true" now set by default on icons - Package renames and new framework support (e.g., @lucide/vue, @lucide/angular) Migration guides are available for React and other frameworks, listing the removed brand icons explicitly.
Citations:
- 1: https://lucide.dev/guide/version-1
- 2: https://lucide.dev/guide/react/migration
- 3: https://lucide.dev/guide/lucide/migration
- 4: https://github.com/lucide-icons/lucide/releases
- 5: https://github.com/lucide-icons/lucide/releases/tag/1.0.1
- 6: https://lucide.dev/brand-logo-statement
🏁 Script executed:
# Read the action-icons.tsx file to verify the exact usage
cat -n apps/web/src/components/layout/action-icons.tsxRepository: hiroppy/mf-dashboard
Length of output: 5711
🏁 Script executed:
# Also check the icon-button.stories.tsx to see if it's test/story file
cat -n apps/web/src/components/ui/icon-button.stories.tsxRepository: hiroppy/mf-dashboard
Length of output: 1377
CRITICAL: Breaking change — Github icon removed in lucide-react v1.8.0
The upgrade to lucide-react v1.8.0 includes a breaking change: all brand icons (including Github) were removed for trademark/copyright compliance. The codebase imports Github from lucide-react in apps/web/src/components/layout/action-icons.tsx:4 and uses it in the GitHubButton component at line 108, which will cause a runtime error.
Fix by either:
- Replacing the Github icon with an alternative package (e.g.,
@react-icons/faor custom SVG) - Using lucide-react's generic
ExternalLinkicon as a fallback - Downgrading or postponing this upgrade until refactored
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@apps/web/package.json` at line 29, The lucide-react v1.8.0 upgrade removed
brand icons so the import of Github (used in the GitHubButton component) will
break; update the import and JSX in the GitHubButton component to use an
alternative (either install and import a brand icon from a different package
like `@react-icons/fa` (e.g., FaGithub) and replace the Github symbol in the
component, or import lucide-react's ExternalLink and swap the Github symbol for
ExternalLink as a fallback), ensuring you remove the now-missing Github import
and update the component's prop/usages accordingly.
8b09015 to
7beeb48
Compare
7beeb48 to
58b7c25
Compare
58b7c25 to
153e668
Compare
This PR contains the following updates:
0.577.0→1.16.0Release Notes
lucide-icons/lucide (lucide-react)
v1.16.0: Version 1.16.0Compare Source
What's Changed
blendericon by @rrod497 in #3884Full Changelog: lucide-icons/lucide@1.15.0...1.16.0
v1.15.0Compare Source
v1.14.0: Version 1.14.0Compare Source
What's Changed
repeat-officon by @jguddas in #3102Full Changelog: lucide-icons/lucide@1.13.0...1.14.0
v1.13.0: Version 1.13.0Compare Source
What's Changed
waves-verticalicon by @jamiemlaw in #3867Full Changelog: lucide-icons/lucide@1.12.0...1.13.0
v1.12.0: Version 1.12.0Compare Source
What's Changed
astroidicon by @whoisBugsbunny in #4217Full Changelog: lucide-icons/lucide@1.10.0...1.12.0
v1.11.0: Version 1.11.0Compare Source
What's Changed
rotate-3dicon by @jamiemlaw in #4299layers-minusicon by @Spleefies in #4005bell-checkicon by @pettelau in #4152New Contributors
Full Changelog: lucide-icons/lucide@1.9.0...1.11.0
v1.10.0: Version 1.10.0Compare Source
What's Changed
rotate-3dicon by @jamiemlaw in #4299layers-minusicon by @Spleefies in #4005bell-checkicon by @pettelau in #4152New Contributors
Full Changelog: lucide-icons/lucide@1.9.0...1.10.0
v1.9.0: Version 1.9.0Compare Source
What's Changed
timelineicon by @jguddas in #4270New Contributors
Full Changelog: lucide-icons/lucide@1.8.0...1.9.0
v1.8.0: Version 1.8.0Compare Source
What's Changed
text-selecttosquare-dashed-textby @jguddas in #3943initOnMounted: trueforuseSessionStorageinCarbonAdOverlayby @karsa-mistmere in #4275bookmark-officon by @ZeenatLawal in #4283New Contributors
Full Changelog: lucide-icons/lucide@1.7.0...1.8.0
v1.7.0: Version 1.7.0Compare Source
What's Changed
map-pin-searchicon by @TonySullivan in #4125New Contributors
Full Changelog: lucide-icons/lucide@1.6.0...1.7.0
v1.6.0: Version 1.6.0Compare Source
What's Changed
radio-officon by @kongsgard in #4138New Contributors
Full Changelog: lucide-icons/lucide@1.5.0...1.6.0
v1.5.0: Version 1.5.0Compare Source
What's Changed
beef-officon by @jguddas in #3816Full Changelog: lucide-icons/lucide@1.4.0...1.5.0
v1.4.0: Version 1.4.0Compare Source
What's Changed
sport-shoeicon by @Youya-ui in #3953New Contributors
Full Changelog: lucide-icons/lucide@1.3.0...1.4.0
v1.3.0: Version 1.3.0Compare Source
What's Changed
shield-cogicon by @KnarliX in #3902New Contributors
Full Changelog: lucide-icons/lucide@1.2.0...1.3.0
v1.2.0: Version 1.2.0Compare Source
What's Changed
line-styleicon by @dg-ac in #4030New Contributors
Full Changelog: lucide-icons/lucide@1.1.0...1.2.0
v1.1.0: Version 1.1.0Compare Source
What's Changed
lucide-react-nativeby @karsa-mistmere in #4199arrow-big-*icon by @jguddas in #3527signposticon by @jguddas in #3531circle-user-roundicon by @karsa-mistmere in #4165roadicon by @uibalint in #3014New Contributors
Full Changelog: lucide-icons/lucide@1.0.2...1.1.0
v1.0.1: Lucide V1 🚀Compare Source
After years of work and dedication, Lucide Version 1 has been officially released!. This milestone marks a significant achievement in our journey to provide a comprehensive and versatile icon library for developers and designers alike.
It's been quite a ride — especially over the past year. Lucide has grown to over 30 million downloads per week and is used by million of projects worldwide. This release is a testament to the hard work of our community and contributors who have helped shape Lucide into what it is today.
Thank you to everyone who has supported us along the way. We couldn't have done this without you!
What's New in Version 1? TLDR;
aria-hiddenis now set by default on icons.lucidepackage).lucide-vue-nextto@lucide/vue.@lucide/angularlucidepackage.See more at Lucide Version 1
v1.0.0: Version 1.0.0Compare Source
What's Changed
schoolicon by @jguddas in #4124gpuicon by @jguddas in #4147<svg>element in two icons that were inconsistent by @LukasKalbertodt in #4166cctv-officon by @rrod497 in #4162New Contributors
Full Changelog: lucide-icons/lucide@0.577.0...1.0.0
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.