[fix]: In numpy 2.3, converting np.number to a dtype no longer allowed

numpy/numpy#28254
When constructing a dtype from a class with a dtype attribute, that attribute must be a dtype-instance rather than a thing that can be parsed as a dtype instance.

hist.datatype now returns float instead of np.number as datatype.

Author: kx79wq

histogrammar/util.py

@@ -533,8 +533,8 @@ def get_datatype(hist, itr=0):
         return []
     if isinstance(hist, histogrammar.Bag):
         if hist.dimension > 0:
-            return [np.number] * hist.dimension
-        return [str] if hist.range == "S" else [np.number]
+            return [float] * hist.dimension
+        return [str] if hist.range == "S" else [float]
     if isinstance(
         hist,
         (
@@ -550,7 +550,7 @@ def get_datatype(hist, itr=0):
             return []
         # else: no parent histogram.
         # input datatype must be a number. Let's also make an educated guess if it's a converted timestamp
-        datatype = [np.number]
+        datatype = [float]
         if isinstance(hist, histogrammar.Maximize):
             value = hist.max
         elif isinstance(hist, histogrammar.Minimize):
@@ -582,7 +582,7 @@ def get_datatype(hist, itr=0):
     else:
         # input datatype must be a number.
         # let's make an educated guess if it's a converted timestamp
-        datatype = [np.number]
+        datatype = [float]
         if isinstance(hist, (histogrammar.Bin, histogrammar.SparselyBin)):
             values = [hist.low, hist.high]
         elif isinstance(hist, histogrammar.CentrallyBin):

tests/test_numpy.py

@@ -1111,8 +1111,8 @@ def test_datatype(self):
             df, hist1, hist2, hist3 = get_test_histograms1()
 
             assert hist1.datatype == str
-            np.testing.assert_array_equal(hist2.datatype, [np.number, str])
-            np.testing.assert_array_equal(hist3.datatype, [np.datetime64, np.number, str])
+            np.testing.assert_array_equal(hist2.datatype, [float, str])
+            np.testing.assert_array_equal(hist3.datatype, [np.datetime64, float, str])
 
     def test_n_bins(self):
         """Test getting the number of allocated bins"""