Skip to content

Commit 1cae7a6

Browse files
committed
update README to name the right set of primitives
1 parent f973d5e commit 1cae7a6

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

README.md

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ The tests are thorough.
2828
* `original.py` were written during development to test all features as they were added.
2929
* `autogenerated.py` is from the language-independent testing suite ([histogrammar-multilang](https://github.com/histogrammar/histogrammar-multilang)), which provides greater coverage, value-explicitness in the test script, and cross-language agreement.
3030
* `testnumpy.py` tests numerical agreement between the conventional implementation and the Numpy implementation, which are very different. Also tests much larger datasets and infinity/NaN handling.
31+
* contrary to its name, `testnumpy.py` also compares its implementation with the literal code given in [the specification](http://histogrammar.org/docs/specification/) as well.
3132

3233
Primitive implementation is mature. Notes in the "Numpy" column are rough speedup factors for a range of tests.
3334

@@ -37,23 +38,19 @@ Primitive implementation is mature. Notes in the "Numpy" column are rough speedu
3738
| Sum | done | 40-100X |
3839
| Average | done | 40-100X |
3940
| Deviate | done | 40-80X |
40-
| AbsoluteErr | done | 40-100X |
4141
| Minimize | done | 50-150X |
4242
| Maximize | done | 50-150X |
43-
| Quantile | done | 1-5X |
43+
| Bag | done | 1.5-2X |
4444
| Bin | done | 5-25X (100 bins) |
4545
| SparselyBin | done | 4-5X (~100 bins) |
4646
| CentrallyBin | done | 25-40X (10 bins) |
47-
| AdaptivelyBin | done | not possible |
47+
| IrregularlyBin | done | 1-4X (10 plots) |
4848
| Categorize | done | 1.5X |
4949
| Fraction | done | 4-20X (100 bins) |
5050
| Stack | done | 2-12X (10 plots) |
51-
| Partition | done | 1-4X (10 plots) |
5251
| Select | done | 4-20X (100 bins) |
5352
| Limit | done | pass-through |
5453
| Label | done | pass-through |
5554
| UntypedLabel | done | pass-through |
5655
| Index | done | pass-through |
5756
| Branch | done | pass-through |
58-
| Bag | done | 1.5-2X |
59-
| Sample | done | 1-1.5X |

0 commit comments

Comments
 (0)