Skip to content

Commit d477c5c

Browse files
committed
ITK: Trim eigen_internal install-rule comments to fit prose budget
Greptile P1 finding on PR InsightSoftwareConsortium/ITK#6249: the 8-line comment block at CMakeLists.txt:971-981 and the 3-line block in Eigen3Config.cmake.in:7-9 violate ITK's prose-budget cap of 1 short line per in-source comment. Both reduce to a single load-bearing line carrying the issue reference; the rest of the rationale lives in the commit message and PR body, per AGENTS.md → prose-budget.md. Issue: InsightSoftwareConsortium/ITK#6239 Reviewer: greptile P1 on InsightSoftwareConsortium/ITK#6249
1 parent ae53bfe commit d477c5c

2 files changed

Lines changed: 2 additions & 11 deletions

File tree

CMakeLists.txt

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -968,17 +968,10 @@ target_include_directories (eigen_internal SYSTEM INTERFACE
968968

969969
# Export as title case Eigen
970970
set_target_properties (eigen_internal PROPERTIES EXPORT_NAME Eigen)
971-
# Register in ITK's main export set so find_package(ITK) resolves
972-
# eigen_internal as an IMPORTED target loaded from ITKTargets.cmake
973-
# (issue InsightSoftwareConsortium/ITK#6239: SimpleITK FetchContent +
974-
# FIND_PACKAGE_ARGS fallback). ${ITK3P_INSTALL_EXPORT_NAME} is set by
975-
# ITK proper in Modules/ThirdParty/Eigen3/src/CMakeLists.txt; if unset
976-
# (i.e. building outside ITK), this install becomes a no-op.
971+
# Issue InsightSoftwareConsortium/ITK#6239: ship eigen_internal in ITKTargets.cmake when building inside ITK.
977972
if(DEFINED ITK3P_INSTALL_EXPORT_NAME)
978973
install (TARGETS eigen_internal EXPORT ${ITK3P_INSTALL_EXPORT_NAME})
979974
endif()
980-
# Also register in the standalone ITKInternalEigen3 export set used by
981-
# find_package(ITKInternalEigen3) consumers.
982975
install (TARGETS eigen_internal EXPORT ITKInternalEigen3Targets)
983976

984977
set(EIGEN3_TARGETS_FILE ITKInternalEigen3Targets.cmake)

cmake/Eigen3Config.cmake.in

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
@PACKAGE_INIT@
55

66
if (NOT TARGET Eigen3::Eigen)
7-
# @EIGEN3_TARGETS_FILE@ is substituted at install-template time to
8-
# either Eigen3Targets.cmake (eigen_external / standalone Eigen3) or
9-
# ITKInternalEigen3Targets.cmake (eigen_internal / ITK vendored).
7+
# @EIGEN3_TARGETS_FILE@ → Eigen3Targets.cmake (external) or ITKInternalEigen3Targets.cmake (vendored).
108
include ("${CMAKE_CURRENT_LIST_DIR}/@EIGEN3_TARGETS_FILE@")
119
endif (NOT TARGET Eigen3::Eigen)

0 commit comments

Comments
 (0)