Skip to content

Commit dc6231e

Browse files
hjothamendixclaude
andcommitted
refactor: drop unused collectReachableDistances parameters
The ctx and activityMap parameters were carried over from a sibling helper but never used by the BFS traversal. Removes them and the matching `_ = ctx; _ = activityMap` discard lines, addressing AI review feedback on PR mendixlabs#327. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 parent e9a84f1 commit dc6231e

1 file changed

Lines changed: 1 addition & 6 deletions

File tree

mdl/executor/cmd_microflows_show.go

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -788,7 +788,7 @@ func findMergeForSplit(
788788

789789
branchDistances := make([]map[model.ID]int, 0, len(flows))
790790
for _, flow := range flows {
791-
branchDistances = append(branchDistances, collectReachableDistances(ctx, flow.DestinationID, flowsByOrigin, activityMap))
791+
branchDistances = append(branchDistances, collectReachableDistances(flow.DestinationID, flowsByOrigin))
792792
}
793793

794794
return selectNearestCommonMerge(activityMap, branchDistances)
@@ -825,14 +825,9 @@ func collectReachableNodes(
825825
// branch start to every reachable node. Error handler flows are excluded because
826826
// they do not participate in split/merge structural pairing.
827827
func collectReachableDistances(
828-
ctx *ExecContext,
829828
startID model.ID,
830829
flowsByOrigin map[model.ID][]*microflows.SequenceFlow,
831-
activityMap map[model.ID]microflows.MicroflowObject,
832830
) map[model.ID]int {
833-
_ = ctx
834-
_ = activityMap
835-
836831
distances := map[model.ID]int{}
837832
type queueItem struct {
838833
id model.ID

0 commit comments

Comments
 (0)