New iconset done properly, one more xcode crash fix#136
Open
jessejarvi wants to merge 2 commits into
Open
Conversation
Added a new icon which might suit MunkiAdmin a bit better. Also updated project architecture to 6.3+ from 3.x so Xcode 8 won’t crash no more.
|
Not sure if I'm a fan of that icon, but it's not up to me. :) On Oct 5, 2016, at 1:15 PM, Jesse J?rvi <notifications@github.commailto:notifications@github.com> wrote: At least this one doesn't fail just like the previous one :D You can view, comment on, or merge this pull request online at: Commit Summary
File Changes
Patch Links:
You are receiving this because you are subscribed to this thread. |
Contributor
Author
|
The icon is designed to look like the Managed Software Center but with a blueprint design to make it seem that this software is indeed used to manage Munki - instead of a brown monkey picture which isn't the munki logo. @hjuutilainen , what do you think? |
|
I like the previous icon better. |
apettinen
reviewed
Oct 10, 2016
apettinen
left a comment
apettinen
left a comment
There was a problem hiding this comment.
I like the previous icon better; the new one is basically the Managed Software Center icon in blue color.
The previous icon is more distinguishable from the App Store and MSC icons, which at least I find a good thing.
Plus I like the monkey pun.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At least this one doesn’t fail just like the previous one :D