Windows: Fix blank window in RDP sessions

Clear the window display affinity before showing the warning dialog
so the window is visible during the dialog's nested event loop.
Remove the Settings-based persistence of the warning acknowledgment.

Fixes #3621

Assisted-by: Claude (Anthropic)

Author: hluk

src/platform/win/winplatform.cpp

@@ -2,7 +2,6 @@
 
 #include "app/applicationexceptionhandler.h"
 #include "common/log.h"
-#include "common/settings.h"
 
 #include "platform/dummy/dummyclipboard.h"
 #include "winplatform.h"
@@ -298,26 +297,22 @@ bool WinPlatform::setPreventScreenCapture(WId winId, bool prevent)
     // Remote desktop clients are screen capture systems — applying
     // WDA_EXCLUDEFROMCAPTURE makes windows invisible to the remote viewer.
     if (prevent && GetSystemMetrics(SM_REMOTESESSION)) {
+        if (!SetWindowDisplayAffinity(window, WDA_NONE))
+            log("Failed to clear display affinity in remote session", LogWarning);
+
         static bool logged = false;
         if (!logged) {
             logged = true;
             log("Skipping screen capture prevention in remote desktop session", LogWarning);
-
-            const QLatin1String optionKey("Options/screen_capture_warning_acknowledged");
-            Settings settings;
-            if (!settings.value(optionKey, false).toBool()) {
-                QMessageBox::warning(
-                    nullptr,
-                    QObject::tr("Screen Capture Prevention Unavailable"),
-                    QObject::tr(
-                        "The option to hide from screenshots is enabled but cannot"
-                        " take effect in a remote desktop session. Window content"
-                        " may be visible to screen capture."));
-                settings.setValue(optionKey, true);
-            }
+            QMessageBox::warning(
+                nullptr,
+                QObject::tr("Screen Capture Prevention Unavailable"),
+                QObject::tr(
+                    "The option to hide from screenshots is enabled but cannot"
+                    " take effect in a remote desktop session. Window content"
+                    " may be visible to screen capture."));
         }
 
-        SetWindowDisplayAffinity(window, WDA_NONE);
         return false;
     }