Hdpi 5335 enable access to globalsearch without parties#1842
Open
toby-plunkett wants to merge 106 commits into
Open
Hdpi 5335 enable access to globalsearch without parties#1842toby-plunkett wants to merge 106 commits into
toby-plunkett wants to merge 106 commits into
Conversation
…-b' into HPDI-4063-caseManagementCategory-b
# Conflicts: # src/main/java/uk/gov/hmcts/reform/pcs/ccd/domain/PCSCase.java
…al role names to differ
toby-plunkett
commented
May 20, 2026
| @@ -0,0 +1,27 @@ | |||
| #!/usr/bin/env bash | |||
Collaborator
Author
There was a problem hiding this comment.
Originally reviewed under: #1714
No changes have me made
toby-plunkett
commented
May 20, 2026
| @@ -14,7 +14,6 @@ global: | |||
|
|
|||
| java: | |||
Collaborator
Author
There was a problem hiding this comment.
Lines 199-->202 contain the only changes that haven't been reviewed. The rest reviewed under #1714
toby-plunkett
commented
May 20, 2026
| @@ -53,7 +53,6 @@ withPipeline(type, product, component) { | |||
| setPreviewEnvVars() | |||
toby-plunkett
commented
May 20, 2026
|
|
||
| roleNames.add("caseworker"); | ||
| roleNames.add("caseworker-ras-validation"); | ||
| roleNames.add("GS_profile"); |
toby-plunkett
commented
May 20, 2026
| @@ -7,6 +7,7 @@ | |||
| import uk.gov.hmcts.reform.pcs.ccd.accesscontrol.CitizenAccess; | |||
benouaer
reviewed
May 20, 2026
| new CcdRoleConfig("caseworker-sscs-pcqextractor", "PUBLIC"), | ||
| new CcdRoleConfig("caseworker-sscs-hmrcresponsewriter", "PUBLIC"), | ||
| new CcdRoleConfig("caseworker-sscs-ibcaresponsewriter", "PUBLIC"), | ||
| new CcdRoleConfig("caseworker-wa-task-configuration", "RESTRICTED"), |
Contributor
There was a problem hiding this comment.
let's remember to remove these sscs roles before merging the PR
benouaer
approved these changes
May 20, 2026
| setPreviewEnvVars() | ||
| if (githubApi.getLabelsbyPattern(env.BRANCH_NAME, "pr-values:ccd").size() > 0) { | ||
| env.CCD_ENABLED = "true" | ||
| env.CASE_TYPE_SUFFIX="${CHANGE_ID}" |
Contributor
There was a problem hiding this comment.
What was the reason for removing this?
Collaborator
Author
There was a problem hiding this comment.
Global search wasn't working when we had the case number on the end of the case type.
…' of https://github.com/hmcts/pcs-api into HDPI-5335-enable-access-to-globalsearch-without-parties
guygrewal77
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira link
See HDPI-5335
Change description
This PR contains all changes needed to enable global search.
It also includes a rework of how Access Profiles are assigned, allowing us to assign multiple access profiles without duplicate lines of code.
Each of these changes has been done on a single branch and merged together for testing. However changes were made after being merged.
Due to this, most of this code has already been reviewed. I have made note of the files via comments to save time with reviews.
These changes can be found in the following Jira Tickets.
https://tools.hmcts.net/jira/browse/HDPI-6150 --> #1714
https://tools.hmcts.net/jira/browse/HDPI-4178
https://tools.hmcts.net/jira/browse/HDPI-4161
https://tools.hmcts.net/jira/browse/HDPI-4172
To be clear. The individual branches of these changes (which can be accessed via the Jira tickets above) only contain the original merge / approach. Once all these branches were combined, further changes were made which are not necessarily reflected in the original branches. Therefore, testing for these branches should be done on this combined branch.
Testing done
Testing completed via Preview environment.
Security Vulnerability Assessment
CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?
Checklist