HDPI - 6404 - Upload Additional Documents Screen#1843
Open
nicole-samuels wants to merge 18 commits into
Open
Conversation
nicole-samuels
changed the title
…ocuments-screen-3
nicole-samuels
requested review from
guygrewal77,
paddy-hmcts and
toby-plunkett
and removed request for
a team
| </p> | ||
|
|
||
| <p class="govuk-body"> | ||
| Give your document a name that explains what it is. \s |
Contributor
There was a problem hiding this comment.
Is that \s meant to be there?
Contributor
Author
There was a problem hiding this comment.
This has been removed
| label = "Add document", | ||
| hint = "Upload a document to the system" | ||
| ) | ||
| private List<ListValue<LegalRepDocument>> legalRepDocuments; |
Contributor
There was a problem hiding this comment.
It looks like it's not specified in the ticket, but ideally each ticket that captures some data from the user should include persisting it to the DB. Otherwise there is a chance that it can get forgotten about.
toby-plunkett
left a comment
toby-plunkett
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. Happy to approve once Scott's comments about data persistence are addressed.
scottstewart-sl
approved these changes
May 22, 2026
toby-plunkett
approved these changes
May 22, 2026
…ocuments-screen-3
…ocuments-screen-3
…ocuments-screen-3
…ocuments-screen-3
Contributor
Plan Result (aat) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira link
See HDPI-6404
Change description
Created a new screen for additional document uploads and updated test
Testing done
Security Vulnerability Assessment
CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?
Checklist