HDPI-6510: Gen Apps supporting docs

[scottstewart-sl]

Jira link

See HDPI-6510

Change description

Rename supporting documents that were uploaded as part of a citizen gen app, to include the gen app number and defendant label as a postfix before the file extension.

Related pcs-frontend PR: hmcts/pcs-frontend#1381

Testing done

Local testing with corresponding pcs-frontend changes

Security Vulnerability Assessment

CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?

• Yes
• No

Checklist

• commit messages are meaningful and follow good commit message guidelines
• README and other documentation has been updated / added (if needed)
• tests have been updated / new tests has been added (if needed)
• Does this PR introduce a breaking change

[github-actions]

CCD diff summary

👉 Full report: https://github.com/hmcts/pcs-api/actions/runs/26157165887?check_suite_focus=true

CaseField.json

RegularExpression	Max	Searchable	Min	FieldTypeParameter	HintText	Label	ID	FieldType
+	+	+	+	+GeneralApplication	+	+	+genApps	+Collection

AuthorisationCaseField/citizen.json

UserRole	CaseFieldID	CRUD
+citizen	+genApps	+CRUD

ComplexTypes/1_Party.json

FieldTypeParameter	ListElementCode	ID	FieldType	ElementLabel
+	+id	+Party	+Text	+
+	+idamId	+Party	+Text	+

ComplexTypes/GeneralApplication.json

ElementLabel	FieldType	FieldTypeParameter	ID	ListElementCode
+	+FixedRadioList	+GenAppType	+GeneralApplication	+applicationType
+	+Party	+GeneralApplication	+party
+	+DateTime	+GeneralApplication	+submittedOn
+	+DocumentWithId	+GeneralApplication	+submissionDocument
+	+Collection	+Document	+GeneralApplication	+supportingDocuments

ComplexTypes/2_DocumentWithId.json

ElementLabel	FieldType	ID	ListElementCode
+	+Text	+DocumentWithId	+id
+	+Document	+DocumentWithId	+document

[tvr-hmcts]

Just some quesions from me.

[guygrewal77]

Not related to your changes but is it possible to get some coverage on GenAppDocumentGenerator.getPartyLabel() to cover all scenarios ?

[scottstewart-sl]

@guygrewal77

Not related to your changes but is it possible to get some coverage on GenAppDocumentGenerator.getPartyLabel() to cover all scenarios ?

I've actually refactored this code out in my next PR, (still in draft), and that adds coverage for that method, (after it was moved):

See DocumentNamingServiceTest.java in

https://github.com/hmcts/pcs-api/pull/1839/changes#diff-f85ea874cddd37a3d372bd2c30b1ef38c3ff4b26fd1237b503e45feb409d6916