HDPI-6510: Gen Apps supporting docs#1853
Open
scottstewart-sl wants to merge 2 commits into
Open
Conversation
Signed-off-by: sstewart <202802468+scottstewart-sl@users.noreply.github.com>
CCD diff summary👉 Full report: https://github.com/hmcts/pcs-api/actions/runs/26157165887?check_suite_focus=true CaseField.json
AuthorisationCaseField/citizen.json
ComplexTypes/1_Party.json
ComplexTypes/GeneralApplication.json
ComplexTypes/2_DocumentWithId.json
|
Signed-off-by: sstewart <202802468+scottstewart-sl@users.noreply.github.com>
6 tasks
scottstewart-sl
changed the base branch from
master
to
HDPI-4573_view_applications
scottstewart-sl
requested review from
ayub-macalim,
benouaer and
guygrewal77
and removed request for
a team
tvr-hmcts
reviewed
May 20, 2026
Contributor
tvr-hmcts
left a comment
tvr-hmcts
left a comment
There was a problem hiding this comment.
Just some quesions from me.
Contributor
|
Not related to your changes but is it possible to get some coverage on GenAppDocumentGenerator.getPartyLabel() to cover all scenarios ? |
Contributor
Author
I've actually refactored this code out in my next PR, (still in draft), and that adds coverage for that method, (after it was moved): See |
tvr-hmcts
approved these changes
May 21, 2026
aqibh25
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira link
See HDPI-6510
Change description
Rename supporting documents that were uploaded as part of a citizen gen app, to include the gen app number and defendant label as a postfix before the file extension.
Related pcs-frontend PR: hmcts/pcs-frontend#1381
Testing done
Local testing with corresponding pcs-frontend changes
Security Vulnerability Assessment
CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?
Checklist