HDPI-7213: Add CftLibTest for citizen gen app creation#2033
Open
scottstewart-sl wants to merge 18 commits into
Open
HDPI-7213: Add CftLibTest for citizen gen app creation#2033scottstewart-sl wants to merge 18 commits into
scottstewart-sl wants to merge 18 commits into
Conversation
Includes shared wiremock stubs for document services and also a wiremock test for emails
CCD diff summary👉 Full report: https://github.com/hmcts/pcs-api/actions/runs/29101576484?check_suite_focus=true No change |
…email_testing # Conflicts: # src/main/java/uk/gov/hmcts/reform/pcs/testingsupport/endpoint/TestingSupportController.java # src/test/java/uk/gov/hmcts/reform/pcs/testingsupport/endpoint/TestingSupportControllerTest.java
scottstewart-sl
added
the
enable_e2e_test
scottstewart-sl
added
enable_keep_helm
and removed
enable_e2e_test
…email_testing # Conflicts: # src/main/java/uk/gov/hmcts/reform/pcs/ccd/service/AccessCodeGenerationService.java # src/main/java/uk/gov/hmcts/reform/pcs/testingsupport/config/TestingSupportSchemaInitializer.java # src/main/java/uk/gov/hmcts/reform/pcs/testingsupport/endpoint/TestingSupportController.java # src/test/java/uk/gov/hmcts/reform/pcs/ccd/service/AccessCodeGenerationServiceTest.java # src/test/java/uk/gov/hmcts/reform/pcs/testingsupport/endpoint/TestingSupportControllerTest.java
Also override DB scheduler polling interval to be shorter for CftLibTests
…cs-api into HDPI-7213_wiremock_email_testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira link
See HDPI-7213
Change description
Add a CftLibTest for citizen gen app creation. This includes some refactoring of the Cftlib code to have more re-usable setup methods, and some shared wiremock stubs for the document services. The Citizen gen app test also runs up its own wiremock so that email notifications can be checked. The main test class that has been added is
CitizenMakeAnApplicationTestI've brought in some changes from #1984 which record the defendant access codes in a dedicated table for tests, so that the CftLib test can get an access code and that won't break after #1984 is merged.
Testing done
Build run.
Security Vulnerability Assessment
CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?
Checklist