Dtsrd 4084#1004
Open
SabinaHMCTS wants to merge 248 commits into
Open
Conversation
mattnayler
requested changes
Feb 26, 2025
| + "on per.personalCode = appt.personalCode " | ||
| + "LEFT JOIN FETCH judicialOfficeAuthorisation auth " | ||
| + "on auth.appointmentId = appt.appointmentId " | ||
| + "on auth.personalCode = appt.personalCode " |
Contributor
There was a problem hiding this comment.
I think this should:
- always match on personcode 👍
- also match on either
auth.appointmentId is nullorauth.appointmentId = appt.appointmentId
i.e. if there is an appointment ID then we should filter the authorisations JOIN on it: with personcode being the fallback for theose authorisations that have no parent appointment so should apply to all of the person's appointments.
| var profiles = (List<Map<String, String>>) response.get("body"); | ||
| if (("BBA3").equals(serviceCode)) { | ||
| assertEquals(0, profiles.size()); | ||
| assertEquals(1, profiles.size()); |
Contributor
There was a problem hiding this comment.
Can we confirm in the integration tests data that we have a scenario to test mapping where
- mapped via personcode and apponitment_id is null (i.e. data should be found)
- mapped via personcode and appointment_id is set to active appointment (i.e. data should be found)
- mapped via personcode and appointment_id is set to expired appointment (i.e. data should not be found)
From my quick (possibly incorrect) review of data in 'src/integrationTest/resources/db/testmigration/V1_74__elinks_insert_user_profile.sql': I assume this assert should probably return 0. as I think the appointment has expired.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira link
See PROJ-XXXXXX
Change description
Testing done
Checklist